* [PATCH 1/3] drm/xen-front: checking for NULL instead of IS_ERR
@ 2018-05-08 9:26 Dan Carpenter
2018-05-08 9:34 ` Oleksandr Andrushchenko
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2018-05-08 9:26 UTC (permalink / raw)
To: Oleksandr Andrushchenko
Cc: David Airlie, kernel-janitors, dri-devel, xen-devel
drm_dev_alloc() returns error pointers, it never returns NULL.
Fixes: c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
index 1b0ea9ac330e..8615e8522c7a 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -543,8 +543,8 @@ static int xen_drm_drv_init(struct xen_drm_front_info *front_info)
front_info->drm_info = drm_info;
drm_dev = drm_dev_alloc(&xen_drm_driver, dev);
- if (!drm_dev) {
- ret = -ENOMEM;
+ if (IS_ERR(drm_dev)) {
+ ret = PTR_ERR(drm_dev);
goto fail;
}
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] drm/xen-front: checking for NULL instead of IS_ERR
2018-05-08 9:26 [PATCH 1/3] drm/xen-front: checking for NULL instead of IS_ERR Dan Carpenter
@ 2018-05-08 9:34 ` Oleksandr Andrushchenko
2018-05-08 11:50 ` Oleksandr Andrushchenko
0 siblings, 1 reply; 3+ messages in thread
From: Oleksandr Andrushchenko @ 2018-05-08 9:34 UTC (permalink / raw)
To: Dan Carpenter, Oleksandr Andrushchenko
Cc: David Airlie, kernel-janitors, dri-devel, xen-devel
On 05/08/2018 12:26 PM, Dan Carpenter wrote:
> drm_dev_alloc() returns error pointers, it never returns NULL.
>
> Fixes: c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you,
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> index 1b0ea9ac330e..8615e8522c7a 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -543,8 +543,8 @@ static int xen_drm_drv_init(struct xen_drm_front_info *front_info)
> front_info->drm_info = drm_info;
>
> drm_dev = drm_dev_alloc(&xen_drm_driver, dev);
> - if (!drm_dev) {
> - ret = -ENOMEM;
> + if (IS_ERR(drm_dev)) {
> + ret = PTR_ERR(drm_dev);
> goto fail;
> }
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] drm/xen-front: checking for NULL instead of IS_ERR
2018-05-08 9:34 ` Oleksandr Andrushchenko
@ 2018-05-08 11:50 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 3+ messages in thread
From: Oleksandr Andrushchenko @ 2018-05-08 11:50 UTC (permalink / raw)
To: Dan Carpenter, Oleksandr Andrushchenko
Cc: David Airlie, kernel-janitors, dri-devel, xen-devel
On 05/08/2018 12:34 PM, Oleksandr Andrushchenko wrote:
> On 05/08/2018 12:26 PM, Dan Carpenter wrote:
>> drm_dev_alloc() returns error pointers, it never returns NULL.
>>
>> Fixes: c575b7eeb89f ("drm/xen-front: Add support for Xen PV display
>> frontend")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Thank you,
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Applied to drm-misc-next,
Thank you
>>
>> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c
>> b/drivers/gpu/drm/xen/xen_drm_front.c
>> index 1b0ea9ac330e..8615e8522c7a 100644
>> --- a/drivers/gpu/drm/xen/xen_drm_front.c
>> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
>> @@ -543,8 +543,8 @@ static int xen_drm_drv_init(struct
>> xen_drm_front_info *front_info)
>> front_info->drm_info = drm_info;
>> drm_dev = drm_dev_alloc(&xen_drm_driver, dev);
>> - if (!drm_dev) {
>> - ret = -ENOMEM;
>> + if (IS_ERR(drm_dev)) {
>> + ret = PTR_ERR(drm_dev);
>> goto fail;
>> }
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-08 11:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-08 9:26 [PATCH 1/3] drm/xen-front: checking for NULL instead of IS_ERR Dan Carpenter
2018-05-08 9:34 ` Oleksandr Andrushchenko
2018-05-08 11:50 ` Oleksandr Andrushchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).