From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] drm: Fix writeback_job leak when state is check only or check failed Date: Thu, 21 Feb 2019 14:56:56 +0100 Message-ID: <0d1a7597-2c08-0fce-035e-bf8764ff88d8@linux.intel.com> References: <20190221111304.846-1-james.qian.wang@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 70A30895C1 for ; Thu, 21 Feb 2019 13:57:01 +0000 (UTC) In-Reply-To: <20190221111304.846-1-james.qian.wang@arm.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "james qian wang (Arm Technology China)" , Liviu Dudau , "airlied@linux.ie" , Brian Starkey , "maxime.ripard@bootlin.com" , "sean@poorly.run" Cc: "Julien Yin (Arm Technology China)" , "Jonathan Chai (Arm Technology China)" , nd , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org SGV5CgpPcCAyMS0wMi0yMDE5IG9tIDEyOjE0IHNjaHJlZWYgamFtZXMgcWlhbiB3YW5nIChBcm0g VGVjaG5vbG9neSBDaGluYSk6Cj4gVGhlIHdyaXRlYmFjayBqb2Igd2lsbCBub3QgYmUgYWRkZWQg dG8gd3JpdGViYWNrIHF1ZXVlIGlmIHRoZSBzdGF0ZSBpcwo+IGNoZWNrIG9ubHkgb3IgY2hlY2sg ZmFpbGVkLCB0byBhdm9pZCBsZWFrLCBuZWVkIHRvIGNsZWFudXAgd3JpdGViYWNrIGpvYgo+IGlu IGNvbm5lY3Rvcl9kZXN0cm95X3N0YXRlIGlmIHRoZSBqb2IgZXhpc3RlZC4KPgo+IFNpZ25lZC1v ZmYtYnk6IEphbWVzIFFpYW4gV2FuZyAoQXJtIFRlY2hub2xvZ3kgQ2hpbmEpIDxqYW1lcy5xaWFu LndhbmdAYXJtLmNvbT4KCklzIHdyaXRlYmFja19qb2IgaW4gdGhlIGNvbm5fc3RhdGUgc2V0IHRv IG51bGwgc29tZXdoZXJlPyBJJ20gd29ycmllZCB3ZSBtaWdodCBlbmQgdXAgZnJlZWluZyB3cml0 ZWJhY2tfam9iIHR3aWNlIG9uIHN1Y2Nlc3MuCgp+TWFhcnRlbgoKPiAgZHJpdmVycy9ncHUvZHJt L2RybV9hdG9taWNfc3RhdGVfaGVscGVyLmMgfCAgNCArKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9k cm1fd3JpdGViYWNrLmMgICAgICAgICAgIHwgMjEgKysrKysrKysrKysrKysrKysrLS0tCj4gIDIg ZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19zdGF0ZV9oZWxwZXIuYyBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fYXRvbWljX3N0YXRlX2hlbHBlci5jCj4gaW5kZXggNDk4NTM4NGU1MWY2 Li42YThlNDE0MjMzZGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNf c3RhdGVfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19zdGF0ZV9o ZWxwZXIuYwo+IEBAIC0yOCw2ICsyOCw3IEBACj4gICNpbmNsdWRlIDxkcm0vZHJtX2NydGMuaD4K PiAgI2luY2x1ZGUgPGRybS9kcm1fcGxhbmUuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fY29ubmVj dG9yLmg+Cj4gKyNpbmNsdWRlIDxkcm0vZHJtX3dyaXRlYmFjay5oPgo+ICAjaW5jbHVkZSA8ZHJt L2RybV9hdG9taWMuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fZGV2aWNlLmg+Cj4gIAo+IEBAIC00 MDcsNiArNDA4LDkgQEAgRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3Jf ZHVwbGljYXRlX3N0YXRlKTsKPiAgdm9pZAo+ICBfX2RybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rv cl9kZXN0cm95X3N0YXRlKHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpzdGF0ZSkKPiAgewo+ ICsJaWYgKHN0YXRlLT53cml0ZWJhY2tfam9iKQo+ICsJCWRybV93cml0ZWJhY2tfY2xlYW51cF9q b2Ioc3RhdGUtPndyaXRlYmFja19qb2IpOwo+ICsKPiAgCWlmIChzdGF0ZS0+Y3J0YykKPiAgCQlk cm1fY29ubmVjdG9yX3B1dChzdGF0ZS0+Y29ubmVjdG9yKTsKPiAgCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1fd3JpdGViYWNrLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3dyaXRl YmFjay5jCj4gaW5kZXggYzIwZTZmZTAwY2IzLi40ODYxMjExNTBlYWEgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2RybV93cml0ZWJhY2suYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fd3JpdGViYWNrLmMKPiBAQCAtMjY4LDYgKzI2OCwyMiBAQCB2b2lkIGRybV93cml0ZWJhY2tf cXVldWVfam9iKHN0cnVjdCBkcm1fd3JpdGViYWNrX2Nvbm5lY3RvciAqd2JfY29ubmVjdG9yLAo+ ICB9Cj4gIEVYUE9SVF9TWU1CT0woZHJtX3dyaXRlYmFja19xdWV1ZV9qb2IpOwo+ICAKPiArLyoq Cj4gKyAqIGRybV93cml0ZWJhY2tfY2xlYW51cF9qb2IgLSBjbGVhbnVwIGEgd3JpdGViYWNrIGpv Ygo+ICsgKiBAam9iOiBUaGUgam9iIHRvIGNsZWFudXAKPiArICovCj4gK3ZvaWQgZHJtX3dyaXRl YmFja19jbGVhbnVwX2pvYihzdHJ1Y3QgZHJtX3dyaXRlYmFja19qb2IgKmpvYikKPiArewo+ICsJ aWYgKGpvYi0+ZmIpCj4gKwkJZHJtX2ZyYW1lYnVmZmVyX3B1dChqb2ItPmZiKTsKPiArCj4gKwlp ZiAoam9iLT5vdXRfZmVuY2UpCj4gKwkJZG1hX2ZlbmNlX3B1dChqb2ItPm91dF9mZW5jZSk7Cj4g Kwo+ICsJa2ZyZWUoam9iKTsKPiArfQo+ICtFWFBPUlRfU1lNQk9MKGRybV93cml0ZWJhY2tfY2xl YW51cF9qb2IpOwo+ICsKPiAgLyoKPiAgICogQGNsZWFudXBfd29yazogZGVmZXJyZWQgY2xlYW51 cCBvZiBhIHdyaXRlYmFjayBqb2IKPiAgICoKPiBAQCAtMjgwLDExICsyOTYsOSBAQCBzdGF0aWMg dm9pZCBjbGVhbnVwX3dvcmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAJc3RydWN0IGRy bV93cml0ZWJhY2tfam9iICpqb2IgPSBjb250YWluZXJfb2Yod29yaywKPiAgCQkJCQkJICAgICBz dHJ1Y3QgZHJtX3dyaXRlYmFja19qb2IsCj4gIAkJCQkJCSAgICAgY2xlYW51cF93b3JrKTsKPiAt CWRybV9mcmFtZWJ1ZmZlcl9wdXQoam9iLT5mYik7Cj4gLQlrZnJlZShqb2IpOwo+ICsJZHJtX3dy aXRlYmFja19jbGVhbnVwX2pvYihqb2IpOwo+ICB9Cj4gIAo+IC0KPiAgLyoqCj4gICAqIGRybV93 cml0ZWJhY2tfc2lnbmFsX2NvbXBsZXRpb24gLSBTaWduYWwgdGhlIGNvbXBsZXRpb24gb2YgYSB3 cml0ZWJhY2sgam9iCj4gICAqIEB3Yl9jb25uZWN0b3I6IFRoZSB3cml0ZWJhY2sgY29ubmVjdG9y IHdob3NlIGpvYiBpcyBjb21wbGV0ZQo+IEBAIC0zMTksNiArMzMzLDcgQEAgZHJtX3dyaXRlYmFj a19zaWduYWxfY29tcGxldGlvbihzdHJ1Y3QgZHJtX3dyaXRlYmFja19jb25uZWN0b3IgKndiX2Nv bm5lY3RvciwKPiAgCQkJCWRtYV9mZW5jZV9zZXRfZXJyb3Ioam9iLT5vdXRfZmVuY2UsIHN0YXR1 cyk7Cj4gIAkJCWRtYV9mZW5jZV9zaWduYWwoam9iLT5vdXRfZmVuY2UpOwo+ICAJCQlkbWFfZmVu Y2VfcHV0KGpvYi0+b3V0X2ZlbmNlKTsKPiArCQkJam9iLT5vdXRfZmVuY2UgPSBOVUxMOwo+ICAJ CX0KPiAgCX0KPiAgCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJndiX2Nvbm5lY3Rvci0+am9iX2xv Y2ssIGZsYWdzKTsKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWw=