From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/2] dma-buf: try to replace a signaled fence in reservation_object_add_shared_inplace Date: Wed, 15 Nov 2017 19:56:43 +0100 Message-ID: <0e57934b-4189-719b-d93f-03d4fcec2073@gmail.com> References: <20171030145904.18584-1-deathsimple@vodafone.de> <20171030145904.18584-2-deathsimple@vodafone.de> <150998532204.10527.4781311190552781355@mail.alporthouse.com> <4fc05061-e92d-1702-a0f6-ee337b7d3eb3@gmail.com> <151067004520.20436.1513830153061032440@mail.alporthouse.com> <151076492143.19172.10013343108476631614@mail.alporthouse.com> <1a565164-85cf-0678-b6ab-802ec047bb91@amd.com> <151076779232.19172.5265207291862820032@mail.alporthouse.com> Reply-To: christian.koenig@amd.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <151076779232.19172.5265207291862820032@mail.alporthouse.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson , =?UTF-8?Q?Christian_K=c3=b6nig?= , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QW0gMTUuMTEuMjAxNyB1bSAxODo0MyBzY2hyaWViIENocmlzIFdpbHNvbjoKPiBRdW90aW5nIENo cmlzdGlhbiBLw7ZuaWcgKDIwMTctMTEtMTUgMTc6MzQ6MDcpCj4+IEFtIDE1LjExLjIwMTcgdW0g MTc6NTUgc2NocmllYiBDaHJpcyBXaWxzb246Cj4+PiBRdW90aW5nIENocmlzIFdpbHNvbiAoMjAx Ny0xMS0xNCAxNDozNDowNSkKPj4+PiBRdW90aW5nIENocmlzdGlhbiBLw7ZuaWcgKDIwMTctMTEt MTQgMTQ6MjQ6NDQpCj4+Pj4+IEFtIDA2LjExLjIwMTcgdW0gMTc6MjIgc2NocmllYiBDaHJpcyBX aWxzb246Cj4+Pj4+PiBRdW90aW5nIENocmlzdGlhbiBLw7ZuaWcgKDIwMTctMTAtMzAgMTQ6NTk6 MDQpCj4+Pj4+Pj4gQEAgLTEyNiwxNyArMTI3LDI4IEBAIHJlc2VydmF0aW9uX29iamVjdF9hZGRf c2hhcmVkX2lucGxhY2Uoc3RydWN0IHJlc2VydmF0aW9uX29iamVjdCAqb2JqLAo+Pj4+Pj4+ICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGRtYV9mZW5jZV9wdXQob2xkX2ZlbmNlKTsKPj4+Pj4+ PiAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm47Cj4+Pj4+Pj4gICAgICAgICAgICAg ICAgICAgIH0KPj4+Pj4+PiArCj4+Pj4+Pj4gKyAgICAgICAgICAgICAgIGlmICghc2lnbmFsZWQg JiYgZG1hX2ZlbmNlX2lzX3NpZ25hbGVkKG9sZF9mZW5jZSkpIHsKPj4+Pj4+PiArICAgICAgICAg ICAgICAgICAgICAgICBzaWduYWxlZCA9IG9sZF9mZW5jZTsKPj4+Pj4+PiArICAgICAgICAgICAg ICAgICAgICAgICBzaWduYWxlZF9pZHggPSBpOwo+Pj4+Pj4+ICsgICAgICAgICAgICAgICB9Cj4+ Pj4+PiBIb3cgbXVjaCBkbyB3ZSBjYXJlIGFib3V0IG9ubHkga2VlcGluZyBvbmUgZmVuY2UgcGVy LWN0eCBoZXJlPyBZb3UgY291bGQKPj4+Pj4+IHJlYXJyYW5nZSB0aGlzIHRvIGJyZWFrIG9uIG9s ZF9mZW5jZS0+Y29udGV4dCA9PSBmZW5jZS0+Y29udGV4dCB8fAo+Pj4+Pj4gZG1hX2ZlbmNlX2lz X3NpZ25hbGVkKG9sZF9mZW5jZSkgdGhlbiBldmVyeW9uZSBjYW4gdXNlIHRoZSBmaW5hbCBibG9j ay4KPj4+Pj4gWWVhaCwgdGhhdCBpcyB3aGF0IERhdmlkIFpob3Ugc3VnZ2VzdGVkIGFzIHdlbGwu Cj4+Pj4+Cj4+Pj4+IEkndmUgcmVqZWN0ZWQgdGhpcyBhcHByb2FjaCBmb3Igbm93IGNhdXNlIEkg dGhpbmsgd2Ugc3RpbGwgaGF2ZSBjYXNlcwo+Pj4+PiB3aGVyZSB3ZSByZWx5IG9uIG9uZSBmZW5j ZSBwZXIgY3R4IChidXQgSSdtIG5vdCAxMDAlIHN1cmUpLgo+Pj4+Pgo+Pj4+PiBJIGNoYW5nZWQg cGF0Y2ggIzEgaW4gdGhpcyBzZXJpZXMgYXMgeW91IHN1Z2dlc3QgYW5kIGdvaW5nIHRvIHNlbmQg dGhhdAo+Pj4+PiBvdXQgb25jZSBtb3JlIGluIGEgbWludXRlLgo+Pj4+Pgo+Pj4+PiBDYW4gd2Ug Z2V0IHRoaXMgdXBzdHJlYW0gYXMgaXMgZm9yIG5vdz8gSSB3b24ndCBoYXZlIG11Y2ggbW9yZSB0 aW1lCj4+Pj4+IHdvcmtpbmcgb24gdGhpcy4KPj4+PiBTdXJlLCB3ZSBhcmUgb25seSBkaXNjdXNz aW5nIGhvdyB3ZSBtaWdodCBtYWtlIGl0IGxvb2sgdGlkaWVyLCBwdXJlCj4+Pj4gbWljcm8tb3B0 aW1pc2F0aW9uIHdpdGggdGhlIGNhdmVhdCBvZiBsb3NpbmcgdGhlIG9uZS1mZW5jZS1wZXItY3R4 Cj4+Pj4gZ3VhcmFudGVlLgo+Pj4gQWgsIG9uZSB0aGluZyB0byBub3RlIGlzIHRoYXQgZXh0cmEg Y2hlY2tpbmcgcHVzaGVkIG9uZSBvZiBvdXIgY29ybmVyCj4+PiBjYXNlIHRlc3RzIG92ZXIgaXRz IHRpbWUgbGltaXQuCj4+Pgo+Pj4gSWYgd2UgY2FuIGNvbXBsZXRlbHkgZm9yZ28gdGhlIG9uZS1m ZW5jZS1wZXItY3R4IGhlcmUsIHdoYXQgd29ya3MgcmVhbGx5Cj4+PiB3ZWxsIGluIHRlc3Rpbmcg aXMKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kbWEtYnVmL3Jlc2VydmF0aW9uLmMgYi9k cml2ZXJzL2RtYS1idWYvcmVzZXJ2YXRpb24uYwo+Pj4gaW5kZXggNTMxOWFjNDc4OTE4Li41NzU1 ZTk1ZmFiMWIgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2RtYS1idWYvcmVzZXJ2YXRpb24uYwo+ Pj4gKysrIGIvZHJpdmVycy9kbWEtYnVmL3Jlc2VydmF0aW9uLmMKPj4+IEBAIC0xMDQsMzkgKzEw NCwxOSBAQCByZXNlcnZhdGlvbl9vYmplY3RfYWRkX3NoYXJlZF9pbnBsYWNlKHN0cnVjdCByZXNl cnZhdGlvbl9vYmplY3QgKm9iaiwKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBzdHJ1Y3QgcmVzZXJ2YXRpb25fb2JqZWN0X2xpc3QgKmZvYmosCj4+PiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRtYV9mZW5jZSAqZmVuY2Up Cj4+PiAgICB7Cj4+PiAtICAgICAgIHN0cnVjdCBkbWFfZmVuY2UgKnJlcGxhY2UgPSBOVUxMOwo+ Pj4gLSAgICAgICB1MzIgY3R4ID0gZmVuY2UtPmNvbnRleHQ7Cj4+PiAtICAgICAgIHUzMiBpOwo+ Pj4gLQo+Pj4gICAgICAgICAgIGRtYV9mZW5jZV9nZXQoZmVuY2UpOwo+Pj4gICAgCj4+PiAgICAg ICAgICAgcHJlZW1wdF9kaXNhYmxlKCk7Cj4+PiAgICAgICAgICAgd3JpdGVfc2VxY291bnRfYmVn aW4oJm9iai0+c2VxKTsKPj4+ICAgIAo+Pj4gLSAgICAgICBmb3IgKGkgPSAwOyBpIDwgZm9iai0+ c2hhcmVkX2NvdW50OyArK2kpIHsKPj4+IC0gICAgICAgICAgICAgICBzdHJ1Y3QgZG1hX2ZlbmNl ICpjaGVjazsKPj4+IC0KPj4+IC0gICAgICAgICAgICAgICBjaGVjayA9IHJjdV9kZXJlZmVyZW5j ZV9wcm90ZWN0ZWQoZm9iai0+c2hhcmVkW2ldLAo+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICByZXNlcnZhdGlvbl9vYmplY3RfaGVsZChvYmopKTsK Pj4+IC0KPj4+IC0gICAgICAgICAgICAgICBpZiAoY2hlY2stPmNvbnRleHQgPT0gY3R4IHx8IGRt YV9mZW5jZV9pc19zaWduYWxlZChjaGVjaykpIHsKPj4+IC0gICAgICAgICAgICAgICAgICAgICAg IHJlcGxhY2UgPSBvbGRfZmVuY2U7Cj4+PiAtICAgICAgICAgICAgICAgICAgICAgICBicmVhazsK Pj4+IC0gICAgICAgICAgICAgICB9Cj4+PiAtICAgICAgIH0KPj4+IC0KPj4+ICAgICAgICAgICAv Kgo+Pj4gICAgICAgICAgICAqIG1lbW9yeSBiYXJyaWVyIGlzIGFkZGVkIGJ5IHdyaXRlX3NlcWNv dW50X2JlZ2luLAo+Pj4gICAgICAgICAgICAqIGZvYmotPnNoYXJlZF9jb3VudCBpcyBwcm90ZWN0 ZWQgYnkgdGhpcyBsb2NrIHRvbwo+Pj4gICAgICAgICAgICAqLwo+Pj4gLSAgICAgICBSQ1VfSU5J VF9QT0lOVEVSKGZvYmotPnNoYXJlZFtpXSwgZmVuY2UpOwo+Pj4gLSAgICAgICBpZiAoIXJlcGxh Y2UpCj4+PiAtICAgICAgICAgICAgICAgZm9iai0+c2hhcmVkX2NvdW50Kys7Cj4+PiArICAgICAg IFJDVV9JTklUX1BPSU5URVIoZm9iai0+c2hhcmVkW2ZvYmotPnNoYXJlZF9jb3VudCsrXSwgZmVu Y2UpOwo+Pj4gICAgCj4+PiAgICAgICAgICAgd3JpdGVfc2VxY291bnRfZW5kKCZvYmotPnNlcSk7 Cj4+PiAgICAgICAgICAgcHJlZW1wdF9lbmFibGUoKTsKPj4+IC0KPj4+IC0gICAgICAgZG1hX2Zl bmNlX3B1dChyZXBsYWNlKTsKPj4+ICAgIH0KPj4+ICAgIAo+Pj4gICAgc3RhdGljIHZvaWQKPj4+ Cj4+PiAgICBpLmUuIGRvbid0IGNoZWNrIHdoZW4gbm90IHJlcGxhY2luZyB0aGUgc2hhcmVkW10s IG9uIGNyZWF0aW5nIHRoZSBuZXcKPj4+ICAgIGJ1ZmZlciB3ZSB0aGVuIGRpc2NhcmQgYWxsIHRo ZSBvbGQgZmVuY2VzLgo+Pj4KPj4+IEl0IHNob3VsZCB3b3JrIGZvciBhbWRncHUgYXMgd2VsbCBz aW5jZSB5b3UgZG8gYSBodCB0byBjb2FsZXNjZQo+Pj4gcmVkdW5kYW50IGZlbmNlcyBiZWZvcmUg cXVldWluZy4KPj4gVGhhdCB3b24ndCB3b3JrIGZvciBhbGwgY2FzZXMuIFRoaXMgd2F5IHRoZSBy ZXNlcnZhdGlvbiBvYmplY3Qgd291bGQKPj4ga2VlcCBncm93aW5nIHdpdGhvdXQgYSBjaGFuY2Ug dG8gZXZlciBzaHJpbmsuCj4gV2Ugb25seSBrZWVwIHRoZSBhY3RpdmUgZmVuY2VzIHdoZW4gaXQg Z3Jvd3MsIHdoaWNoIGlzIGVmZmVjdGl2ZSBlbm91Z2gKPiB0byBrZWVwIGl0IGluIGNoZWNrIG9u IHRoZSB3b3JrbG9hZHMgSSBjYW4gZmluZCBpbiB0aGUgaG91ciBzaW5jZQo+IG5vdGljaW5nIHRo ZSBmYWlsdXJlIGluIENJIDspCgpOb3Qgc3VyZSB3aGF0IHRlc3RzIHlvdSBydW4sIGJ1dCB0aGlz IGNoYW5nZSBtZWFucyB0aGF0IHdlIGJhc2ljYWxseSAKanVzdCBhZGQgdGhlIGZlbmNlIHRvIGFu IGV2ZXIgZ3Jvd2luZyBsaXN0IG9mIGZlbmNlcyBvbiBldmVyeSBjb21tYW5kIApzdWJtaXNzaW9u IHdoaWNoIGlzIG9ubHkgcmVhcGVkIHdoZW4gd2UgZG91YmxlIHRoZSBsaXN0IHNpemUuCgpUaGF0 IGlzIGEgc2VyaW91cyBuby1nbyBhcyBmYXIgYXMgSSBjYW4gc2VlLiBXaGF0IHdlIGNvdWxkIGRv IGlzIGltcHJvdmUgCnJlc2VydmF0aW9uX29iamVjdF9yZXNlcnZlX3NoYXJlZCgpIGFzIHdlbGwg dG8gZmlndXJlIG91dCBob3cgbWFueSAKc2lnbmFsZWQgZmVuY2VzIGFyZSBhY3R1YWxseSBpbiB0 aGUgYXJyYXkgd2hlbiB3ZSByZWFsbG9jYXRlIGl0LgoKPiBBbmQgb24gdGhlIHdvcmtsb2FkcyB3 aGVyZSBpdCBpcyBiZWluZwo+IGZsb29kZWQgd2l0aCBsaXZlIGZlbmNlcyBmcm9tIG1hbnkgY29u dGV4dHMsIHRoZSBvcmRlciBvZiBtYWduaXR1ZGUKPiB0aHJvdWdocHV0IGltcHJvdmVtZW50IGlz IG5vdCBlYXN5IHRvIGlnbm9yZS4KCldlbGwgbm90IHN1cmUgYWJvdXQgdGhlIEludGVsIGRyaXZl ciwgYnV0IHNpbmNlIHdlIHN0YXJ0ZWQgdG8gbW9zdGx5IHVzZSAKYSBzaW5nbGUgcmVzZXJ2YXRp b24gb2JqZWN0IHBlciBwcm9jZXNzIHRoZSB0aW1lIHNwZW5kIGluIHRob3NlIApmdW5jdGlvbnMg b24gYW1kZ3B1IGFyZSBjb21wbGV0ZWx5IG5lZ2xpZ2libGUuCgpSZWdhcmRzLApDaHJpc3RpYW4u Cgo+IC1DaHJpcwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=