From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v3 4/7] drm/atomic: Fix atomic helpers to use the new iterator macros. Date: Wed, 18 Jan 2017 15:49:56 +0100 Message-ID: <0f5a2701-38c9-643f-c9bf-b7830b8b0111@linux.intel.com> References: <1484559464-27107-1-git-send-email-maarten.lankhorst@linux.intel.com> <1484559464-27107-5-git-send-email-maarten.lankhorst@linux.intel.com> <5696725.2aGLkINkpF@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5696725.2aGLkINkpF@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T3AgMTctMDEtMTcgb20gMDI6MDEgc2NocmVlZiBMYXVyZW50IFBpbmNoYXJ0Ogo+IEhpIE1hYXJ0 ZW4sCj4KPiAoQ0MnaW5nIERhbmllbCkKPgo+IFRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgo+Cj4g T24gTW9uZGF5IDE2IEphbiAyMDE3IDEwOjM3OjQxIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ PiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGlu dXguaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBl ci5jIHwgMjkzICsrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4+ICAxIGZpbGUgY2hh bmdlZCwgMTUyIGluc2VydGlvbnMoKyksIDE0MSBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4+IGIvZHJpdmVycy9ncHUv ZHJtL2RybV9hdG9taWNfaGVscGVyLmMgaW5kZXggZDE1M2U4YTcyOTIxLi5iMjZjZjc4NmNlMTIK Pj4gMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gW3NuaXBdCj4KPj4g QEAgLTI0NSwyMiArMjQ2LDIyIEBAIHN0ZWFsX2VuY29kZXIoc3RydWN0IGRybV9hdG9taWNfc3Rh dGUgKnN0YXRlLAo+PiAgewo+PiAgCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsK Pj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+PiAtCXN0cnVjdCBkcm1fY29u bmVjdG9yX3N0YXRlICpjb25uZWN0b3Jfc3RhdGU7Cj4+ICsJc3RydWN0IGRybV9jb25uZWN0b3Jf c3RhdGUgKm9sZF9jb25uZWN0b3Jfc3RhdGUsICpuZXdfY29ubmVjdG9yX3N0YXRlOwo+IFRoZSBr ZXJuZWwgZmF2b3VycyBvbmUgdmFyaWFibGUgZGVjbGFyYXRpb24gcGVyIGxpbmUsIGFuZCBJIHRo aW5rIHRoaXMgZmlsZSAKPiBkb2VzIGFzIHdlbGwsIGF0IGxlYXN0IG1vc3RseSAodGhpcyBjb21t ZW50IGhvbGRzIGZvciB0aGUgcmVzdCBvZiB0aGlzIHBhdGNoIAo+IGFuZCB0aGUgb3RoZXIgcGF0 Y2hlcyBpbiB0aGUgc2VyaWVzKS4KVGhpcyBpcyB0aGUgZmlyc3QgSSd2ZSBoZWFyZCBvZiBpdC4u Cgp+L25mcy9saW51eCQgZ2l0IGdyZXAgJ2ludCBpLCcgIHwgd2MgLWwKODQ5MAp+L25mcy9saW51 eCQgZ2l0IGdyZXAgJ2ludCBpOycgIHwgd2MgLWwKMjM2MzYKCkJhc2VkIG9uIHRoaXMsIEkgZG9u J3QgdGhpbmsgaXQncyB1bmNvbW1vbiB0byBoYXZlIG11bHRpcGxlIGRlY2xhcmF0aW9ucyBwZXIg bGluZS4KCj4+ICAJaW50IGk7Cj4+Cj4+IC0JZm9yX2VhY2hfY29ubmVjdG9yX2luX3N0YXRlKHN0 YXRlLCBjb25uZWN0b3IsIGNvbm5lY3Rvcl9zdGF0ZSwgaSkgewo+PiArCWZvcl9lYWNoX29sZG5l d19jb25uZWN0b3JfaW5fc3RhdGUoc3RhdGUsIGNvbm5lY3RvciwKPj4gb2xkX2Nvbm5lY3Rvcl9z dGF0ZSwgbmV3X2Nvbm5lY3Rvcl9zdGF0ZSwgaSkgewo+IFRoaXMgaXMgZ2V0dGluZyBxdWl0ZSBs b25nLCB5b3UgY291bGQgd3JhcCB0aGUgbGluZS4KU291bmRzIGdvb2QuCj4+IAkJc3RydWN0IGRy bV9jcnRjICplbmNvZGVyX2NydGM7Cj4+Cj4+IC0JCWlmIChjb25uZWN0b3Jfc3RhdGUtPmJlc3Rf ZW5jb2RlciAhPSBlbmNvZGVyKQo+PiArCQlpZiAobmV3X2Nvbm5lY3Rvcl9zdGF0ZS0+YmVzdF9l bmNvZGVyICE9IGVuY29kZXIpCj4+ICAJCQljb250aW51ZTsKPj4KPj4gLQkJZW5jb2Rlcl9jcnRj ID0gY29ubmVjdG9yLT5zdGF0ZS0+Y3J0YzsKPj4gKwkJZW5jb2Rlcl9jcnRjID0gb2xkX2Nvbm5l Y3Rvcl9zdGF0ZS0+Y3J0YzsKPj4KPj4gIAkJRFJNX0RFQlVHX0FUT01JQygiW0VOQ09ERVI6JWQ6 JXNdIGluIHVzZSBvbiBbQ1JUQzolZDolc10sIAo+IHN0ZWFsaW5nIGl0XG4iLAo+PiBlbmNvZGVy LT5iYXNlLmlkLCBlbmNvZGVyLT5uYW1lLAo+PiAgCQkJCSBlbmNvZGVyX2NydGMtPmJhc2UuaWQs IGVuY29kZXJfY3J0Yy0+bmFtZSk7Cj4+Cj4+IC0JCXNldF9iZXN0X2VuY29kZXIoc3RhdGUsIGNv bm5lY3Rvcl9zdGF0ZSwgTlVMTCk7Cj4+ICsJCXNldF9iZXN0X2VuY29kZXIoc3RhdGUsIG5ld19j b25uZWN0b3Jfc3RhdGUsIE5VTEwpOwo+Pgo+PiAgCQljcnRjX3N0YXRlID0gZHJtX2F0b21pY19n ZXRfZXhpc3RpbmdfY3J0Y19zdGF0ZShzdGF0ZSwgCj4gZW5jb2Rlcl9jcnRjKTsKPj4gIAkJY3J0 Y19zdGF0ZS0+Y29ubmVjdG9yc19jaGFuZ2VkID0gdHJ1ZTsKPiBbc25pcF0KPgo+PiBAQCAtNTE2 LDE0ICs1MTgsMTUgQEAgZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfbW9kZXNldChzdHJ1Y3QgZHJt X2RldmljZQo+PiAqZGV2LCBpZiAocmV0KQo+PiAgCQlyZXR1cm4gcmV0Owo+Pgo+PiAtCWZvcl9l YWNoX2Nvbm5lY3Rvcl9pbl9zdGF0ZShzdGF0ZSwgY29ubmVjdG9yLCBjb25uZWN0b3Jfc3RhdGUs IGkpIHsKPj4gKwlmb3JfZWFjaF9vbGRuZXdfY29ubmVjdG9yX2luX3N0YXRlKHN0YXRlLCBjb25u ZWN0b3IsCj4+IG9sZF9jb25uZWN0b3Jfc3RhdGUsIG5ld19jb25uZWN0b3Jfc3RhdGUsIGkpIHsK PiBMaW5lIHdyYXAgaGVyZSB0b28gPwo+Cj4+IAkJLyoKPj4gIAkJICogVGhpcyBvbmx5IHNldHMg Y3J0Yy0+Y29ubmVjdG9yc19jaGFuZ2VkIGZvciByb3V0aW5nIAo+IGNoYW5nZXMsCj4+ICAJCSAq IGRyaXZlcnMgbXVzdCBzZXQgY3J0Yy0+Y29ubmVjdG9yc19jaGFuZ2VkIHRoZW1zZWx2ZXMgd2hl bgo+PiAgCQkgKiBjb25uZWN0b3IgcHJvcGVydGllcyBuZWVkIHRvIGJlIHVwZGF0ZWQuCj4+ICAJ CSAqLwo+PiAgCQlyZXQgPSB1cGRhdGVfY29ubmVjdG9yX3JvdXRpbmcoc3RhdGUsIGNvbm5lY3Rv ciwKPj4gLQkJCQkJICAgICAgIGNvbm5lY3Rvcl9zdGF0ZSk7Cj4+ICsJCQkJCSAgICAgICBvbGRf Y29ubmVjdG9yX3N0YXRlLAo+PiArCQkJCQkgICAgICAgbmV3X2Nvbm5lY3Rvcl9zdGF0ZSk7Cj4+ ICAJCWlmIChyZXQpCj4+ICAJCQlyZXR1cm4gcmV0Owo+PiAgCX0KPiBbc25pcF0KPgo+PiBAQCAt NTk5LDE1ICs2MDIsMTUgQEAgZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfcGxhbmVzKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYsCj4+IHN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPj4gIAlzdHJ1Y3QgZHJt X2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4+ICAJc3RydWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4+ IC0Jc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGU7Cj4+ICsJc3RydWN0IGRybV9w bGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUsICpvbGRfcGxhbmVfc3RhdGU7Cj4gSW4gc29tZSBsb2Nh dGlvbiB5b3UgdXNlIG5ld18qX3N0YXRlIGFuZCBpbiBvdGhlcnMgKl9zdGF0ZS4gSSBiZWxpZXZl IHRoaXMgCj4gc2hvdWxkIHRoaXMgYmUgc3RhbmRhcmRpemVkIHRvIGF2b2lkIGNvbmZ1c2lvbiAo dGhlIGNvZGUgaXMgaGFyZCBlbm91Z2ggdG8gCj4gcmVhZCBhcyBpdCBpcyA6LSkpLgo+Cj4gU2lt aWxhcmx5LCB5b3Ugc29tZXRpbWVzIHVzZSAqX2Nvbm5fc3RhdGUgYW5kIHNvbWV0aW1lcyAqX2Nv bm5lY3Rvcl9zdGF0ZS4gCj4gVGhhdCBzaG91bGQgYmUgc3RhbmRhcmRpemVkIGFzIHdlbGwuCklu ZGVlZCwgYXQgbGVhc3QgZm9yIHRob3NlIHRoYXQgdXNlIGJvdGguCj4+ICAJaW50IGksIHJldCA9 IDA7Cj4+Cj4+IC0JZm9yX2VhY2hfcGxhbmVfaW5fc3RhdGUoc3RhdGUsIHBsYW5lLCBwbGFuZV9z dGF0ZSwgaSkgewo+PiArCWZvcl9lYWNoX29sZG5ld19wbGFuZV9pbl9zdGF0ZShzdGF0ZSwgcGxh bmUsIG9sZF9wbGFuZV9zdGF0ZSwKPj4gcGxhbmVfc3RhdGUsIGkpIHsKPj4gCQljb25zdCBzdHJ1 Y3QgZHJtX3BsYW5lX2hlbHBlcl9mdW5jcyAqZnVuY3M7Cj4+Cj4+ICAJCWZ1bmNzID0gcGxhbmUt PmhlbHBlcl9wcml2YXRlOwo+Pgo+PiAtCQlkcm1fYXRvbWljX2hlbHBlcl9wbGFuZV9jaGFuZ2Vk KHN0YXRlLCBwbGFuZV9zdGF0ZSwgcGxhbmUpOwo+PiArCQlkcm1fYXRvbWljX2hlbHBlcl9wbGFu ZV9jaGFuZ2VkKHN0YXRlLCBvbGRfcGxhbmVfc3RhdGUsCj4+IHBsYW5lX3N0YXRlLCBwbGFuZSk7 Cj4+Cj4+ICAJCWlmICghZnVuY3MgfHwgIWZ1bmNzLT5hdG9taWNfY2hlY2spCj4+ICAJCQljb250 aW51ZTsKPiBbc25pcF0KPgo+PiBAQCAtOTc0LDE4ICs5NzcsMTggQEAgdm9pZCBkcm1fYXRvbWlj X2hlbHBlcl9jb21taXRfbW9kZXNldF9lbmFibGVzKHN0cnVjdAo+PiBkcm1fZGV2aWNlICpkZXYs IH0KPj4gIAl9Cj4+Cj4+IC0JZm9yX2VhY2hfY29ubmVjdG9yX2luX3N0YXRlKG9sZF9zdGF0ZSwg Y29ubmVjdG9yLCBvbGRfY29ubl9zdGF0ZSwgaSkgewo+PiArCWZvcl9lYWNoX25ld19jb25uZWN0 b3JfaW5fc3RhdGUob2xkX3N0YXRlLCBjb25uZWN0b3IsIGNvbm5fc3RhdGUsIGkpIHsKPiBOb3Qg c3RyaWN0bHkgcmVsYXRlZCB0byB0aGlzIHBhdGNoLCBidXQgSSd2ZSBiZWVuIHdvbmRlcmluZyBo b3cgdGhpcyB3b3JrcywgCj4gZ2l2ZW4gdGhhdCB3ZSBuZWVkIHRvIGxvb3Agb3ZlciBjb25uZWN0 b3JzIGluIHRoZSBuZXcgc3RhdGUsIG5vdCB0aGUgb2xkIAo+IHN0YXRlLiBBZnRlciBzb21lIGlu dmVzdGlnYXRpb24gSSd2ZSByZWFsaXplZCB0aGF0IGJvdGggdGhlIG9sZCBhbmQgbmV3IHN0YXRl cyAKPiBjb250YWluIHRoZSBzYW1lIGxpc3Qgb2Ygb2JqZWN0cywgYXMgd2UgZG9uJ3Qga2VlcCBh IGNvcHkgb2YgdGhlIG9sZCBnbG9iYWwgCj4gYXRvbWljIHN0YXRlLiBvbGRfc3RhdGUgd2FzIHRo ZSBuZXcgc3RhdGUgYmVmb3JlIHRoZSBzdGF0ZSBzd2FwLCBhbmQgdGhlIHN3YXAgCj4gb3BlcmF0 aW9uIHNldHMgc3RhdGUtPi9vYmplY3RzL1sqXS5zdGF0ZSB0byB0aGUgb2xkIHN0YXRlIGZvciBh bGwgb2JqZWN0cywgYnV0IAo+IGRvZXNuJ3QgbW9kaWZ5IHRoZSBvYmplY3QgcG9pbnRlcnMuIFRo aXMgaXMgcG9zc2libHkgbW9yZSBvZiBhIHF1ZXN0aW9uIGZvciAKPiBEYW5pZWwsIHNob3VsZCB0 aGlzIGJlIGNhcHR1cmVkIGluIHRoZSBkb2N1bWVudGF0aW9uIHNvbWV3aGVyZSAoYW5kIGlzIG15 IAo+IHVuZGVyc3RhbmRpbmcgY29ycmVjdCkgPwpZZXMuIEJ1dCB0aGF0IHdpbGwgZ28gYXdheSBz b29uIGFmdGVyIHRoaXMgcGF0Y2ggKyBhbGwgZHJpdmVycyBjb252ZXJ0ZWQuCgpUaGlzIGlzIHdo eSBnZXRfc3RhdGUgc2hvdWxkIG5vdCBiZSBjYWxsZWQgZHVyaW5nIGF0b21pYyBjb21taXQsIGFu ZCBnZXRfZXhpc3Rpbmdfc3RhdGUgd2lsbCBiZSByZW1vdmVkLgo+PiAgCQljb25zdCBzdHJ1Y3Qg ZHJtX2VuY29kZXJfaGVscGVyX2Z1bmNzICpmdW5jczsKPj4gIAkJc3RydWN0IGRybV9lbmNvZGVy ICplbmNvZGVyOwo+Pgo+PiAtCQlpZiAoIWNvbm5lY3Rvci0+c3RhdGUtPmJlc3RfZW5jb2RlcikK Pj4gKwkJaWYgKCFjb25uX3N0YXRlLT5iZXN0X2VuY29kZXIpCj4+ICAJCQljb250aW51ZTsKPj4K Pj4gLQkJaWYgKCFjb25uZWN0b3ItPnN0YXRlLT5jcnRjLT5zdGF0ZS0+YWN0aXZlIHx8Cj4+IC0J CSAgICAhZHJtX2F0b21pY19jcnRjX25lZWRzX21vZGVzZXQoY29ubmVjdG9yLT5zdGF0ZS0+Y3J0 Yy0KPj4gc3RhdGUpKQo+PiArCQlpZiAoIWNvbm5fc3RhdGUtPmNydGMtPnN0YXRlLT5hY3RpdmUg fHwKPj4gKwkJICAgICFkcm1fYXRvbWljX2NydGNfbmVlZHNfbW9kZXNldChjb25uX3N0YXRlLT5j cnRjLT5zdGF0ZSkpCj4+ICAJCQljb250aW51ZTsKPj4KPj4gLQkJZW5jb2RlciA9IGNvbm5lY3Rv ci0+c3RhdGUtPmJlc3RfZW5jb2RlcjsKPj4gKwkJZW5jb2RlciA9IGNvbm5fc3RhdGUtPmJlc3Rf ZW5jb2RlcjsKPj4gIAkJZnVuY3MgPSBlbmNvZGVyLT5oZWxwZXJfcHJpdmF0ZTsKPj4KPj4gIAkJ RFJNX0RFQlVHX0FUT01JQygiZW5hYmxpbmcgW0VOQ09ERVI6JWQ6JXNdXG4iLAo+IFtzbmlwXQo+ Cj4+IEBAIC0xOTIxLDEyICsxOTE5LDE5IEBAIHZvaWQgZHJtX2F0b21pY19oZWxwZXJfY2xlYW51 cF9wbGFuZXMoc3RydWN0Cj4+IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9hdG9taWNfc3Rh dGUgKm9sZF9zdGF0ZSkKPj4gIHsKPj4gIAlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZTsKPj4gLQlz dHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPj4gKwlzdHJ1Y3QgZHJtX3BsYW5l X3N0YXRlICpwbGFuZV9zdGF0ZSwgKm5ld19wbGFuZV9zdGF0ZTsKPj4gIAlpbnQgaTsKPj4KPj4g LQlmb3JfZWFjaF9wbGFuZV9pbl9zdGF0ZShvbGRfc3RhdGUsIHBsYW5lLCBwbGFuZV9zdGF0ZSwg aSkgewo+PiArCWZvcl9lYWNoX29sZG5ld19wbGFuZV9pbl9zdGF0ZShvbGRfc3RhdGUsIHBsYW5l LCBwbGFuZV9zdGF0ZSwKPj4gbmV3X3BsYW5lX3N0YXRlLCBpKSB7Cj4+IAkJY29uc3Qgc3RydWN0 IGRybV9wbGFuZV9oZWxwZXJfZnVuY3MgKmZ1bmNzOwo+Pgo+PiArCQkvKgo+PiArCQkgKiBUaGlz IG1pZ2h0IGJlIGNhbGxlZCBiZWZvcmUgc3dhcHBpbmcgd2hlbiBjb21taXQgaXMgCj4gYWJvcnRl ZCwKPj4gKwkJICogaW4gd2hpY2ggY2FzZSB3ZSBoYXZlIHRvIGZyZWUgdGhlIG5ldyBzdGF0ZS4K PiBTaG91bGQgdGhpcyBiZSAiY2xlYW51cCB0aGUgbmV3IHN0YXRlIiBpbnN0ZWFkIG9mICJmcmVl IHRoZSBuZXcgc3RhdGUiID8KSW5kZWVkLgo+PiArCQkgKi8KPj4gKwkJaWYgKHBsYW5lX3N0YXRl ID09IHBsYW5lLT5zdGF0ZSkKPj4gKwkJCXBsYW5lX3N0YXRlID0gbmV3X3BsYW5lX3N0YXRlOwo+ PiArCj4+ICAJCWZ1bmNzID0gcGxhbmUtPmhlbHBlcl9wcml2YXRlOwo+Pgo+PiAgCQlpZiAoZnVu Y3MtPmNsZWFudXBfZmIpCj4gW3NuaXBdCj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=