From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v4] drm/amdgpu: Transfer fences to dmabuf importer Date: Tue, 7 Aug 2018 19:57:16 +0200 Message-ID: <100b177c-6bf2-ebaa-472a-8f3ba0228cb9@amd.com> References: <20180807104500.31264-1-chris@chris-wilson.co.uk> <20180807160841.31028-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180807160841.31028-1-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Chris Wilson , intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Alex Deucher , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org QW0gMDcuMDguMjAxOCB1bSAxODowOCBzY2hyaWViIENocmlzIFdpbHNvbjoKPiBhbWRncHUgb25s eSB1c2VzIHNoYXJlZC1mZW5jZXMgaW50ZXJuYWxseSwgYnV0IGRtYWJ1ZiBpbXBvcnRlcnMgcmVs eSBvbgo+IGltcGxpY2l0IHdyaXRlIGhhemFyZCB0cmFja2luZyB2aWEgdGhlIHJlc2VydmF0aW9u X29iamVjdC5mZW5jZV9leGNsLgo+IEZvciBleGFtcGxlLCB0aGUgaW1wb3J0ZXIgdXNlIHRoZSB3 cml0ZSBoYXphcmQgZm9yIHRpbWluZyBhIHBhZ2UgZmxpcCB0bwo+IG9ubHkgb2NjdXIgYWZ0ZXIg dGhlIGV4cG9ydGVyIGhhcyBmaW5pc2hlZCBmbHVzaGluZyBpdHMgd3JpdGUgaW50byB0aGUKPiBz dXJmYWNlLiBBcyBzdWNoLCBvbiBleHBvcnRpbmcgYSBkbWFidWYsIHdlIG11c3QgZWl0aGVyIGZs dXNoIGFsbAo+IG91dHN0YW5kaW5nIGZlbmNlcyAoZm9yIHdlIGRvIG5vdCBrbm93IHdoaWNoIGFy ZSB3cml0ZXMgYW5kIHNob3VsZCBoYXZlCj4gYmVlbiBleGNsdXNpdmUpIG9yIGFsdGVybmF0aXZl bHkgY3JlYXRlIGEgbmV3IGV4Y2x1c2l2ZSBmZW5jZSB0aGF0IGlzCj4gdGhlIGNvbXBvc2l0ZSBv ZiBhbGwgdGhlIGV4aXN0aW5nIHNoYXJlZCBmZW5jZXMsIGFuZCBzbyB3aWxsIG9ubHkgYmUKPiBz aWduYWxlZCB3aGVuIGFsbCBlYXJsaWVyIGZlbmNlcyBhcmUgc2lnbmFsZWQgKGVuc3VyaW5nIHRo YXQgd2UgY2FuIG5vdAo+IGJlIHNpZ25hbGVkIGJlZm9yZSB0aGUgY29tcGxldGlvbiBvZiBhbnkg ZWFybGllciB3cml0ZSkuCj4KPiB2MjogcmVzZXJ2YXRpb25fb2JqZWN0IGlzIGFscmVhZHkgbG9j a2VkIGJ5IGFtZGdwdV9ib19yZXNlcnZlKCkKPgo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJl ZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDczNDEKPiBUZXN0Y2FzZTogaWd0L2FtZF9w cmltZS9hbWQtdG8taTkxNQo+IFJlZmVyZW5jZXM6IDhlOTRhNDZjMTc3MCAoImRybS9hbWRncHU6 IEF0dGFjaCBleGNsdXNpdmUgZmVuY2UgdG8gcHJpbWUgZXhwb3J0ZWQgYm8ncy4gKHY1KSIpCj4g U2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4g Q2M6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRldWNoZXJAYW1kLmNvbT4KPiBDYzogIkNocmlz dGlhbiBLw7ZuaWciIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4gLS0tCj4KPiBUaGlzIHRp bWUsIGhvcGVmdWxseSBwcm9vZnJlYWQgYW5kIHJlZmVyZW5jZXMgY29tcGxldGUuCj4gLUNocmlz Cj4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9wcmltZS5jIHwg NjggKysrKysrKysrKysrKysrKysrKystLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA2MCBpbnNlcnRp b25zKCspLCA4IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9wcmltZS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X3ByaW1lLmMKPiBpbmRleCAxYzVkOTdmNGI0ZGQuLmRmZjJiMDFhM2Q4OSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcHJpbWUuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9wcmltZS5jCj4gQEAgLTM3LDYgKzM3LDcg QEAKPiAgICNpbmNsdWRlICJhbWRncHVfZGlzcGxheS5oIgo+ICAgI2luY2x1ZGUgPGRybS9hbWRn cHVfZHJtLmg+Cj4gICAjaW5jbHVkZSA8bGludXgvZG1hLWJ1Zi5oPgo+ICsjaW5jbHVkZSA8bGlu dXgvZG1hLWZlbmNlLWFycmF5Lmg+Cj4gICAKPiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZG1hX2J1 Zl9vcHMgYW1kZ3B1X2RtYWJ1Zl9vcHM7Cj4gICAKPiBAQCAtMTg4LDYgKzE4OSw1NyBAQCBhbWRn cHVfZ2VtX3ByaW1lX2ltcG9ydF9zZ190YWJsZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAg CXJldHVybiBFUlJfUFRSKHJldCk7Cj4gICB9Cj4gICAKPiArc3RhdGljIGludAo+ICtfX3Jlc2Vy dmF0aW9uX29iamVjdF9tYWtlX2V4Y2x1c2l2ZShzdHJ1Y3QgcmVzZXJ2YXRpb25fb2JqZWN0ICpv YmopCj4gK3sKPiArCXN0cnVjdCByZXNlcnZhdGlvbl9vYmplY3RfbGlzdCAqZm9iajsKPiArCXN0 cnVjdCBkbWFfZmVuY2VfYXJyYXkgKmFycmF5Owo+ICsJc3RydWN0IGRtYV9mZW5jZSAqKmZlbmNl czsKPiArCXVuc2lnbmVkIGludCBjb3VudCwgaTsKPiArCj4gKwlmb2JqID0gcmVzZXJ2YXRpb25f b2JqZWN0X2dldF9saXN0KG9iaik7Cj4gKwlpZiAoIWZvYmopCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ ICsJY291bnQgPSAhIXJjdV9hY2Nlc3NfcG9pbnRlcihvYmotPmZlbmNlX2V4Y2wpOwo+ICsJY291 bnQgKz0gZm9iai0+c2hhcmVkX2NvdW50Owo+ICsKPiArCWZlbmNlcyA9IGttYWxsb2NfYXJyYXko Y291bnQsIHNpemVvZigqZmVuY2VzKSwgR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIWZlbmNlcykKPiAr CQlyZXR1cm4gLUVOT01FTTsKPiArCj4gKwlmb3IgKGkgPSAwOyBpIDwgZm9iai0+c2hhcmVkX2Nv dW50OyBpKyspIHsKPiArCQlzdHJ1Y3QgZG1hX2ZlbmNlICpmID0KPiArCQkJcmN1X2RlcmVmZXJl bmNlX3Byb3RlY3RlZChmb2JqLT5zaGFyZWRbaV0sCj4gKwkJCQkJCSAgcmVzZXJ2YXRpb25fb2Jq ZWN0X2hlbGQob2JqKSk7Cj4gKwo+ICsJCWZlbmNlc1tpXSA9IGRtYV9mZW5jZV9nZXQoZik7Cj4g Kwl9Cj4gKwo+ICsJaWYgKHJjdV9hY2Nlc3NfcG9pbnRlcihvYmotPmZlbmNlX2V4Y2wpKSB7Cj4g KwkJc3RydWN0IGRtYV9mZW5jZSAqZiA9Cj4gKwkJCXJjdV9kZXJlZmVyZW5jZV9wcm90ZWN0ZWQo b2JqLT5mZW5jZV9leGNsLAo+ICsJCQkJCQkgIHJlc2VydmF0aW9uX29iamVjdF9oZWxkKG9iaikp Owo+ICsKPiArCQlmZW5jZXNbaV0gPSBkbWFfZmVuY2VfZ2V0KGYpOwo+ICsJfQo+ICsKPiArCWFy cmF5ID0gZG1hX2ZlbmNlX2FycmF5X2NyZWF0ZShjb3VudCwgZmVuY2VzLAo+ICsJCQkJICAgICAg IGRtYV9mZW5jZV9jb250ZXh0X2FsbG9jKDEpLCAwLAo+ICsJCQkJICAgICAgIGZhbHNlKTsKPiAr CWlmICghYXJyYXkpCj4gKwkJZ290byBlcnJfZmVuY2VzX3B1dDsKPiArCj4gKwlyZXNlcnZhdGlv bl9vYmplY3RfYWRkX2V4Y2xfZmVuY2Uob2JqLCAmYXJyYXktPmJhc2UpOwo+ICsJcmV0dXJuIDA7 Cj4gKwo+ICtlcnJfZmVuY2VzX3B1dDoKPiArCWZvciAoaSA9IDA7IGkgPCBjb3VudDsgaSsrKQo+ ICsJCWRtYV9mZW5jZV9wdXQoZmVuY2VzW2ldKTsKPiArCWtmcmVlKGZlbmNlcyk7Cj4gKwlyZXR1 cm4gLUVOT01FTTsKPiArfQo+ICsKClRoaXMgY2FuIGJlIHNpbXBsaWZpZWQgYSBsb3QuIFNlZSBh bWRncHVfcGFzaWRfZnJlZV9kZWxheWVkKCkgZm9yIGFuIApleGFtcGxlOgo+IMKgwqDCoMKgwqDC oMKgIHIgPSByZXNlcnZhdGlvbl9vYmplY3RfZ2V0X2ZlbmNlc19yY3UocmVzdiwgTlVMTCwgJmNv dW50LCAKPiAmZmVuY2VzKTsKPiDCoMKgwqDCoMKgwqDCoCBpZiAocikKPiDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgZ290byBmYWxsYmFjazsKPgo+IMKgwqDCoMKgwqDCoMKgIGlmIChj b3VudCA9PSAwKSB7Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGFtZGdwdV9wYXNp ZF9mcmVlKHBhc2lkKTsKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuOwo+ IMKgwqDCoMKgwqDCoMKgIH0KPgo+IMKgwqDCoMKgwqDCoMKgIGlmIChjb3VudCA9PSAxKSB7Cj4g wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGZlbmNlID0gZmVuY2VzWzBdOwo+IMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBrZnJlZShmZW5jZXMpOwo+IMKgwqDCoMKgwqDCoMKg IH0gZWxzZSB7Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHVpbnQ2NF90IGNvbnRl eHQgPSBkbWFfZmVuY2VfY29udGV4dF9hbGxvYygxKTsKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgc3RydWN0IGRtYV9mZW5jZV9hcnJheSAqYXJyYXk7Cj4KPiDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgYXJyYXkgPSBkbWFfZmVuY2VfYXJyYXlfY3JlYXRlKGNvdW50LCBm ZW5jZXMsIGNvbnRleHQsCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMSwg ZmFsc2UpOwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoIWFycmF5KSB7Cj4g wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBrZnJlZShmZW5j ZXMpOwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ290 byBmYWxsYmFjazsKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfQo+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBmZW5jZSA9ICZhcnJheS0+YmFzZTsKPiDCoMKgwqDCoMKg wqDCoCB9CgoKUmVnYXJkcywKQ2hyaXN0aWFuLgoKPiAgIC8qKgo+ICAgICogYW1kZ3B1X2dlbV9t YXBfYXR0YWNoIC0gJmRtYV9idWZfb3BzLmF0dGFjaCBpbXBsZW1lbnRhdGlvbgo+ICAgICogQGRt YV9idWY6IHNoYXJlZCBETUEgYnVmZmVyCj4gQEAgLTIxOSwxNiArMjcxLDE2IEBAIHN0YXRpYyBp bnQgYW1kZ3B1X2dlbV9tYXBfYXR0YWNoKHN0cnVjdCBkbWFfYnVmICpkbWFfYnVmLAo+ICAgCj4g ICAJaWYgKGF0dGFjaC0+ZGV2LT5kcml2ZXIgIT0gYWRldi0+ZGV2LT5kcml2ZXIpIHsKPiAgIAkJ LyoKPiAtCQkgKiBXYWl0IGZvciBhbGwgc2hhcmVkIGZlbmNlcyB0byBjb21wbGV0ZSBiZWZvcmUg d2Ugc3dpdGNoIHRvIGZ1dHVyZQo+IC0JCSAqIHVzZSBvZiBleGNsdXNpdmUgZmVuY2Ugb24gdGhp cyBwcmltZSBzaGFyZWQgYm8uCj4gKwkJICogV2Ugb25seSBjcmVhdGUgc2hhcmVkIGZlbmNlcyBm b3IgaW50ZXJuYWwgdXNlLCBidXQgaW1wb3J0ZXJzCj4gKwkJICogb2YgdGhlIGRtYWJ1ZiByZWx5 IG9uIGV4Y2x1c2l2ZSBmZW5jZXMgZm9yIGltcGxpY2l0bHkKPiArCQkgKiB0cmFja2luZyB3cml0 ZSBoYXphcmRzLiBBcyBhbnkgb2YgdGhlIGN1cnJlbnQgZmVuY2VzIG1heQo+ICsJCSAqIGNvcnJl c3BvbmQgdG8gYSB3cml0ZSwgd2UgbmVlZCB0byBjb252ZXJ0IGFsbCBleGlzdGluZwo+ICsJCSAq IGZlbmNlcyBvbiB0aGUgcmVzZXJ2YXRpb24gb2JqZWN0IGludG8gYSBzaW5nbGUgZXhjbHVzaXZl Cj4gKwkJICogZmVuY2UuCj4gICAJCSAqLwo+IC0JCXIgPSByZXNlcnZhdGlvbl9vYmplY3Rfd2Fp dF90aW1lb3V0X3JjdShiby0+dGJvLnJlc3YsCj4gLQkJCQkJCQl0cnVlLCBmYWxzZSwKPiAtCQkJ CQkJCU1BWF9TQ0hFRFVMRV9USU1FT1VUKTsKPiAtCQlpZiAodW5saWtlbHkociA8IDApKSB7Cj4g LQkJCURSTV9ERUJVR19QUklNRSgiRmVuY2Ugd2FpdCBmYWlsZWQ6ICVsaVxuIiwgcik7Cj4gKwkJ ciA9IF9fcmVzZXJ2YXRpb25fb2JqZWN0X21ha2VfZXhjbHVzaXZlKGJvLT50Ym8ucmVzdik7Cj4g KwkJaWYgKHIpCj4gICAJCQlnb3RvIGVycm9yX3VucmVzZXJ2ZTsKPiAtCQl9Cj4gICAJfQo+ICAg Cj4gICAJLyogcGluIGJ1ZmZlciBpbnRvIEdUVCAqLwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9hbWQtZ2Z4Cg==