From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frediano Ziglio Subject: Re: [Spice-devel] [drm/qxl v3 6/7] qxl: Don't notify userspace when monitors config is unchanged Date: Mon, 7 Nov 2016 04:08:48 -0500 (EST) Message-ID: <1098175776.9399455.1478509728251.JavaMail.zimbra@redhat.com> References: <20161107080103.22299-1-cfergeau@redhat.com> <20161107080103.22299-7-cfergeau@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20161107080103.22299-7-cfergeau@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christophe Fergeau Cc: spice-devel@lists.freedesktop.org, dri-devel@lists.freedesktop.org, airlied@redhat.com List-Id: dri-devel@lists.freedesktop.org PiAKPiBXaGVuIHRoZSBRWEwgZHJpdmVyIHJlY2VpdmVzIGEgUVhMX0lOVEVSUlVQVF9DTElFTlRf TU9OSVRPUlNfQ09ORklHCj4gaW50ZXJydXB0LAo+IHdlIGN1cnJlbnRseSBhbHdheXMgbm90aWZ5 IHVzZXJzcGFjZSB0aGF0IHRoZXJlIHdhcyBzb21lIGhvdHBsdWcgZXZlbnQuCj4gCj4gSG93ZXZl ciwgZ25vbWUtc2hlbGwvbXV0dGVyIGlzIHJlYWN0aW5nIHRvIHRoaXMgZXZlbnQgYnkgYXR0ZW1w dGluZyBhCj4gcmVzb2x1dGlvbiBjaGFuZ2UsIHdoaWNoIGl0IGRvZXMgYnkgaXNzdWVpbmcgZHJt TW9kZVJtRkIsIGRybU1vZGVBZGRGQiwKPiBhbmQgdGhlbiBkcm1Nb2RlU2V0Q3J0Yy4gVGhpcyBo YXMgdGhlIHNpZGUtZWZmZWN0IG9mIGNhdXNpbmcKPiBxeGxfY3J0Y19tb2RlX3NldCgpIHRvIHRl bGwgdGhlIFFYTCB2aXJ0dWFsIGhhcmR3YXJlIHRoYXQgYSBwcmltYXJ5Cj4gc3VyZmFjZSB3YXMg ZGVzdHJveWVkIGFuZCBjcmVhdGVkLiBBZnRlciBnb2luZyB0aHJvdWdoIFFFTVUgYW5kIHRoZW4g dGhlCj4gcmVtb3RlIFNQSUNFIGNsaWVudCwgYSBuZXcgaWRlbnRpY2FsIG1vbml0b3JzIGNvbmZp ZyBtZXNzYWdlIHdpbGwgYmUKPiBzZW50LCByZXN1bHRpbmcgaW4gYSBRWExfSU5URVJSVVBUX0NM SUVOVF9NT05JVE9SU19DT05GSUcgaW50ZXJydXB0IHRvCj4gYmUgZW1pdHRlZCwgYW5kIHRoZSBz YW1lIHNjZW5hcmlvIG9jY3VycmluZyBhZ2Fpbi4KPiAKPiBBcyBkZXN0cm95aW5nL2NyZWF0aW5n IHRoZSBwcmltYXJ5IHN1cmZhY2UgY2F1c2VzIGEgdmlzaWJsZSBzY3JlZW4KPiBmbGlja2VyLCB0 aGlzIG1ha2VzIHRoZSBndWVzdCBoYXJkIHRvIHVzZSAoCj4gaHR0cHM6Ly9idWd6aWxsYS5yZWRo YXQuY29tL3Nob3dfYnVnLmNnaT9pZD0xMjY2NDg0ICkuCj4gCj4gVGhpcyBjb21taXQgY2hlY2tz IGlmIHRoZSBzY3JlZW4gY29uZmlndXJhdGlvbiB3ZSByZWNlaXZlZCBpcyB0aGUgc2FtZQo+IG9u ZSBhcyB0aGUgY3VycmVudCBvbmUsIGFuZCBkb2VzIG5vdCBub3RpZnkgdXNlcnNwYWNlIGFib3V0 IGl0IGlmIHRoYXQncwo+IHRoZSBjYXNlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzdG9waGUg RmVyZ2VhdSA8Y2ZlcmdlYXVAcmVkaGF0LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3F4 bC9xeGxfZGlzcGxheS5jIHwgNjIKPiAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1MiBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfZGlzcGxheS5jCj4g Yi9kcml2ZXJzL2dwdS9kcm0vcXhsL3F4bF9kaXNwbGF5LmMKPiBpbmRleCA4Y2Y1MTc3Li41MTgz MzNjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2Rpc3BsYXkuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2Rpc3BsYXkuYwo+IEBAIC01NywxMSArNTcsMTgg QEAgc3RhdGljIHZvaWQgcXhsX2FsbG9jX2NsaWVudF9tb25pdG9yc19jb25maWcoc3RydWN0Cj4g cXhsX2RldmljZSAqcWRldiwgdW5zaWduZWQgYwo+ICAJcWRldi0+Y2xpZW50X21vbml0b3JzX2Nv bmZpZy0+Y291bnQgPSBjb3VudDsKPiAgfQo+ICAKPiArZW51bSB7Cj4gKwlNT05JVE9SU19DT05G SUdfTU9ESUZJRUQsCj4gKwlNT05JVE9SU19DT05GSUdfVU5DSEFOR0VELAo+ICsJTU9OSVRPUlNf Q09ORklHX0JBRF9DUkMsCj4gK307Cj4gKwo+ICBzdGF0aWMgaW50IHF4bF9kaXNwbGF5X2NvcHlf cm9tX2NsaWVudF9tb25pdG9yc19jb25maWcoc3RydWN0IHF4bF9kZXZpY2UKPiAgKnFkZXYpCj4g IHsKPiAgCWludCBpOwo+ICAJaW50IG51bV9tb25pdG9yczsKPiAgCXVpbnQzMl90IGNyYzsKPiAr CWludCBzdGF0dXMgPSBNT05JVE9SU19DT05GSUdfVU5DSEFOR0VEOwo+ICAKPiAgCW51bV9tb25p dG9ycyA9IHFkZXYtPnJvbS0+Y2xpZW50X21vbml0b3JzX2NvbmZpZy5jb3VudDsKPiAgCWNyYyA9 IGNyYzMyKDAsIChjb25zdCB1aW50OF90ICopJnFkZXYtPnJvbS0+Y2xpZW50X21vbml0b3JzX2Nv bmZpZywKPiBAQCAtNzAsNyArNzcsNyBAQCBzdGF0aWMgaW50Cj4gcXhsX2Rpc3BsYXlfY29weV9y b21fY2xpZW50X21vbml0b3JzX2NvbmZpZyhzdHJ1Y3QgcXhsX2RldmljZSAqcWRldikKPiAgCQlx eGxfaW9fbG9nKHFkZXYsICJjcmMgbWlzbWF0Y2g6IGhhdmUgJVggKCV6ZCkgIT0gJVhcbiIsIGNy YywKPiAgCQkJICAgc2l6ZW9mKHFkZXYtPnJvbS0+Y2xpZW50X21vbml0b3JzX2NvbmZpZyksCj4g IAkJCSAgIHFkZXYtPnJvbS0+Y2xpZW50X21vbml0b3JzX2NvbmZpZ19jcmMpOwo+IC0JCXJldHVy biAxOwo+ICsJCXJldHVybiBNT05JVE9SU19DT05GSUdfQkFEX0NSQzsKPiAgCX0KPiAgCWlmIChu dW1fbW9uaXRvcnMgPiBxZGV2LT5tb25pdG9yc19jb25maWctPm1heF9hbGxvd2VkKSB7Cj4gIAkJ RFJNX0RFQlVHX0tNUygiY2xpZW50IG1vbml0b3JzIGxpc3Qgd2lsbCBiZSB0cnVuY2F0ZWQ6ICVk IDwgJWRcbiIsCj4gQEAgLTc5LDYgKzg2LDEwIEBAIHN0YXRpYyBpbnQKPiBxeGxfZGlzcGxheV9j b3B5X3JvbV9jbGllbnRfbW9uaXRvcnNfY29uZmlnKHN0cnVjdCBxeGxfZGV2aWNlICpxZGV2KQo+ ICAJfSBlbHNlIHsKPiAgCQludW1fbW9uaXRvcnMgPSBxZGV2LT5yb20tPmNsaWVudF9tb25pdG9y c19jb25maWcuY291bnQ7Cj4gIAl9Cj4gKwlpZiAocWRldi0+Y2xpZW50X21vbml0b3JzX2NvbmZp Zwo+ICsJICAgICAgJiYgKG51bV9tb25pdG9ycyAhPSBxZGV2LT5jbGllbnRfbW9uaXRvcnNfY29u ZmlnLT5jb3VudCkpIHsKPiArCQlzdGF0dXMgPSBNT05JVE9SU19DT05GSUdfTU9ESUZJRUQ7Cj4g Kwl9Cj4gIAlxeGxfYWxsb2NfY2xpZW50X21vbml0b3JzX2NvbmZpZyhxZGV2LCBudW1fbW9uaXRv cnMpOwo+ICAJLyogd2UgY29weSBtYXggZnJvbSB0aGUgY2xpZW50IGJ1dCBpdCBpc24ndCB1c2Vk ICovCj4gIAlxZGV2LT5jbGllbnRfbW9uaXRvcnNfY29uZmlnLT5tYXhfYWxsb3dlZCA9Cj4gQEAg LTg4LDE3ICs5OSwzOSBAQCBzdGF0aWMgaW50Cj4gcXhsX2Rpc3BsYXlfY29weV9yb21fY2xpZW50 X21vbml0b3JzX2NvbmZpZyhzdHJ1Y3QgcXhsX2RldmljZSAqcWRldikKPiAgCQkJJnFkZXYtPnJv bS0+Y2xpZW50X21vbml0b3JzX2NvbmZpZy5oZWFkc1tpXTsKPiAgCQlzdHJ1Y3QgcXhsX2hlYWQg KmNsaWVudF9oZWFkID0KPiAgCQkJJnFkZXYtPmNsaWVudF9tb25pdG9yc19jb25maWctPmhlYWRz W2ldOwo+IC0JCWNsaWVudF9oZWFkLT54ID0gY19yZWN0LT5sZWZ0Owo+IC0JCWNsaWVudF9oZWFk LT55ID0gY19yZWN0LT50b3A7Cj4gLQkJY2xpZW50X2hlYWQtPndpZHRoID0gY19yZWN0LT5yaWdo dCAtIGNfcmVjdC0+bGVmdDsKPiAtCQljbGllbnRfaGVhZC0+aGVpZ2h0ID0gY19yZWN0LT5ib3R0 b20gLSBjX3JlY3QtPnRvcDsKPiAtCQljbGllbnRfaGVhZC0+c3VyZmFjZV9pZCA9IDA7Cj4gLQkJ Y2xpZW50X2hlYWQtPmlkID0gaTsKPiAtCQljbGllbnRfaGVhZC0+ZmxhZ3MgPSAwOwo+ICsJCWlm IChjbGllbnRfaGVhZC0+eCAhPSBjX3JlY3QtPmxlZnQpIHsKPiArCQkJY2xpZW50X2hlYWQtPngg PSBjX3JlY3QtPmxlZnQ7Cj4gKwkJCXN0YXR1cyA9IE1PTklUT1JTX0NPTkZJR19NT0RJRklFRDsK PiArCQl9Cj4gKwkJaWYgKGNsaWVudF9oZWFkLT55ICE9IGNfcmVjdC0+dG9wKSB7Cj4gKwkJCWNs aWVudF9oZWFkLT55ID0gY19yZWN0LT50b3A7Cj4gKwkJCXN0YXR1cyA9IE1PTklUT1JTX0NPTkZJ R19NT0RJRklFRDsKPiArCQl9Cj4gKwkJaWYgKGNsaWVudF9oZWFkLT53aWR0aCAhPSBjX3JlY3Qt PnJpZ2h0IC0gY19yZWN0LT5sZWZ0KSB7Cj4gKwkJCWNsaWVudF9oZWFkLT53aWR0aCA9IGNfcmVj dC0+cmlnaHQgLSBjX3JlY3QtPmxlZnQ7Cj4gKwkJCXN0YXR1cyA9IE1PTklUT1JTX0NPTkZJR19N T0RJRklFRDsKPiArCQl9Cj4gKwkJaWYgKGNsaWVudF9oZWFkLT5oZWlnaHQgIT0gY19yZWN0LT5i b3R0b20gLSBjX3JlY3QtPnRvcCkgewo+ICsJCQljbGllbnRfaGVhZC0+aGVpZ2h0ID0gY19yZWN0 LT5ib3R0b20gLSBjX3JlY3QtPnRvcDsKPiArCQkJc3RhdHVzID0gTU9OSVRPUlNfQ09ORklHX01P RElGSUVEOwo+ICsJCX0KPiArCQlpZiAoY2xpZW50X2hlYWQtPnN1cmZhY2VfaWQgIT0gMCkgewo+ ICsJCQljbGllbnRfaGVhZC0+c3VyZmFjZV9pZCA9IDA7Cj4gKwkJCXN0YXR1cyA9IE1PTklUT1JT X0NPTkZJR19NT0RJRklFRDsKPiArCQl9Cj4gKwkJaWYgKGNsaWVudF9oZWFkLT5pZCAhPSBpKSB7 Cj4gKwkJCWNsaWVudF9oZWFkLT5pZCA9IGk7Cj4gKwkJCXN0YXR1cyA9IE1PTklUT1JTX0NPTkZJ R19NT0RJRklFRDsKPiArCQl9Cj4gKwkJaWYgKGNsaWVudF9oZWFkLT5mbGFncyAhPSAwKSB7Cj4g KwkJCWNsaWVudF9oZWFkLT5mbGFncyA9IDA7Cj4gKwkJCXN0YXR1cyA9IE1PTklUT1JTX0NPTkZJ R19NT0RJRklFRDsKPiArCQl9Cj4gIAkJRFJNX0RFQlVHX0tNUygicmVhZCAlZHglZCslZCslZFxu IiwgY2xpZW50X2hlYWQtPndpZHRoLAo+ICAJCWNsaWVudF9oZWFkLT5oZWlnaHQsCj4gIAkJCSAg Y2xpZW50X2hlYWQtPngsIGNsaWVudF9oZWFkLT55KTsKPiAgCX0KPiAtCXJldHVybiAwOwo+ICsK PiArCXJldHVybiBzdGF0dXM7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIHF4bF91cGRhdGVfb2Zm c2V0X3Byb3BzKHN0cnVjdCBxeGxfZGV2aWNlICpxZGV2KQo+IEBAIC0xMjQsOSArMTU3LDE4IEBA IHZvaWQgcXhsX2Rpc3BsYXlfcmVhZF9jbGllbnRfbW9uaXRvcnNfY29uZmlnKHN0cnVjdAo+IHF4 bF9kZXZpY2UgKnFkZXYpCj4gIHsKPiAgCj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gcWRl di0+ZGRldjsKPiAtCXdoaWxlIChxeGxfZGlzcGxheV9jb3B5X3JvbV9jbGllbnRfbW9uaXRvcnNf Y29uZmlnKHFkZXYpKSB7Cj4gKwlpbnQgc3RhdHVzOwo+ICsKPiArCXN0YXR1cyA9IHF4bF9kaXNw bGF5X2NvcHlfcm9tX2NsaWVudF9tb25pdG9yc19jb25maWcocWRldik7Cj4gKwl3aGlsZSAoc3Rh dHVzID09IE1PTklUT1JTX0NPTkZJR19CQURfQ1JDKSB7Cj4gIAkJcXhsX2lvX2xvZyhxZGV2LCAi ZmFpbGVkIGNyYyBjaGVjayBmb3IgY2xpZW50X21vbml0b3JzX2NvbmZpZywiCj4gIAkJCQkgIiBy ZXRyeWluZ1xuIik7Cj4gKwkJc3RhdHVzID0gcXhsX2Rpc3BsYXlfY29weV9yb21fY2xpZW50X21v bml0b3JzX2NvbmZpZyhxZGV2KTsKPiArCX0KPiArCWlmIChzdGF0dXMgPT0gTU9OSVRPUlNfQ09O RklHX1VOQ0hBTkdFRCkgewo+ICsJCXF4bF9pb19sb2cocWRldiwgImNvbmZpZyB1bmNoYW5nZWRc biIpOwo+ICsJCURSTV9ERUJVRygiaWdub3JpbmcgdW5jaGFuZ2VkIGNsaWVudCBtb25pdG9ycyBj b25maWciKTsKCldoeSBsb2cgYW5kIGRlYnVnPyBMb29rcyBsaWtlIGEgbWlzc2luZyBkZWJ1ZyBj bGVhbnVwLgoKPiArCQlyZXR1cm47Cj4gIAl9Cj4gIAo+ICAJZHJtX21vZGVzZXRfbG9ja19hbGwo ZGV2KTsKCkZyZWRpYW5vCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=