dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dma-buf: Fix kerneldoc formatting
@ 2020-12-04 20:02 Daniel Vetter
  2020-12-04 20:39 ` Simon Ser
  2020-12-07 21:54 ` Ruhl, Michael J
  0 siblings, 2 replies; 4+ messages in thread
From: Daniel Vetter @ 2020-12-04 20:02 UTC (permalink / raw)
  To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter

I wanted to look up something and noticed the hyperlink doesn't work.
While fixing that also noticed a trivial kerneldoc comment typo in the
same section, fix that too.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 Documentation/driver-api/dma-buf.rst | 2 +-
 include/linux/dma-buf-map.h          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-api/dma-buf.rst
index d6b2a195dbed..a2133d69872c 100644
--- a/Documentation/driver-api/dma-buf.rst
+++ b/Documentation/driver-api/dma-buf.rst
@@ -190,7 +190,7 @@ DMA Fence uABI/Sync File
 Indefinite DMA Fences
 ~~~~~~~~~~~~~~~~~~~~~
 
-At various times &dma_fence with an indefinite time until dma_fence_wait()
+At various times struct dma_fence with an indefinite time until dma_fence_wait()
 finishes have been proposed. Examples include:
 
 * Future fences, used in HWC1 to signal when a buffer isn't used by the display
diff --git a/include/linux/dma-buf-map.h b/include/linux/dma-buf-map.h
index 583a3a1f9447..278d489e4bdd 100644
--- a/include/linux/dma-buf-map.h
+++ b/include/linux/dma-buf-map.h
@@ -122,7 +122,7 @@ struct dma_buf_map {
 
 /**
  * DMA_BUF_MAP_INIT_VADDR - Initializes struct dma_buf_map to an address in system memory
- * @vaddr:	A system-memory address
+ * @vaddr_:	A system-memory address
  */
 #define DMA_BUF_MAP_INIT_VADDR(vaddr_) \
 	{ \
-- 
2.29.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dma-buf: Fix kerneldoc formatting
  2020-12-04 20:02 [PATCH] dma-buf: Fix kerneldoc formatting Daniel Vetter
@ 2020-12-04 20:39 ` Simon Ser
  2020-12-07 21:54 ` Ruhl, Michael J
  1 sibling, 0 replies; 4+ messages in thread
From: Simon Ser @ 2020-12-04 20:39 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: Daniel Vetter, DRI Development

On Friday, December 4th, 2020 at 9:02 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:

> I wanted to look up something and noticed the hyperlink doesn't work.
> While fixing that also noticed a trivial kerneldoc comment typo in the
> same section, fix that too.

Reviewed-by: Simon Ser <contact@emersion.fr>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] dma-buf: Fix kerneldoc formatting
  2020-12-04 20:02 [PATCH] dma-buf: Fix kerneldoc formatting Daniel Vetter
  2020-12-04 20:39 ` Simon Ser
@ 2020-12-07 21:54 ` Ruhl, Michael J
  2020-12-09  0:29   ` Daniel Vetter
  1 sibling, 1 reply; 4+ messages in thread
From: Ruhl, Michael J @ 2020-12-07 21:54 UTC (permalink / raw)
  To: Daniel Vetter, DRI Development; +Cc: Vetter, Daniel

>-----Original Message-----
>From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of
>Daniel Vetter
>Sent: Friday, December 4, 2020 3:03 PM
>To: DRI Development <dri-devel@lists.freedesktop.org>
>Cc: Daniel Vetter <daniel.vetter@ffwll.ch>; Vetter, Daniel
><daniel.vetter@intel.com>
>Subject: [PATCH] dma-buf: Fix kerneldoc formatting
>
>I wanted to look up something and noticed the hyperlink doesn't work.
>While fixing that also noticed a trivial kerneldoc comment typo in the
>same section, fix that too.
>
>Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>---
> Documentation/driver-api/dma-buf.rst | 2 +-
> include/linux/dma-buf-map.h          | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-
>api/dma-buf.rst
>index d6b2a195dbed..a2133d69872c 100644
>--- a/Documentation/driver-api/dma-buf.rst
>+++ b/Documentation/driver-api/dma-buf.rst
>@@ -190,7 +190,7 @@ DMA Fence uABI/Sync File
> Indefinite DMA Fences
> ~~~~~~~~~~~~~~~~~~~~~
>
>-At various times &dma_fence with an indefinite time until dma_fence_wait()
>+At various times struct dma_fence with an indefinite time until
>dma_fence_wait()
> finishes have been proposed. Examples include:
>
> * Future fences, used in HWC1 to signal when a buffer isn't used by the
>display
>diff --git a/include/linux/dma-buf-map.h b/include/linux/dma-buf-map.h

Ahh, something to do while compiling...

Both changes look good to me.

Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>

M

>index 583a3a1f9447..278d489e4bdd 100644
>--- a/include/linux/dma-buf-map.h
>+++ b/include/linux/dma-buf-map.h
>@@ -122,7 +122,7 @@ struct dma_buf_map {
>
> /**
>  * DMA_BUF_MAP_INIT_VADDR - Initializes struct dma_buf_map to an
>address in system memory
>- * @vaddr:	A system-memory address
>+ * @vaddr_:	A system-memory address
>  */
> #define DMA_BUF_MAP_INIT_VADDR(vaddr_) \
> 	{ \
>--
>2.29.2
>
>_______________________________________________
>dri-devel mailing list
>dri-devel@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dma-buf: Fix kerneldoc formatting
  2020-12-07 21:54 ` Ruhl, Michael J
@ 2020-12-09  0:29   ` Daniel Vetter
  0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2020-12-09  0:29 UTC (permalink / raw)
  To: Ruhl, Michael J; +Cc: Daniel Vetter, DRI Development, Vetter, Daniel

On Mon, Dec 07, 2020 at 09:54:13PM +0000, Ruhl, Michael J wrote:
> >-----Original Message-----
> >From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of
> >Daniel Vetter
> >Sent: Friday, December 4, 2020 3:03 PM
> >To: DRI Development <dri-devel@lists.freedesktop.org>
> >Cc: Daniel Vetter <daniel.vetter@ffwll.ch>; Vetter, Daniel
> ><daniel.vetter@intel.com>
> >Subject: [PATCH] dma-buf: Fix kerneldoc formatting
> >
> >I wanted to look up something and noticed the hyperlink doesn't work.
> >While fixing that also noticed a trivial kerneldoc comment typo in the
> >same section, fix that too.
> >
> >Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> >---
> > Documentation/driver-api/dma-buf.rst | 2 +-
> > include/linux/dma-buf-map.h          | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/Documentation/driver-api/dma-buf.rst b/Documentation/driver-
> >api/dma-buf.rst
> >index d6b2a195dbed..a2133d69872c 100644
> >--- a/Documentation/driver-api/dma-buf.rst
> >+++ b/Documentation/driver-api/dma-buf.rst
> >@@ -190,7 +190,7 @@ DMA Fence uABI/Sync File
> > Indefinite DMA Fences
> > ~~~~~~~~~~~~~~~~~~~~~
> >
> >-At various times &dma_fence with an indefinite time until dma_fence_wait()
> >+At various times struct dma_fence with an indefinite time until
> >dma_fence_wait()
> > finishes have been proposed. Examples include:
> >
> > * Future fences, used in HWC1 to signal when a buffer isn't used by the
> >display
> >diff --git a/include/linux/dma-buf-map.h b/include/linux/dma-buf-map.h
> 
> Ahh, something to do while compiling...
> 
> Both changes look good to me.
> 
> Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>

Thanks for taking a look, patch applied.
-Daniel

> 
> M
> 
> >index 583a3a1f9447..278d489e4bdd 100644
> >--- a/include/linux/dma-buf-map.h
> >+++ b/include/linux/dma-buf-map.h
> >@@ -122,7 +122,7 @@ struct dma_buf_map {
> >
> > /**
> >  * DMA_BUF_MAP_INIT_VADDR - Initializes struct dma_buf_map to an
> >address in system memory
> >- * @vaddr:	A system-memory address
> >+ * @vaddr_:	A system-memory address
> >  */
> > #define DMA_BUF_MAP_INIT_VADDR(vaddr_) \
> > 	{ \
> >--
> >2.29.2
> >
> >_______________________________________________
> >dri-devel mailing list
> >dri-devel@lists.freedesktop.org
> >https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-12-09  0:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-04 20:02 [PATCH] dma-buf: Fix kerneldoc formatting Daniel Vetter
2020-12-04 20:39 ` Simon Ser
2020-12-07 21:54 ` Ruhl, Michael J
2020-12-09  0:29   ` Daniel Vetter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).