From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCHv3 23/30] drm/omap: fix plane update warning when crtc is disabled Date: Thu, 30 Mar 2017 13:28:53 +0300 Message-ID: <11d8d2de-d342-a30c-d2b5-8a48ee7f9030@ti.com> References: <1490706496-4959-1-git-send-email-tomi.valkeinen@ti.com> <1490706496-4959-24-git-send-email-tomi.valkeinen@ti.com> <2578440.3FTeKt4Us3@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0611056734==" Return-path: Received: from lelnx194.ext.ti.com (lelnx194.ext.ti.com [198.47.27.80]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95B186E867 for ; Thu, 30 Mar 2017 10:28:58 +0000 (UTC) In-Reply-To: <2578440.3FTeKt4Us3@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Jyri Sarha , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0611056734== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3shVmMeNGVhakLwA6tTLSj932LKwDrfVs" --3shVmMeNGVhakLwA6tTLSj932LKwDrfVs Content-Type: multipart/mixed; boundary="U01lulJKPFJteebt4jbuXfeONo0muwJbL"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Jyri Sarha Message-ID: <11d8d2de-d342-a30c-d2b5-8a48ee7f9030@ti.com> Subject: Re: [PATCHv3 23/30] drm/omap: fix plane update warning when crtc is disabled References: <1490706496-4959-1-git-send-email-tomi.valkeinen@ti.com> <1490706496-4959-24-git-send-email-tomi.valkeinen@ti.com> <2578440.3FTeKt4Us3@avalon> In-Reply-To: <2578440.3FTeKt4Us3@avalon> --U01lulJKPFJteebt4jbuXfeONo0muwJbL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 29/03/17 13:30, Laurent Pinchart wrote: > Hi Tomi, >=20 > Thank you for the patch. >=20 > On Tuesday 28 Mar 2017 16:08:09 Tomi Valkeinen wrote: >> If omap_plane_atomic_update() is called when the crtc is disabled, and= >> the timings are zero, we'll see the following warning: >> >> omapdss DISPC error: cannot calculate scaling settings: pclk is zero >> omapdrm omapdrm.0: Failed to setup plane vid2 >> >> It shouldn't cause any issues, as the crtc is disabled so the plane is= >> not used by the HW. >> >> To remove the warning, check whether the crtc is enabled at the >> beginning of omap_plane_atomic_update(), and bail out if not. >> >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/gpu/drm/omapdrm/omap_plane.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c >> b/drivers/gpu/drm/omapdrm/omap_plane.c index 78a92422ede1..27c1902415d= e >> 100644 >> --- a/drivers/gpu/drm/omapdrm/omap_plane.c >> +++ b/drivers/gpu/drm/omapdrm/omap_plane.c >> @@ -86,6 +86,11 @@ static void omap_plane_atomic_update(struct drm_pla= ne >> *plane, >> >> DBG("%s, crtc=3D%p fb=3D%p", omap_plane->name, state->crtc, state->f= b); >> >> + if (!state->crtc->state->enable) { >> + priv->dispc_ops->ovl_enable(omap_plane->id, false); >> + return; >> + } >=20 > I'm a bit puzzled, why is omap_plane_atomic_update() called for a plane= on a=20 > disabled CRTC ? I don't remember, and I can't reproduce this on 4.12. Possibly something has changed since 4.4... I'll drop this. Tomi --U01lulJKPFJteebt4jbuXfeONo0muwJbL-- --3shVmMeNGVhakLwA6tTLSj932LKwDrfVs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJY3N3lAAoJEPo9qoy8lh71KdYQAJNKflPyqarcAjfky9gp0GiC Loa7cr/fSSuDGDAgLbppP+dUU5nyxAdOWbEpzYPxhpXVVyxnmTrrpildaavD/MKK bskclSOfgWHQXMJ6cDnT6dXqPz5ZywlKn4v1OK0fedAXhDsl7jhzoR+HhM6SoySi WBcc1sIAW3bV7WlVfdqT0+rJYz8ShzKIu3u/2Qb/JzY9RK6oAYgbD9p5mPN0J9Ec SQeFfcuhe19FPuUs5mWSt0nayM4VIOeBSlef4qW1sSN/LReH6odZHUFzZWWrCQ9k VrhbV74ZQveikd7mStyBnPaX8icUrasR4CT9NioO7BrLK320J04KRSgvkj7hibbU qfyz4JKqig/aRELNA8sM5uAqZ8UXLzZV6VY9rPwy2Xs2bDwpQPLTbXvrq6eaQFyD +sgmyg5JOKGWuKhUqb1u6gOCSrjVgm86lHisG3B+OJHVMTTx4n8PxT6GEsffiKuR ESetSwwirRKffwBVJUapc/i7tCH5+WAgD41IVrkSom95yyUnO+NA4UlcKzaOuWvv Ns7+h4diWvKWuKI6OdbAFUyYLl4A1xnFEuo8Merg2YCBz607NTuq8oEAVfey/Mk2 Be4ZTWrkE7z879IIgt6qrJwbOg/Q9u4tf4rkEp35SQ0998rPEbYzrNwAj4C0fO4Z phrizExfjCrnQ8Lq4Of5 =lio5 -----END PGP SIGNATURE----- --3shVmMeNGVhakLwA6tTLSj932LKwDrfVs-- --===============0611056734== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0611056734==--