From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v3 4/5] media: adv7604: Add support for
 i2c_new_secondary_device
Date: Tue, 13 Feb 2018 14:19:06 +0200
Message-ID: <12162268.j7DyVD3ArW@avalon>
References: <1518473273-6333-1-git-send-email-kbingham@kernel.org>
 <1518473273-6333-5-git-send-email-kbingham@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from galahad.ideasonboard.com (galahad.ideasonboard.com
 [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d])
 by gabe.freedesktop.org (Postfix) with ESMTPS id A90FB89624
 for <dri-devel@lists.freedesktop.org>; Tue, 13 Feb 2018 12:18:35 +0000 (UTC)
In-Reply-To: <1518473273-6333-5-git-send-email-kbingham@kernel.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Kieran Bingham <kbingham@kernel.org>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, Kieran Bingham <kieran.bingham@ideasonboard.com>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, Hans Verkuil <hans.verkuil@cisco.com>, Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, linux-media@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

SGkgS2llcmFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5LCAxMyBGZWJy
dWFyeSAyMDE4IDAwOjA3OjUyIEVFVCBLaWVyYW4gQmluZ2hhbSB3cm90ZToKPiBGcm9tOiBKZWFu
LU1pY2hlbCBIYXV0Ym9pcyA8amVhbi1taWNoZWwuaGF1dGJvaXNAdm9kYWx5cy5jb20+Cj4gCj4g
VGhlIEFEVjc2MDQgaGFzIHRoaXJ0ZWVuIDI1Ni1ieXRlIG1hcHMgdGhhdCBjYW4gYmUgYWNjZXNz
ZWQgdmlhIHRoZSBtYWluCj4gScKyQyBwb3J0cy4gRWFjaCBtYXAgaGFzIGl0IG93biBJwrJDIGFk
ZHJlc3MgYW5kIGFjdHMgYXMgYSBzdGFuZGFyZCBzbGF2ZQo+IGRldmljZSBvbiB0aGUgScKyQyBi
dXMuCj4gCj4gQWxsb3cgYSBkZXZpY2UgdHJlZSBub2RlIHRvIG92ZXJyaWRlIHRoZSBkZWZhdWx0
IGFkZHJlc3NlcyBzbyB0aGF0Cj4gYWRkcmVzcyBjb25mbGljdHMgd2l0aCBvdGhlciBkZXZpY2Vz
IG9uIHRoZSBzYW1lIGJ1cyBtYXkgYmUgcmVzb2x2ZWQgYXQKPiB0aGUgYm9hcmQgZGVzY3JpcHRp
b24gbGV2ZWwuCj4gCj4gU2lnbmVkLW9mZi1ieTogSmVhbi1NaWNoZWwgSGF1dGJvaXMgPGplYW4t
bWljaGVsLmhhdXRib2lzQHZvZGFseXMuY29tPgo+IFtLaWVyYW46IFJlLWFkYXB0ZWQgZm9yIG1h
aW5saW5lXQo+IFNpZ25lZC1vZmYtYnk6IEtpZXJhbiBCaW5naGFtIDxraWVyYW4uYmluZ2hhbSty
ZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+Cj4gCj4gLS0tCj4gQmFzZWQgdXBvbiB0aGUgb3JpZ2lu
YWwgcG9zdGluZyA6Cj4gICBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxNC8xMC8yMi80NjkKPiAK
PiB2MjoKPiAgLSBTcGxpdCBvdXQgRFQgYmluZGluZ3MgZnJvbSBkcml2ZXIgdXBkYXRlcwo+ICAt
IFJldHVybiAtRUlOVkFMIG9uIGVycm9yIHBhdGhzIGZyb20gYWR2NzZ4eF9kdW1teV9jbGllbnQo
KQo+IAo+ICBkcml2ZXJzL21lZGlhL2kyYy9hZHY3NjA0LmMgfCA2MiArKysrKysrKysrKysrKysr
KysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlv
bnMoKyksIDIyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL2ky
Yy9hZHY3NjA0LmMgYi9kcml2ZXJzL21lZGlhL2kyYy9hZHY3NjA0LmMKPiBpbmRleCAxNTQ0OTIw
ZWM1MmQuLjg3MmUxMjQ3OTNmOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21lZGlhL2kyYy9hZHY3
NjA0LmMKPiArKysgYi9kcml2ZXJzL21lZGlhL2kyYy9hZHY3NjA0LmMKPiBAQCAtMjczNCw2ICsy
NzM0LDI3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgdjRsMl9jdHJsX2NvbmZpZwo+IGFkdjc2eHhf
Y3RybF9mcmVlX3J1bl9jb2xvciA9IHsKPiAKPiAgLyogLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tICovCj4gCj4gK3N0
cnVjdCBhZHY3Nnh4X3JlZ2lzdGVyIHsKCmFkdjc2eHhfcmVnaXN0ZXIgc2VlbXMgdG8gaW1wbHkg
dGhhdCB0aGlzIGRlc2NyaWJlcyBhIHBhcnRpY3VsYXIgcmVnaXN0ZXIsIAp3aGlsZSB0aGUgc3Ry
dWN0dXJlIGRlc2NyaWJlcyBhIHJlZ2lzdGVycyBtYXAuIEhvdyBhYm91dCBhZHY3Nnh4X3JlZ2lz
dGVyX21hcCwgCmFkdjc2eHhfcmVnaXN0ZXJfYmFuayBvciBhZHY3Nnh4X3JlZ2lzdGVyX3BhZ2Ug
PwoKPiArCWNvbnN0IGNoYXIgKm5hbWU7Cj4gKwl1OCBkZWZhdWx0X2FkZHI7Cj4gK307Cj4gKwo+
ICtzdGF0aWMgY29uc3Qgc3RydWN0IGFkdjc2eHhfcmVnaXN0ZXIgYWR2NzZ4eF9zZWNvbmRhcnlf
bmFtZXNbXSA9IHsKClRoZSB0YWJsZSBkb2Vzbid0IGNvbnRhaW4gc2Vjb25kYXJ5IG5hbWVzIG9u
bHkgYXMgdGhlcmUncyBhbiBlbnRyeSBmb3IgdGhlIAptYWluIG1hcC4gSG93IGFib3V0IGNhbGxp
bmcgaXQgYWR2NzZ4eF9kZWZhdWx0X2FkZHJlc3NlcyBvciBzb21ldGhpbmcgYWxvbmcgCnRoZSBz
YW1lIGxpbmUgPwoKPiArCVtBRFY3NlhYX1BBR0VfSU9dID0geyAibWFpbiIsIDB4NGMgfSwKPiAr
CVtBRFY3NjA0X1BBR0VfQVZMSU5LXSA9IHsgImF2bGluayIsIDB4NDIgfSwKPiArCVtBRFY3NlhY
X1BBR0VfQ0VDXSA9IHsgImNlYyIsIDB4NDAgfSwKPiArCVtBRFY3NlhYX1BBR0VfSU5GT0ZSQU1F
XSA9IHsgImluZm9mcmFtZSIsIDB4M2UgfSwKPiArCVtBRFY3NjA0X1BBR0VfRVNEUF0gPSB7ICJl
c2RwIiwgMHgzOCB9LAo+ICsJW0FEVjc2MDRfUEFHRV9EUFBdID0geyAiZHBwIiwgMHgzYyB9LAo+
ICsJW0FEVjc2WFhfUEFHRV9BRkVdID0geyAiYWZlIiwgMHgyNiB9LAo+ICsJW0FEVjc2WFhfUEFH
RV9SRVBdID0geyAicmVwIiwgMHgzMiB9LAo+ICsJW0FEVjc2WFhfUEFHRV9FRElEXSA9IHsgImVk
aWQiLCAweDM2IH0sCj4gKwlbQURWNzZYWF9QQUdFX0hETUldID0geyAiaGRtaSIsIDB4MzQgfSwK
PiArCVtBRFY3NlhYX1BBR0VfVEVTVF0gPSB7ICJ0ZXN0IiwgMHgzMCB9LAo+ICsJW0FEVjc2WFhf
UEFHRV9DUF0gPSB7ICJjcCIsIDB4MjIgfSwKPiArCVtBRFY3NjA0X1BBR0VfVkRQXSA9IHsgInZk
cCIsIDB4MjQgfSwKPiArfTsKPiArCj4gIHN0YXRpYyBpbnQgYWR2NzZ4eF9jb3JlX2luaXQoc3Ry
dWN0IHY0bDJfc3ViZGV2ICpzZCkKPiAgewo+ICAJc3RydWN0IGFkdjc2eHhfc3RhdGUgKnN0YXRl
ID0gdG9fc3RhdGUoc2QpOwo+IEBAIC0yODM0LDEzICsyODU1LDI2IEBAIHN0YXRpYyB2b2lkIGFk
djc2eHhfdW5yZWdpc3Rlcl9jbGllbnRzKHN0cnVjdAo+IGFkdjc2eHhfc3RhdGUgKnN0YXRlKSB9
Cj4gCj4gIHN0YXRpYyBzdHJ1Y3QgaTJjX2NsaWVudCAqYWR2NzZ4eF9kdW1teV9jbGllbnQoc3Ry
dWN0IHY0bDJfc3ViZGV2ICpzZCwKPiAtCQkJCQkJCXU4IGFkZHIsIHU4IGlvX3JlZykKPiArCQkJ
CQkgICAgICAgdW5zaWduZWQgaW50IGkpCgpNYXliZSB1bnNpZ25lZCBpbnQgcGFnZSA/CgpXaXRo
IHRoZXNlIGZpeGVkLAoKUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGlu
Y2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KCj4gIHsKPiAgCXN0cnVjdCBpMmNfY2xpZW50ICpjbGll
bnQgPSB2NGwyX2dldF9zdWJkZXZkYXRhKHNkKTsKPiArCXN0cnVjdCBhZHY3Nnh4X3N0YXRlICpz
dGF0ZSA9IHRvX3N0YXRlKHNkKTsKPiArCXN0cnVjdCBhZHY3Nnh4X3BsYXRmb3JtX2RhdGEgKnBk
YXRhID0gJnN0YXRlLT5wZGF0YTsKPiArCXVuc2lnbmVkIGludCBpb19yZWcgPSAweGYyICsgaTsK
PiArCXN0cnVjdCBpMmNfY2xpZW50ICpuZXdfY2xpZW50Owo+ICsKPiArCWlmIChwZGF0YSAmJiBw
ZGF0YS0+aTJjX2FkZHJlc3Nlc1tpXSkKPiArCQluZXdfY2xpZW50ID0gaTJjX25ld19kdW1teShj
bGllbnQtPmFkYXB0ZXIsCj4gKwkJCQkJICAgcGRhdGEtPmkyY19hZGRyZXNzZXNbaV0pOwo+ICsJ
ZWxzZQo+ICsJCW5ld19jbGllbnQgPSBpMmNfbmV3X3NlY29uZGFyeV9kZXZpY2UoY2xpZW50LAo+
ICsJCQkJYWR2NzZ4eF9zZWNvbmRhcnlfbmFtZXNbaV0ubmFtZSwKPiArCQkJCWFkdjc2eHhfc2Vj
b25kYXJ5X25hbWVzW2ldLmRlZmF1bHRfYWRkcik7Cj4gCj4gLQlpZiAoYWRkcikKPiAtCQlpb193
cml0ZShzZCwgaW9fcmVnLCBhZGRyIDw8IDEpOwo+IC0JcmV0dXJuIGkyY19uZXdfZHVtbXkoY2xp
ZW50LT5hZGFwdGVyLCBpb19yZWFkKHNkLCBpb19yZWcpID4+IDEpOwo+ICsJaWYgKG5ld19jbGll
bnQpCj4gKwkJaW9fd3JpdGUoc2QsIGlvX3JlZywgbmV3X2NsaWVudC0+YWRkciA8PCAxKTsKPiAr
Cj4gKwlyZXR1cm4gbmV3X2NsaWVudDsKPiAgfQo+IAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGFk
djc2eHhfcmVnX3NlcSBhZHY3NjA0X3JlY29tbWVuZGVkX3NldHRpbmdzX2FmZVtdID0gewo+IEBA
IC0zMTE1LDIwICszMTQ5LDYgQEAgc3RhdGljIGludCBhZHY3Nnh4X3BhcnNlX2R0KHN0cnVjdCBh
ZHY3Nnh4X3N0YXRlCj4gKnN0YXRlKSAvKiBEaXNhYmxlIHRoZSBpbnRlcnJ1cHQgZm9yIG5vdyBh
cyBubyBEVC1iYXNlZCBib2FyZCB1c2VzIGl0LiAqLwo+IHN0YXRlLT5wZGF0YS5pbnQxX2NvbmZp
ZyA9IEFEVjc2WFhfSU5UMV9DT05GSUdfRElTQUJMRUQ7Cj4gCj4gLQkvKiBVc2UgdGhlIGRlZmF1
bHQgSTJDIGFkZHJlc3Nlcy4gKi8KPiAtCXN0YXRlLT5wZGF0YS5pMmNfYWRkcmVzc2VzW0FEVjc2
MDRfUEFHRV9BVkxJTktdID0gMHg0MjsKPiAtCXN0YXRlLT5wZGF0YS5pMmNfYWRkcmVzc2VzW0FE
Vjc2WFhfUEFHRV9DRUNdID0gMHg0MDsKPiAtCXN0YXRlLT5wZGF0YS5pMmNfYWRkcmVzc2VzW0FE
Vjc2WFhfUEFHRV9JTkZPRlJBTUVdID0gMHgzZTsKPiAtCXN0YXRlLT5wZGF0YS5pMmNfYWRkcmVz
c2VzW0FEVjc2MDRfUEFHRV9FU0RQXSA9IDB4Mzg7Cj4gLQlzdGF0ZS0+cGRhdGEuaTJjX2FkZHJl
c3Nlc1tBRFY3NjA0X1BBR0VfRFBQXSA9IDB4M2M7Cj4gLQlzdGF0ZS0+cGRhdGEuaTJjX2FkZHJl
c3Nlc1tBRFY3NlhYX1BBR0VfQUZFXSA9IDB4MjY7Cj4gLQlzdGF0ZS0+cGRhdGEuaTJjX2FkZHJl
c3Nlc1tBRFY3NlhYX1BBR0VfUkVQXSA9IDB4MzI7Cj4gLQlzdGF0ZS0+cGRhdGEuaTJjX2FkZHJl
c3Nlc1tBRFY3NlhYX1BBR0VfRURJRF0gPSAweDM2Owo+IC0Jc3RhdGUtPnBkYXRhLmkyY19hZGRy
ZXNzZXNbQURWNzZYWF9QQUdFX0hETUldID0gMHgzNDsKPiAtCXN0YXRlLT5wZGF0YS5pMmNfYWRk
cmVzc2VzW0FEVjc2WFhfUEFHRV9URVNUXSA9IDB4MzA7Cj4gLQlzdGF0ZS0+cGRhdGEuaTJjX2Fk
ZHJlc3Nlc1tBRFY3NlhYX1BBR0VfQ1BdID0gMHgyMjsKPiAtCXN0YXRlLT5wZGF0YS5pMmNfYWRk
cmVzc2VzW0FEVjc2MDRfUEFHRV9WRFBdID0gMHgyNDsKPiAtCj4gIAkvKiBIYXJkY29kZSB0aGUg
cmVtYWluaW5nIHBsYXRmb3JtIGRhdGEgZmllbGRzLiAqLwo+ICAJc3RhdGUtPnBkYXRhLmRpc2Fi
bGVfcHdyZG5iID0gMDsKPiAgCXN0YXRlLT5wZGF0YS5kaXNhYmxlX2NhYmxlX2RldF9yc3QgPSAw
Owo+IEBAIC0zNDc4LDExICszNDk4LDkgQEAgc3RhdGljIGludCBhZHY3Nnh4X3Byb2JlKHN0cnVj
dCBpMmNfY2xpZW50ICpjbGllbnQsCj4gIAkJaWYgKCEoQklUKGkpICYgc3RhdGUtPmluZm8tPnBh
Z2VfbWFzaykpCj4gIAkJCWNvbnRpbnVlOwo+IAo+IC0JCXN0YXRlLT5pMmNfY2xpZW50c1tpXSA9
Cj4gLQkJCWFkdjc2eHhfZHVtbXlfY2xpZW50KHNkLCBzdGF0ZS0+cGRhdGEuaTJjX2FkZHJlc3Nl
c1tpXSwKPiAtCQkJCQkgICAgIDB4ZjIgKyBpKTsKPiArCQlzdGF0ZS0+aTJjX2NsaWVudHNbaV0g
PSBhZHY3Nnh4X2R1bW15X2NsaWVudChzZCwgaSk7Cj4gIAkJaWYgKCFzdGF0ZS0+aTJjX2NsaWVu
dHNbaV0pIHsKPiAtCQkJZXJyID0gLUVOT01FTTsKPiArCQkJZXJyID0gLUVJTlZBTDsKPiAgCQkJ
djRsMl9lcnIoc2QsICJmYWlsZWQgdG8gY3JlYXRlIGkyYyBjbGllbnQgJXVcbiIsIGkpOwo+ICAJ
CQlnb3RvIGVycl9pMmM7Cj4gIAkJfQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0Cgpf
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg
bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK