From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Woodhouse Subject: Re: [git pull] drm fixes Date: Mon, 07 Jun 2010 22:39:28 +0100 Message-ID: <1275946768.17903.5126.camel@macbook.infradead.org> References: <20100607182640.GL31073@ZenIV.linux.org.uk> <1275939165.17903.5100.camel@macbook.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Torvalds Cc: Al Viro , Dave Airlie , dri-devel@lists.freedesktop.org, Linux Kernel Mailing List List-Id: dri-devel@lists.freedesktop.org On Mon, 2010-06-07 at 14:17 -0700, Linus Torvalds wrote: > and that changelog doesn't really explain it either ("fix leak"? Ok, I can > see the iput() fixing the leak - but you also did that jffs2_clear_inode() > change, and that has no explanation what-so-ever. jffs2_clear_inode() is the file system's ->clear_inode method, so it gets called from the VFS when the inode is destroyed, after iput(). I suppose that ought to have been a clue, right from the very beginning, that we should never have been calling it directly on our error paths. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation