From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 07/16] drm/omapdrm: removed optional dummy crtc mode_fixup function. Date: Wed, 17 Feb 2016 17:24:08 +0200 Message-ID: <12773333.2XRLo5cZeb@avalon> References: <101f043d5fa747291c09ae765bac4d55c6e39988.1455630967.git.palminha@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <101f043d5fa747291c09ae765bac4d55c6e39988.1455630967.git.palminha@synopsys.com> Sender: linux-renesas-soc-owner@vger.kernel.org To: Carlos Palminha Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch, patrik.r.jakobsson@gmail.com, virtualization@lists.linux-foundation.org, jani.nikula@intel.com, sudipm.mukherjee@gmail.com, nicolas.pitre@linaro.org, linux-renesas-soc@vger.kernel.org, benjamin.gaignard@linaro.org, vincent.abriou@st.com, boris.brezillon@free-electrons.com, kraxel@redhat.com, jianwei.wang.chn@gmail.com, alison.wang@freescale.com List-Id: dri-devel@lists.freedesktop.org Hi Carlos, Thank you for the patch. On Tuesday 16 February 2016 14:18:12 Carlos Palminha wrote: > This patch set nukes all the dummy crtc mode_fixup implementations. > (made on top of Daniel topic/drm-misc branch) > > Signed-off-by: Carlos Palminha Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/omapdrm/omap_crtc.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c > b/drivers/gpu/drm/omapdrm/omap_crtc.c index d38fcbc..483acdb 100644 > --- a/drivers/gpu/drm/omapdrm/omap_crtc.c > +++ b/drivers/gpu/drm/omapdrm/omap_crtc.c > @@ -330,13 +330,6 @@ static void omap_crtc_destroy(struct drm_crtc *crtc) > kfree(omap_crtc); > } > > -static bool omap_crtc_mode_fixup(struct drm_crtc *crtc, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > -{ > - return true; > -} > - > static void omap_crtc_enable(struct drm_crtc *crtc) > { > struct omap_crtc *omap_crtc = to_omap_crtc(crtc); > @@ -451,7 +444,6 @@ static const struct drm_crtc_funcs omap_crtc_funcs = { > }; > > static const struct drm_crtc_helper_funcs omap_crtc_helper_funcs = { > - .mode_fixup = omap_crtc_mode_fixup, > .mode_set_nofb = omap_crtc_mode_set_nofb, > .disable = omap_crtc_disable, > .enable = omap_crtc_enable, -- Regards, Laurent Pinchart