From: Adam Jackson <ajax@redhat.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/kms: add a module param to disable strict EDID checking
Date: Wed, 05 Jan 2011 10:33:37 -0500 [thread overview]
Message-ID: <1294241617.11569.37.camel@atropine> (raw)
In-Reply-To: <1294182034-16539-1-git-send-email-alexdeucher@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1126 bytes --]
On Tue, 2011-01-04 at 18:00 -0500, Alex Deucher wrote:
> Lots of EDIDs have bad checksums or bad version numbers, but
> have otherwise good data in them. The current code rejects
> them which results in bad modes or blank screens in some cases.
> This patch adds a new module parameter, edid_strict, to drm.ko.
> It defaults to 1 (strict conformance, the current behavior),
> but if the user sets it to 0, it will bypass the checks and
> accept the EDID.
I really, really hate this. Especially for things like the CEA
extension, where there's a bunch of internal length data that we trust
while walking the block, so if it's wrong then we're just going to walk
off the end of the EDID block and into arbitrary kernel memory.
However, I have neither the time nor the inclination to write a
sufficiently paranoid permissive parser right now. So I'd kind of
prefer that this set the taint flag, and I absolutely disclaim any
responsibility for any security bugs that result from someone shooting
themselves in the foot with this. But, that said:
Regretted-by: Adam Jackson <ajax@redhat.com>
- ajax
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2011-01-05 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 23:00 [PATCH] drm/kms: add a module param to disable strict EDID checking Alex Deucher
2011-01-05 15:33 ` Adam Jackson [this message]
2011-07-16 17:48 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294241617.11569.37.camel@atropine \
--to=ajax@redhat.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).