From: "Michel Dänzer" <michel@daenzer.net>
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] radeon: attempt to fix active vram since 93225b0d7bc030f4a93165347a65893685822d70
Date: Sun, 13 Mar 2011 13:36:24 +0100 [thread overview]
Message-ID: <1300019784.6124.38.camel@thor.local> (raw)
In-Reply-To: <1300018770.6124.33.camel@thor.local>
On Son, 2011-03-13 at 13:19 +0100, Michel Dänzer wrote:
> On Son, 2011-03-13 at 21:06 +1000, Dave Airlie wrote:
> > From: Dave Airlie <airlied@redhat.com>
> >
> > Iterations of this patch seemed to break active vram, this seems like
> > a good plan for it.
> >
> > second attempt to fix: https://bugs.freedesktop.org/show_bug.cgi?id=35254
> >
> > Reported-by: Michael Larabel @ phoronix
> > Signed-off-by: Dave Airlie <airlied@redhat.com>
> > Cc: stable@kernel.org
> > ---
> > drivers/gpu/drm/radeon/radeon_object.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> > index 7d6b8e8..620c321 100644
> > --- a/drivers/gpu/drm/radeon/radeon_object.c
> > +++ b/drivers/gpu/drm/radeon/radeon_object.c
> > @@ -73,9 +73,11 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
> > rbo->placement.lpfn = 0;
> > rbo->placement.placement = rbo->placements;
> > rbo->placement.busy_placement = rbo->placements;
> > - if (domain & RADEON_GEM_DOMAIN_VRAM)
> > + if (domain & RADEON_GEM_DOMAIN_VRAM) {
> > rbo->placements[c++] = TTM_PL_FLAG_WC | TTM_PL_FLAG_UNCACHED |
> > TTM_PL_FLAG_VRAM;
> > + rbo->placement.lpfn = rbo->rdev->mc.active_vram_size >> PAGE_SHIFT;
> > + }
> > if (domain & RADEON_GEM_DOMAIN_GTT)
> > rbo->placements[c++] = TTM_PL_MASK_CACHING | TTM_PL_FLAG_TT;
> > if (domain & RADEON_GEM_DOMAIN_CPU)
>
> This can spuriously limit the BO to active_vram_size in GTT again.
On second thought, I don't understand why this would be necessary /
helpful at all. If active_vram_size is the maximum amount of VRAM that
should ever be used anywhere (as opposed to the maximum amount visible
to the CPU, which I was thinking of before), why is the VRAM
ttm_mem_type_manager size field larger than that in the first place?
--
Earthling Michel Dänzer | http://www.vmware.com
Libre software enthusiast | Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2011-03-13 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-13 11:06 [PATCH 0/2] radeon regression fixes Dave Airlie
2011-03-13 11:06 ` [PATCH 1/2] drm/radeon: fix page flipping hangs on r300/r400 Dave Airlie
2011-03-13 12:20 ` Michel Dänzer
2011-03-13 11:06 ` [PATCH 2/2] radeon: attempt to fix active vram since 93225b0d7bc030f4a93165347a65893685822d70 Dave Airlie
2011-03-13 12:19 ` Michel Dänzer
2011-03-13 12:36 ` Michel Dänzer [this message]
2011-03-13 19:34 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300019784.6124.38.camel@thor.local \
--to=michel@daenzer.net \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox