From: "Michel Dänzer" <michel@daenzer.net>
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: fix problem with changing active VRAM size. (v2)
Date: Tue, 15 Mar 2011 09:24:21 +0100 [thread overview]
Message-ID: <1300177461.6124.88.camel@thor.local> (raw)
In-Reply-To: <1300071034-26670-1-git-send-email-airlied@gmail.com>
On Mon, 2011-03-14 at 12:50 +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> So we used to use lpfn directly to restrict VRAM when we couldn't
> access the unmappable area, however this was removed in
> 93225b0d7bc030f4a93165347a65893685822d70 as it also restricted
> the gtt placements. However it was only later noticed that this
> broke on some hw.
>
> This removes the active_vram_size, and just explicitly sets it
> when it changes, TTM/drm_mm will always use the real_vram_size,
> and the active vram size will change the TTM size used for lpfn
> setting.
>
> We should re-work the fpfn/lpfn to per-placement at some point
> I suspect, but that is too late for this kernel.
>
> Hopefully this addresses:
> https://bugs.freedesktop.org/show_bug.cgi?id=35254
>
> v2: fix reported useful VRAM size to userspace to be correct.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
Looks good, Dave. Thanks for getting rid of one of the *_vram_size
fields, those were getting out of hand.
--
Earthling Michel Dänzer | http://www.vmware.com
Libre software enthusiast | Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2011-03-15 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 2:50 [PATCH] drm/radeon: fix problem with changing active VRAM size. (v2) Dave Airlie
2011-03-15 8:24 ` Michel Dänzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300177461.6124.88.camel@thor.local \
--to=michel@daenzer.net \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox