public inbox for dri-devel@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: dri-devel@lists.freedesktop.org, 619019@bugs.debian.org
Subject: Bug#619019: [PATCH 1/2] i915: Remove 'pipe A force' quirk for 855GM and 845G
Date: Sun, 20 Mar 2011 23:07:04 +0000	[thread overview]
Message-ID: <1300662425.26693.301.camel@localhost> (raw)

Applying this quirk to the 855GM in all systems causes regressions
(Debian bugs #493096, #619019).  Instead, apply the quirk to specific
models as listed in the old X driver.

I don't see any explanation for this quirk being applied to the 845G,
except perhaps that VT switching used to hang if pipe A was turned
off.  However, that seems to be a problem only when using UMS.  So
remove the quirk for the 845G as well.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
Needs people to test it, as I can't.

Ben.

 drivers/gpu/drm/i915/intel_display.c |   23 +++++++++++++++++++----
 1 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 3106c0d..a490f75 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7345,19 +7345,34 @@ struct intel_quirk intel_quirks[] = {
 
 	/* Thinkpad R31 needs pipe A force quirk */
 	{ 0x3577, 0x1014, 0x0505, quirk_pipea_force },
+	/* Dell Latitude D400 needs pipe A force quirk (LP: #228519) */
+	{ 0x3582, 0x1028, 0x0139, quirk_pipea_force },
+	/* Dell Latitude D500 needs pipe A force quirk */
+	{ 0x3582, 0x1028, 0x0152, quirk_pipea_force },
+	/* Dell Latitude D505 needs pipe A force quirk (LP: #235643) */
+	{ 0x3582, 0x1028, 0x0163, quirk_pipea_force },
+	/* Dell Latitude X300 needs pipe A force quirk */
+	{ 0x3582, 0x1028, 0x014f, quirk_pipea_force },
+	/* Dell Inspiron 510m needs pipe A force quirk */
+	{ 0x3582, 0x1028, 0x0164, quirk_pipea_force },
+	/* Toshiba Satellite A30 needs pipe A force quirk */
+	{ 0x3582, 0x1179, 0xff00, quirk_pipea_force },
 	/* Toshiba Protege R-205, S-209 needs pipe A force quirk */
 	{ 0x2592, 0x1179, 0x0001, quirk_pipea_force },
+	/* Intel 855GM hardware (See LP: #216490) */
+	{ 0x3582, 0x1028, 0x00c8, quirk_pipea_force },
+	/* Intel 855GM hardware (See Novell Bugzilla #406123) */
+	{ 0x3582, 0x10cf, 0x1215, quirk_pipea_force },
+	/* HP Pavilion ze4944ea needs pipe A force quirk (See LP: #242389) */
+	{ 0x3582, 0x103c, 0x3084, quirk_pipea_force },
 
 	/* ThinkPad X30 needs pipe A force quirk (LP: #304614) */
 	{ 0x3577,  0x1014, 0x0513, quirk_pipea_force },
 	/* ThinkPad X40 needs pipe A force quirk */
+	{ 0x3582, 0x1014, 0x0557, quirk_pipea_force },
 
 	/* ThinkPad T60 needs pipe A force quirk (bug #16494) */
 	{ 0x2782, 0x17aa, 0x201a, quirk_pipea_force },
-
-	/* 855 & before need to leave pipe A & dpll A up */
-	{ 0x3582, PCI_ANY_ID, PCI_ANY_ID, quirk_pipea_force },
-	{ 0x2562, PCI_ANY_ID, PCI_ANY_ID, quirk_pipea_force },
 };
 
 static void intel_init_quirks(struct drm_device *dev)
-- 
1.7.4.1

             reply	other threads:[~2011-03-20 23:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-20 23:07 Ben Hutchings [this message]
2011-03-20 23:09 ` [PATCH 2/2] i915: Apply the 'pipe A force' quirk to some more models Ben Hutchings
2011-03-21  7:18   ` [PATCH 2/2] i915: Apply the pipe A force " Chris Wilson
2011-03-21  7:38 ` [PATCH 1/2] i915: Remove pipe A force quirk for 855GM and 845G Chris Wilson
2011-03-22  3:05   ` Ben Hutchings
2011-03-22  7:17     ` Chris Wilson
2011-03-22 11:04     ` Chris Wilson
2011-03-22 15:47     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300662425.26693.301.camel@localhost \
    --to=ben@decadent.org.uk \
    --cc=619019@bugs.debian.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox