From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel =?ISO-8859-1?Q?D=E4nzer?= Subject: Re: [git pull] drm fixes Date: Wed, 23 Mar 2011 12:45:47 +0100 Message-ID: <1300880747.16522.13.camel@thor.local> References: <1300864998.3522.71.camel@thor.local> <1300868532.3522.81.camel@thor.local> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ilija Hadzic Cc: Dave Airlie , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, DRI mailing list List-Id: dri-devel@lists.freedesktop.org On Mit, 2011-03-23 at 06:40 -0500, Ilija Hadzic wrote:=20 > On Wed, 23 Mar 2011, Dave Airlie wrote: >=20 > > 2011/3/23 Michel D=C3=A4nzer : > >> On Mit, 2011-03-23 at 18:16 +1000, Dave Airlie wrote: > >>> 2011/3/23 Michel D=C3=A4nzer : > >>>> On Mit, 2011-03-23 at 04:18 +0000, Dave Airlie wrote: > >>>>> > >>>>> One radeon, 2 core fixes, and an interface update to allow for = > 2 crtcs > >>>>> in vblank. > >>>> > >>>> [...] > >>>> > >>>>> Ilija Hadzic (1): > >>>>> drm/kernel: vblank wait on crtc > 1 > >>>> > >>>> This patch was still being debated yesterday, are you deliberate= ly > >>>> pushing it regardless? Once it hits mainline, it'll be pretty mu= ch set > >>>> in stone. > >>> > >>> From what I can see it was the userspace patches being debated, t= his > >>> one seemed fine and the interface looked okay to me. > >> > >> The author ignored my suggestions to make the patch smaller and si= mpler, > >> more maintainable and more future-proof all at once. > > > > It was already small and I'm not sure merging the flags made it mor= e > > maintainable. Its always > > being a slightly painful ioctl, and hopefully any future changes ad= d a > > new ioctl esp if we want 64-bit values. > > > > The only comment I really thought was necessary was changing the CA= P > > name, but since that isn't > > part of the ABI (just the number) we can quickly fix it with a foll= ow-up. > > > > Dave. >=20 > All of the issues debated yesterday, except one, boil down to renamin= g a=20 > handful on #defines without changing the values nor interface nor beh= avior=20 > of the kernel. No, one central point is not to leave two holes between _DRM_VBLANK_FLAGS_MASK, _DRM_VBLANK_HIGH_CRTC_MASK and _DRM_VBLANK_TYPES_MASK . --=20 Earthling Michel D=C3=A4nzer | http://www.vmwa= re.com Libre software enthusiast | Debian, X and DRI develope= r