From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel =?ISO-8859-1?Q?D=E4nzer?= Subject: Re: [git pull] drm fixes Date: Fri, 25 Mar 2011 08:43:30 +0100 Message-ID: <1301039010.12159.56.camel@thor.local> References: <1300864998.3522.71.camel@thor.local> <1300868532.3522.81.camel@thor.local> <1300880747.16522.13.camel@thor.local> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dave Airlie Cc: Linus Torvalds , linux-kernel@vger.kernel.org, DRI mailing list List-Id: dri-devel@lists.freedesktop.org On Fre, 2011-03-25 at 17:21 +1000, Dave Airlie wrote:=20 > On Fri, Mar 25, 2011 at 10:17 AM, Linus Torvalds > wrote: > > On Thu, Mar 24, 2011 at 5:07 PM, Dave Airlie wr= ote: > >> > >> Like seriously you really think VFS locking rework wasn't under > >> development or discussion when you merged it? I'm sure Al would ha= ve > >> something to say about it considering the number of times he curse= d in > >> irc about that code after you merged it. > > > > Umm. That code was basically over a year old by the time it was mer= ged. > > > > How old was the code we're talking about now? Seriously? >=20 > It was 30 lines of clean code, that really was fine to be merged in > its first form it was merely a future maintaince issue to clean up th= e > interface before it was released as stable. =46rom my POV the real failure here was that the change made it to *any= * tree while there were outstanding review issues from when it was initially discussed a few weeks earlier. Then when the change was submitted =E2=80=94 more or less unchanged =E2=80=94 I was on my birthd= ay weekend enjoying some time away from computers, and when I had caught up with things, it was already in drm-next. > In this case, if you had a >2 monitor setup connected to an evergreen > card, and you tried to do 3D on the 3rd monitor it would just hang th= e > app in a loop forever, the fix needs 3 pieces, one in the kernel, and > two userspace fixes. Actually, the hangs could be fixed in the X driver alone, but the autho= r seems uninterested in contemplating that. Maybe because he seems to think it's easier to get the kernel fix to users, but I'm with you on that it's quite clearly the opposite. That said, I agree with your analysis in general, but not in this particular case. --=20 Earthling Michel D=C3=A4nzer | http://www.vmwa= re.com Libre software enthusiast | Debian, X and DRI develope= r