From: Rob Clark <rob@ti.com>
To: dri-devel@lists.freedesktop.org
Subject: [RFC] drm platform multi-device support
Date: Tue, 29 Mar 2011 11:44:53 -0500 [thread overview]
Message-ID: <1301417093-14843-1-git-send-email-rob@ti.com> (raw)
From: Rob Clark <robdclark@gmail.com>
Include the minor device id in the bus-id to give userspace a way to open
the correct "cardN" when there are multiple device instances.
---
It may seem a bit strange to have multiple platform device instances, but
we have a use-case for this. And this relatively simple patch does the
trick.
drivers/gpu/drm/drm_ioctl.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c
index 47db4df..075024b 100644
--- a/drivers/gpu/drm/drm_ioctl.c
+++ b/drivers/gpu/drm/drm_ioctl.c
@@ -165,14 +165,15 @@ static int drm_set_busid(struct drm_device *dev, struct drm_file *file_priv)
drm_unset_busid(dev, master);
if (drm_core_check_feature(dev, DRIVER_USE_PLATFORM_DEVICE)) {
- master->unique_len = 10 + strlen(dev->platformdev->name);
+ master->unique_len = 13 + strlen(dev->platformdev->name);
+ master->unique_size = master->unique_len;
master->unique = kmalloc(master->unique_len + 1, GFP_KERNEL);
if (master->unique == NULL)
return -ENOMEM;
len = snprintf(master->unique, master->unique_len,
- "platform:%s", dev->platformdev->name);
+ "platform:%s:%02d", dev->platformdev->name, dev->primary->index);
if (len > master->unique_len) {
DRM_ERROR("Unique buffer overflowed\n");
--
1.7.1
next reply other threads:[~2011-03-29 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 16:44 Rob Clark [this message]
2011-03-30 12:57 ` [RFC] drm platform multi-device support Ilija Hadzic
2011-03-30 14:26 ` Rob Clark
2011-04-05 0:30 ` Dave Airlie
2011-04-05 3:08 ` Rob Clark
2011-04-06 1:21 ` Dave Airlie
2011-07-14 3:12 ` [PATCH] drm: " Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301417093-14843-1-git-send-email-rob@ti.com \
--to=rob@ti.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox