dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Keith Packard <keithp@keithp.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Regression with i915 and suspend on Thinkpad x220
Date: Sun, 22 May 2011 10:28:09 -0500	[thread overview]
Message-ID: <1306078089.4204.1.camel@calx> (raw)
In-Reply-To: <yunlixz6yop.fsf@aiko.keithp.com>

On Sat, 2011-05-21 at 23:23 -0700, Keith Packard wrote:
> On Sat, 21 May 2011 23:55:57 -0500, Matt Mackall <mpm@selenic.com> wrote:
> 
> > I've got a new Thinkpad x220 which won't wake up from suspend with
> > 2.6.39, but works fine with 2.6.37.
> > 
> > I bisected it down to this cset:
> > 
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4efe070896e1f7373c98a13713e659d1f5dee52a
> > 
> > drm/i915: make the blitter report buffer modifications to the FBC unit
> 
> For now, you should be able to disable FBC:
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index c34a8dd..2a82895 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -183,7 +183,7 @@ static const struct intel_device_info intel_sandybridge_d_info = {
>  static const struct intel_device_info intel_sandybridge_m_info = {
>  	.gen = 6, .is_mobile = 1,
>  	.need_gfx_hws = 1, .has_hotplug = 1,
> -	.has_fbc = 1,
> +	.has_fbc = 0,
>  	.has_bsd_ring = 1,
>  	.has_blt_ring = 1,
>  };

Appears to work, thanks.

-- 
Mathematics is the supreme nostalgia of our time.

  reply	other threads:[~2011-05-22 15:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-22  4:55 Regression with i915 and suspend on Thinkpad x220 Matt Mackall
2011-05-22  6:23 ` Keith Packard
2011-05-22 15:28   ` Matt Mackall [this message]
2011-05-22 23:02     ` Keith Packard
2011-05-23  0:42       ` Matt Mackall
2011-05-22 16:13   ` Marek Otahal
2011-05-22 16:25     ` Matt Mackall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306078089.4204.1.camel@calx \
    --to=mpm@selenic.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=keithp@keithp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).