From: "Michel Dänzer" <michel@daenzer.net>
To: Nicholas Miell <nmiell@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon/kms: fix cursor image off-by-one error
Date: Fri, 30 Sep 2011 15:53:53 +0200 [thread overview]
Message-ID: <1317390833.26148.44.camel@thor.local> (raw)
In-Reply-To: <1317348434-30929-1-git-send-email-nmiell@gmail.com>
On Don, 2011-09-29 at 19:07 -0700, Nicholas Miell wrote:
> The mouse cursor hotspot calculation when the cursor is partially off the
> top or left side of the screen was off by one.
>
> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=41158
>
> Signed-off-by: Nicholas Miell <nmiell@gmail.com>
> ---
> drivers/gpu/drm/radeon/radeon_cursor.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_cursor.c b/drivers/gpu/drm/radeon/radeon_cursor.c
> index 3189a7e..c495575 100644
> --- a/drivers/gpu/drm/radeon/radeon_cursor.c
> +++ b/drivers/gpu/drm/radeon/radeon_cursor.c
> @@ -209,9 +209,9 @@ int radeon_crtc_cursor_move(struct drm_crtc *crtc,
> int w = radeon_crtc->cursor_width;
>
> if (x < 0)
> - xorigin = -x + 1;
> + xorigin = -x;
> if (y < 0)
> - yorigin = -y + 1;
> + yorigin = -y;
> if (xorigin >= CURSOR_WIDTH)
> xorigin = CURSOR_WIDTH - 1;
> if (yorigin >= CURSOR_HEIGHT)
While you're at it, might be worth combining with the lines below to
something like
if (x < 0)
xorigin = min(-x, CURSOR_WIDTH - 1);
if (y < 0)
yorigin = min(-y, CURSOR_HEIGHT - 1);
Either way though,
Reviewed-by: Michel Dänzer <michel@daenzer.net>
.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2011-09-30 13:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 2:07 [PATCH] drm/radeon/kms: fix cursor image off-by-one error Nicholas Miell
2011-09-30 13:53 ` Michel Dänzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317390833.26148.44.camel@thor.local \
--to=michel@daenzer.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=nmiell@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox