From: "Michel Dänzer" <michel@daenzer.net>
To: Ilija Hadzic <ihadzic@research.bell-labs.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/radeon/kms: use crtc-specific dpms functions in prepare and commit
Date: Wed, 26 Oct 2011 09:25:52 +0200 [thread overview]
Message-ID: <1319613952.19240.32.camel@thor.local> (raw)
In-Reply-To: <1319596853-9175-2-git-send-email-ihadzic@research.bell-labs.com>
On Die, 2011-10-25 at 22:40 -0400, Ilija Hadzic wrote:
> it's better that radeon_crtc_commit and radeon_crtc_prepare call
> crtc-specific dpms functions instead of hard-coding them to
> radeon_crtc_dpms.
Is it really better? If it's always radeon_crtc_dpms anyway, this
obfuscates that fact (and introduces a guaranteed branch prediction
miss, but that probably doesn't matter here).
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2011-10-26 7:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 2:40 drm/radeon/kms: a few nits Ilija Hadzic
2011-10-26 2:40 ` [PATCH 1/3] drm/radeon/kms: use crtc-specific dpms functions in prepare and commit Ilija Hadzic
2011-10-26 7:25 ` Michel Dänzer [this message]
2011-10-26 17:02 ` Ilija Hadzic
2011-10-26 2:40 ` [PATCH 2/3] drm/radeon/kms: fix the crtc number check Ilija Hadzic
2011-10-26 13:28 ` Alex Deucher
2011-10-26 2:40 ` [PATCH 3/3] drm/radeon/kms: use num_crtc instead of hard-coded value 6 Ilija Hadzic
2011-10-26 13:24 ` Alex Deucher
2011-10-26 19:45 ` Ilija Hadzic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319613952.19240.32.camel@thor.local \
--to=michel@daenzer.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=ihadzic@research.bell-labs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox