From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: high_memory address in /proc/dri/*/vma Date: Mon, 19 Dec 2011 01:23:04 +0000 Message-ID: <1324257784.2844.88.camel@deadeye> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1863044805==" Return-path: Received: from shadbolt.e.decadent.org.uk (shadbolt.e.decadent.org.uk [88.96.1.126]) by gabe.freedesktop.org (Postfix) with ESMTP id 065219E7D8 for ; Sun, 18 Dec 2011 17:23:24 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Kees Cook Cc: Dave Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1863044805== Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-DuxNKLljGD5MYD3xGptv" --=-DuxNKLljGD5MYD3xGptv Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Kees, in commit 01e2f533a234dc62d16c0d3d4fb9d71cf1ce50c3 ("drm: do not leak kernel addresses via /proc/dri/*/vma") you changed the logging of high_memory: - seq_printf(m, "vma use count: %d, high_memory =3D %p, 0x%08llx\n", + seq_printf(m, "vma use count: %d, high_memory =3D %pK, 0x%pK\n", atomic_read(&dev->vma_count), - high_memory, (u64)virt_to_phys(high_memory)); + high_memory, (void *)virt_to_phys(high_memory)); This doesn't make sense because the physical address may be truncated (in theory at least). I think it would make more sense to make this entire file readable by root only, but I don't know whether anything depends on being able to read it. Its existence is conditional on DRM_DEBUG_CODE !=3D 0 but that is always true at the moment. Ben. --=20 Ben Hutchings Humans are not rational beings; they are rationalising beings. --=-DuxNKLljGD5MYD3xGptv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIVAwUATu6R+ee/yOyVhhEJAQquKA//eCaJywjoLpS0qkTDe4irfVCKp84BWbAx eR3NKZZ8xfMqeQ+qD9YEt3zyt0WMxym9OlWPzrwDNB7NlyGcetk6ZU5Lsu13a4n0 wybeKN+X+PwDLmHNTjqzBFPIEvXOTlsXM7Od6CMVxhf8E9MlzoBvqXSXUHBAABe8 6l05t8ZpfESKrIsNQ0tu7NsflJ9NNOwE8n6Gh1BKYsFOAhl04ncuZZH1ksTnO2bk v5tTLuPMmjGf/LKADV7zey6ioxQTD+gpx+CwGk56P0QMlOm//m8yiQCpwfh9FIAH G29Jf+F+s73mAZB1fMQjS18VddBDC/H1NcGK4E8D8rfhTTutXHwNnltdSeRtb3UT oQL1+uqUYjAObgdFexMmMosqjveNMU9lHzajAAfLj0nzz2n+wFsrutGkxgcHUOCs v+v0rNt6DTrzoDOShkUUhK5Q67RdHJdRaBP/s6xI7XAtlItGhVDyHipNUD/ZiWTe EU2QC075UGrYRlZ4QIj4yWoJJ3OmNPFwCFTXBbNNz2GY3ueB2lzTWnXhEbYgcNTa NuzX46F0POHehEIMAcPB7q5oT6XsU8GkqHBcYk3j2BB9hn5Y6cV0JHBL9rHfuZZ7 fYXF61oN1vTBHkgw3DxendVKXkhoGdf5YXAvc5P0qRMoNOQD6UaLMDrflthLRnVW UNlIF3RhD+M= =TeKe -----END PGP SIGNATURE----- --=-DuxNKLljGD5MYD3xGptv-- --===============1863044805== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1863044805==--