From: Christian Schmidt <schmidt@digadd.de>
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH] [i915] Fix another use of the wrong interlace mask to return to progressive mode
Date: Fri, 24 Feb 2012 10:51:42 +0100 [thread overview]
Message-ID: <1330077102-14146-1-git-send-email-schmidt@digadd.de> (raw)
intel_display.c: pipeconf |= PIPECONF_INTERLACE_W_FIELD_INDICATION;
intel_display.c: pipeconf &= ~PIPECONF_INTERLACE_MASK; /* progressive */
intel_display.c: pipeconf |= PIPECONF_INTERLACE_W_FIELD_INDICATION;
intel_display.c: pipeconf &= ~PIPECONF_INTERLACE_W_FIELD_INDICATION; /* progressive */
The second setting of progressive mode should use PIPECONF_INTERLACE_MASK, too.
Signed-off-by: Christian Schmidt <schmidt@digadd.de>
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 56a8554..3a3ca1a 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5048,7 +5048,7 @@ static int i9xx_crtc_mode_set(struct drm_crtc *crtc,
adjusted_mode->crtc_vsync_end -= 1;
adjusted_mode->crtc_vsync_start -= 1;
} else
- pipeconf &= ~PIPECONF_INTERLACE_W_FIELD_INDICATION; /* progressive */
+ pipeconf &= ~PIPECONF_INTERLACE_MASK; /* progressive */
I915_WRITE(HTOTAL(pipe),
(adjusted_mode->crtc_hdisplay - 1) |
--
1.7.8.3
next reply other threads:[~2012-02-24 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 9:51 Christian Schmidt [this message]
2012-02-24 14:24 ` [PATCH] [i915] Fix another use of the wrong interlace mask to return to progressive mode Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330077102-14146-1-git-send-email-schmidt@digadd.de \
--to=schmidt@digadd.de \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox