From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/7 v6] drm/i915/intel_i2c: handle zero-length writes Date: Wed, 28 Mar 2012 19:34:17 +0100 Message-ID: <1332959669_130996@CP5-2952> References: <1332959199-32161-1-git-send-email-djkurtz@chromium.org> <1332959199-32161-2-git-send-email-djkurtz@chromium.org> Return-path: In-Reply-To: <1332959199-32161-2-git-send-email-djkurtz@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Vetter , Keith Packard , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Benson Leung , Yufeng Shen , Daniel Kurtz List-Id: dri-devel@lists.freedesktop.org On Thu, 29 Mar 2012 02:26:33 +0800, Daniel Kurtz wrote: > A common method of probing an i2c bus is trying to do a zero-length write. > Handle this case by checking the length first before decrementing it. > > This is actually important, since attempting a zero-length write is one > of the ways that i2cdetect and i2c_new_probed_device detect whether > there is device present on the bus with a given address. > > Signed-off-by: Daniel Kurtz Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre