From: "Michel Dänzer" <michel@daenzer.net>
To: alexdeucher@gmail.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon/kms: fix fans after resume
Date: Fri, 30 Mar 2012 08:08:45 +0200 [thread overview]
Message-ID: <1333087725.4510.65.camel@thor.local> (raw)
In-Reply-To: <1333062248-13156-1-git-send-email-alexdeucher@gmail.com>
On Don, 2012-03-29 at 19:04 -0400, alexdeucher@gmail.com wrote:
> From: Alex Deucher <alexander.deucher@amd.com>
>
> On pre-R600 asics, the SpeedFanControl table is not
> executed as part of ASIC_Init as it is on newer asics.
>
> Fixes:
> https://bugzilla.kernel.org/show_bug.cgi?id=29412
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/radeon/atom.c | 15 ++++++++++++++-
> drivers/gpu/drm/radeon/atom.h | 1 +
> 2 files changed, 15 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c
> index d1bd239..5ce9bf5 100644
> --- a/drivers/gpu/drm/radeon/atom.c
> +++ b/drivers/gpu/drm/radeon/atom.c
> [...]
> @@ -1317,7 +1320,17 @@ int atom_asic_init(struct atom_context *ctx)
>
> if (!CU16(ctx->cmd_table + 4 + 2 * ATOM_CMD_INIT))
> return 1;
> - return atom_execute_table(ctx, ATOM_CMD_INIT, ps);
> + ret = atom_execute_table(ctx, ATOM_CMD_INIT, ps);
> + if (ret)
> + return ret;
> +
> + memset(ps, 0, 64);
> +
> + if (rdev->family < CHIP_R600) {
> + if (CU16(ctx->cmd_table + 4 + 2 * ATOM_CMD_SPDFANCNTL))
> + atom_execute_table(ctx, ATOM_CMD_SPDFANCNTL, ps);
Should the return value of atom_execute_table() be assigned to ret here
as well? Either way,
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2012-03-30 6:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 23:04 [PATCH] drm/radeon/kms: fix fans after resume alexdeucher
2012-03-30 6:08 ` Michel Dänzer [this message]
2012-03-30 12:53 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333087725.4510.65.camel@thor.local \
--to=michel@daenzer.net \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox