From: Chris Wilson <chris@chris-wilson.co.uk>
To: Rob Clark <rob.clark@linaro.org>, dri-devel@lists.freedesktop.org
Cc: Rob Clark <rob@ti.com>, patches@linaro.org
Subject: Re: [PATCH RFC 1/2] drm: add bitmask property type
Date: Fri, 30 Mar 2012 09:44:36 +0100 [thread overview]
Message-ID: <1333097091_153768@CP5-2952> (raw)
In-Reply-To: <1333069366-2774-1-git-send-email-rob.clark@linaro.org>
On Thu, 29 Mar 2012 20:02:45 -0500, Rob Clark <rob.clark@linaro.org> wrote:
> + } else if (property->flags & DRM_MODE_PROP_BITMASK) {
> + int i;
> + __u64 valid_mask = 0;
> + for (i = 0; i < property->num_values; i++)
> + valid_mask |= (1 << property->values[i]);
This need to be 1LL << property->values[i].
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2012-03-30 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 1:02 [PATCH RFC 1/2] drm: add bitmask property type Rob Clark
2012-03-30 1:02 ` [PATCH RFC 2/2] drm: add plane properties Rob Clark
2012-03-30 1:15 ` [PATCH RFC 1/2] drm: add bitmask property type Rob Clark
2012-03-30 10:37 ` Ville Syrjälä
2012-03-30 11:00 ` Marcus Lorentzon
2012-03-30 12:25 ` Rob Clark
2012-03-30 16:59 ` Paulo Zanoni
2012-03-30 17:16 ` Paulo Zanoni
2012-03-30 8:44 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333097091_153768@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=patches@linaro.org \
--cc=rob.clark@linaro.org \
--cc=rob@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox