dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Jackson <ajax@redhat.com>
To: "Anton V. Boyarshinov" <boyarsh@altlinux.org>
Cc: DRI mailing list <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] xf86drm.c: add counter for ioctl restarting
Date: Mon, 16 Apr 2012 10:12:39 -0400	[thread overview]
Message-ID: <1334585559.17648.4.camel@atropine> (raw)
In-Reply-To: <20120416125435.6a94f9f9@boyarsh.office.altlinux.ru>


[-- Attachment #1.1: Type: text/plain, Size: 629 bytes --]

On Mon, 2012-04-16 at 12:54 +0400, Anton V. Boyarshinov wrote:
> Hi
>  
> > Obviously if we have a dead gpu, we need to break out of this loop. But
> > detecting a dead gpu (and returning an appropriate error like EIO) is the
> > kernel's job.
> In my case gpu isn't really dead. It works after some ioctl skip. I
> understend that it is a driver bug in any case, but i thing that working
> around this bugs with proper logging (absent in this patch) much better
> than lockup.

But your workaround isn't harmless.  It adds new failure modes for other
cases that currently work.  That's worse, not better.

- ajax

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2012-04-16 14:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13 13:26 [PATCH] xf86drm.c: add counter for ioctl restarting Anton V. Boyarshinov
2012-04-13 13:40 ` Chris Wilson
2012-04-16  8:45   ` Anton V. Boyarshinov
2012-04-13 13:42 ` Daniel Vetter
2012-04-13 14:45   ` Ville Syrjälä
2012-04-16  8:54   ` Anton V. Boyarshinov
2012-04-16 14:12     ` Adam Jackson [this message]
2012-04-16 15:05       ` Anton V. Boyarshinov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334585559.17648.4.camel@atropine \
    --to=ajax@redhat.com \
    --cc=boyarsh@altlinux.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox