dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: alexdeucher@gmail.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: fix VM page table setup on SI
Date: Fri, 29 Jun 2012 16:49:43 +0200	[thread overview]
Message-ID: <1340981383.3562.200.camel@thor.local> (raw)
In-Reply-To: <1340920387-28720-1-git-send-email-alexdeucher@gmail.com>

On Don, 2012-06-28 at 17:53 -0400, alexdeucher@gmail.com wrote: 
> From: Alex Deucher <alexander.deucher@amd.com>
> 
> Cayman and trinity allow for variable sized VM page
> tables, but SI requires that all page tables be the
> same size.  The current code assumes variablely sized
> VM page tables so SI may end up with part of each page
> table overlapping with other memory which could end
> up being interpreted by the VM hw as garbage.
> 
> Change the code to better accomodate SI.  Allocate enough
> space for at least 2 full page tables and always set
> last_pfn to max_pfn on SI so each VM is backed by a full
> page table.  This limits us to only 2 VMs active at any
> given time on SI.  This will be rectified and the code can
> be reunified once we move to two level page tables.
> 
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

This change breaks the radeonsi driver for me. egltri_screen (the
'golden' test for radeonsi at least basically working) locks up the
GPU. 

I don't have any details about the lockup yet, as the GPU reset attempt
hangs the machine. Any ideas offhand what radeonsi might be doing wrong?


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer

  parent reply	other threads:[~2012-06-29 14:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 21:53 [PATCH] drm/radeon: fix VM page table setup on SI alexdeucher
2012-06-28 23:05 ` Jerome Glisse
2012-06-29 14:49 ` Michel Dänzer [this message]
2012-06-29 15:23   ` Alex Deucher
2012-06-29 15:28     ` Jerome Glisse
2012-06-29 16:14       ` Michel Dänzer
2012-06-29 18:07         ` Jerome Glisse
2012-07-17 11:28           ` Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1340981383.3562.200.camel@thor.local \
    --to=michel@daenzer.net \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox