Re: [PATCH 15/15] drm/radeon: implement ring saving on reset v2

["Michel Dänzer" <michel@daenzer.net>]

On Die, 2012-07-10 at 14:51 +0200, Christian König wrote: 
> Try to save whatever is on the rings when
> we encounter an lockup.
> 
> v2: Fix spelling error. Free saved ring data if reset fails.
>     Add documentation for the new functions.
> 
> Signed-off-by: Christian König <deathsimple@vodafone.de>

Just some more spelling nits, otherwise this patch and patch 13 are

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>


> +/**
> + * radeon_ring_backup - Backup the content of a ring
> + *
> + * @rdev: radeon_device pointer
> + * @ring: the ring we want to backup

'back up', in both cases.

> + * Saves all unprocessed commits to a ring, returns the number of dwords saved.
> + */

'unprocessed commands from'?


> +/**
> + * radeon_ring_restore - append saved commands to the ring again
> + *
> + * @rdev: radeon_device pointer
> + * @ring: ring to append commands to
> + * @size: number of dwords we want to write
> + * @data: saved commands
> + *
> + * Allocates space on the ring and restore the previusly saved commands.

'previously'


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer