From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel =?ISO-8859-1?Q?D=E4nzer?= Subject: Re: [PATCH V2] drm/radeon: Include swiotlb.h if SWIOTLB configured. Date: Mon, 13 Aug 2012 15:16:24 +0200 Message-ID: <1344863784.17900.440.camel@thor.local> References: <1344861653-27261-1-git-send-email-chenhc@lemote.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1344861653-27261-1-git-send-email-chenhc@lemote.com> Sender: linux-kernel-owner@vger.kernel.org To: Huacai Chen Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Fuxin Zhang , Alex Deucher , Hongliang Tao , Hua Yan List-Id: dri-devel@lists.freedesktop.org On Mon, 2012-08-13 at 20:40 +0800, Huacai Chen wrote:=20 > When SWIOTLB is configured, if without this patch kernel compilation > fails with such error messages: >=20 > drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_ttm_tt_popul= ate': > drivers/gpu/drm/radeon/radeon_ttm.c:606:2: error: implicit declaratio= n of function 'swiotlb_nr_tbl' > drivers/gpu/drm/radeon/radeon_ttm.c:607:3: warning: passing argument = 2 of 'ttm_dma_populate' from incompatible pointer type > include/drm/ttm/ttm_page_alloc.h:81:12: note: expected 'struct device= *' but argument is of type 'struct device *' > drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_ttm_tt_unpop= ulate': > drivers/gpu/drm/radeon/radeon_ttm.c:653:3: warning: passing argument = 2 of 'ttm_dma_unpopulate' from incompatible pointer type > include/drm/ttm/ttm_page_alloc.h:82:13: note: expected 'struct device= *' but argument is of type 'struct device *' >=20 > V2: > 1, Add compilation error messages; > 2, Make the From: address the same as Signed-off-by address. >=20 > Signed-off-by: Huacai Chen Reviewed-by: Michel D=E4nzer --=20 Earthling Michel D=E4nzer | http://www.amd.= com Libre software enthusiast | Debian, X and DRI develope= r