dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Ander Conselvan de Oliveira <conselvan2@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Subject: [PATCH libdrm] libkms: fix the name of the intel driver in linux_sysfs_create
Date: Wed,  5 Sep 2012 14:30:35 +0300	[thread overview]
Message-ID: <1346844635-21447-1-git-send-email-conselvan2@gmail.com> (raw)

From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>

linux_sysfs_create() checked for a driver named "intel" while the intel
driver is called "i915". This went unnoticed because in kernels 2.6.39
and after this code path was never reached because of the dumb buffer
interface. On earlier kernels, kms_create() would fail.

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
---
 libkms/linux.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/libkms/linux.c b/libkms/linux.c
index fc4f205..dde74f7 100644
--- a/libkms/linux.c
+++ b/libkms/linux.c
@@ -101,7 +101,7 @@ linux_from_sysfs(int fd, struct kms_driver **out)
 	if (ret)
 		return ret;
 
-	if (!strcmp(name, "intel"))
+	if (!strcmp(name, "i915"))
 		ret = intel_create(fd, out);
 #ifdef HAVE_VMWGFX
 	else if (!strcmp(name, "vmwgfx"))
-- 
1.7.4.1

             reply	other threads:[~2012-09-05 11:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05 11:30 Ander Conselvan de Oliveira [this message]
2012-10-29 13:47 ` [PATCH libdrm] libkms: fix the name of the intel driver in linux_sysfs_create Ander Conselvan de Oliveira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1346844635-21447-1-git-send-email-conselvan2@gmail.com \
    --to=conselvan2@gmail.com \
    --cc=ander.conselvan.de.oliveira@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).