From: Imre Deak <imre.deak@intel.com>
To: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Kristian Høgsberg" <krh@bitplanet.net>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [RFC 2/4] drm: make memset/calloc for _vblank_time more robust
Date: Fri, 5 Oct 2012 16:37:00 +0300 [thread overview]
Message-ID: <1349444222-22274-3-git-send-email-imre.deak@intel.com> (raw)
In-Reply-To: <1349444222-22274-1-git-send-email-imre.deak@intel.com>
Using sizeof(*var) instead of sizeof(var_type) allows changing var_type
w/o breaking callers that depend on the size.
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/drm_irq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
index 076c4a8..77f6577 100644
--- a/drivers/gpu/drm/drm_irq.c
+++ b/drivers/gpu/drm/drm_irq.c
@@ -90,7 +90,7 @@ int drm_irq_by_busid(struct drm_device *dev, void *data,
static void clear_vblank_timestamps(struct drm_device *dev, int crtc)
{
memset(&dev->_vblank_time[crtc * DRM_VBLANKTIME_RBSIZE], 0,
- DRM_VBLANKTIME_RBSIZE * sizeof(struct timeval));
+ DRM_VBLANKTIME_RBSIZE * sizeof(dev->_vblank_time[0]));
}
/*
@@ -248,7 +248,7 @@ int drm_vblank_init(struct drm_device *dev, int num_crtcs)
goto err;
dev->_vblank_time = kcalloc(num_crtcs * DRM_VBLANKTIME_RBSIZE,
- sizeof(struct timeval), GFP_KERNEL);
+ sizeof(dev->_vblank_time[0]), GFP_KERNEL);
if (!dev->_vblank_time)
goto err;
--
1.7.9.5
next prev parent reply other threads:[~2012-10-05 13:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 13:36 [RFC 0/4] drm: add raw monotonic timestamp support Imre Deak
2012-10-05 13:36 ` [RFC 1/4] time: export getnstime_raw_and_real for DRM Imre Deak
2012-10-05 16:14 ` Kristian Høgsberg
2012-10-09 10:25 ` Imre Deak
2012-10-05 13:37 ` Imre Deak [this message]
2012-10-05 13:37 ` [RFC 3/4] drm: use raw time in drm_calc_vbltimestamp_from_scanoutpos Imre Deak
2012-10-05 13:37 ` [RFC 4/4] drm: add support for raw monotonic vblank timestamps Imre Deak
2012-10-05 13:55 ` Michel Dänzer
2012-10-05 13:59 ` Imre Deak
2012-10-05 14:14 ` Michel Dänzer
2012-10-05 14:21 ` Imre Deak
2012-10-05 22:18 ` Rob Clark
2012-10-05 23:41 ` Imre Deak
2012-10-06 0:09 ` Rob Clark
2012-10-06 0:49 ` Imre Deak
2012-10-07 20:33 ` Daniel Vetter
2012-10-05 23:07 ` [RFC 0/4] drm: add raw monotonic timestamp support Eric Anholt
2012-10-08 11:22 ` Imre Deak
2012-10-11 10:29 ` Laurent Pinchart
2012-10-11 11:21 ` Imre Deak
2012-10-11 10:32 ` Laurent Pinchart
2012-10-11 11:22 ` Imre Deak
2012-10-23 18:53 ` [PATCH 0/2] drm: add " Imre Deak
2012-10-23 18:53 ` [PATCH 1/2] drm: use monotonic time in drm_calc_vbltimestamp_from_scanoutpos Imre Deak
2012-10-24 23:05 ` Mario Kleiner
2012-10-25 10:28 ` Imre Deak
2012-10-25 19:45 ` Mario Kleiner
2012-10-23 18:53 ` [PATCH 2/2] drm: add support for monotonic vblank timestamps Imre Deak
2012-10-24 8:08 ` Michel Dänzer
2012-10-24 11:40 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349444222-22274-3-git-send-email-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=krh@bitplanet.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).