From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel =?ISO-8859-1?Q?D=E4nzer?= Subject: Re: [PATCH 2/2] drm: add support for monotonic vblank timestamps Date: Wed, 24 Oct 2012 10:08:44 +0200 Message-ID: <1351066124.11117.51.camel@thor.local> References: <1351018407-7009-1-git-send-email-imre.deak@intel.com> <1351018407-7009-3-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1351018407-7009-3-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Imre Deak Cc: krh@freedesktop.org, Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Die, 2012-10-23 at 21:53 +0300, Imre Deak wrote: = > Jumps in the vblank and page flip event timestamps cause trouble for > clients, so we should avoid them. The timestamp we get currently with > gettimeofday can jump, so use instead monotonic timestamps. > = > For backward compatibility use a module flag to revert back to using > gettimeofday timestamps. Add also a DRM_CAP_TIMESTAMP_MONOTONIC flag > that is simply a read only version of the module flag, so that clients > can query this without depending on sysfs. > = > Signed-off-by: Imre Deak drm_timestamp_monotonic should probably be a bool rather than an int. Looks good to me otherwise, as does patch 1. -- = Earthling Michel D=E4nzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI developer