From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH v2 0/4] drm/exynos,intel: fix locking for flip/vbl event list Date: Wed, 07 Nov 2012 12:43:19 +0200 Message-ID: <1352284999.20257.10.camel@ideak-mobl> References: <1351721019-8040-1-git-send-email-imre.deak@intel.com> <1351855850-6577-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Inki Dae Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rob Clark List-Id: dri-devel@lists.freedesktop.org On Wed, 2012-11-07 at 18:31 +0900, Inki Dae wrote: > 2012/11/2 Imre Deak > The patchset adds the missing event_lock when accessing the > vblank_event_list in drm_vblank_off() and as preparation for > this > also fixes a few other issues in the exynos driver. > This is also a dependency for Rob Clark's > drm_send_vblank_event() > rework as that would trigger a warning for the unhold > event_lock without > this changeset. > The exynos changes are only compile tested, the rest is tested > on an > Intel IVB machine on top of drm-intel-nightly + > drm_send_vblank_event() > rework, with i-g-t/flip_test. > Hi Imre, > Works fine. But we should wait for Rob's patch set to be merged to > -next, and this may be rebased on top of latest Rob's patch set again. Ok, thanks for checking this. I assume then that this patchset will get merged through your tree. I think Rob's patchset depends on this, so ideally this should go first. Otherwise the i915 driver would trigger the WARN in his patchset due to the unheld event_lock. --Imre