From: Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: olofj-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org
Subject: [PATCH v2] drm/exynos: Get HDMI version from device tree
Date: Tue, 8 Jan 2013 15:16:21 -0500 [thread overview]
Message-ID: <1357676181-16728-1-git-send-email-seanpaul@chromium.org> (raw)
In-Reply-To: <50EC5EDE.3030208-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
Add a property to the hdmi node so we can specify the HDMI version in
the device tree instead of just defaulting to v1.4 with the existence of
the dt node.
Signed-off-by: Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
---
.../devicetree/bindings/drm/exynos/hdmi.txt | 2 +
drivers/gpu/drm/exynos/exynos_hdmi.c | 22 ++++++++++----------
2 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmi.txt b/Documentation/devicetree/bindings/drm/exynos/hdmi.txt
index 589edee..228ede6 100644
--- a/Documentation/devicetree/bindings/drm/exynos/hdmi.txt
+++ b/Documentation/devicetree/bindings/drm/exynos/hdmi.txt
@@ -11,6 +11,7 @@ Required properties:
c) pin function mode.
d) optional flags and pull up/down.
e) drive strength.
+- hdmi-version: (major << 8) | minor
Example:
@@ -19,4 +20,5 @@ Example:
reg = <0x14530000 0x100000>;
interrupts = <0 95 0>;
hpd-gpio = <&gpx3 7 0xf 1 3>;
+ hdmi-version = <0x104>; /* version 1.4 */
};
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 2c46b6c..71736f9 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -74,8 +74,8 @@ enum HDMI_PACKET_TYPE {
};
enum hdmi_type {
- HDMI_TYPE13,
- HDMI_TYPE14,
+ HDMI_TYPE13 = (1 << 8) | 3,
+ HDMI_TYPE14 = (1 << 8) | 4,
};
struct hdmi_resources {
@@ -2444,7 +2444,6 @@ static struct platform_device_id hdmi_driver_types[] = {
static struct of_device_id hdmi_match_types[] = {
{
.compatible = "samsung,exynos5-hdmi",
- .data = (void *)HDMI_TYPE14,
}, {
/* end node */
}
@@ -2459,6 +2458,7 @@ static int __devinit hdmi_probe(struct platform_device *pdev)
struct s5p_hdmi_platform_data *pdata;
struct resource *res;
int ret;
+ u32 ver;
DRM_DEBUG_KMS("[%d]\n", __LINE__);
@@ -2498,16 +2498,16 @@ static int __devinit hdmi_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, drm_hdmi_ctx);
- if (dev->of_node) {
- const struct of_device_id *match;
- match = of_match_node(of_match_ptr(hdmi_match_types),
- pdev->dev.of_node);
- if (match == NULL)
- return -ENODEV;
- hdata->type = (enum hdmi_type)match->data;
- } else {
+ if (!dev->of_node) {
hdata->type = (enum hdmi_type)platform_get_device_id
(pdev)->driver_data;
+ } else {
+ ret = of_property_read_u32(dev->of_node, "hdmi-version", &ver);
+ if (ret) {
+ DRM_ERROR("Could not resolve HDMI version support\n");
+ return ret;
+ }
+ hdata->type = (enum hdmi_type)ver;
}
hdata->hpd_gpio = pdata->hpd_gpio;
--
1.7.7.3
next prev parent reply other threads:[~2013-01-08 20:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 20:43 [PATCH] drm/exynos: Get HDMI version from device tree Sean Paul
[not found] ` <1357591415-17092-1-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2013-01-07 20:54 ` Mitch Bradley
[not found] ` <50EB3604.60209-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
2013-01-07 21:12 ` Sean Paul
2013-01-08 16:45 ` Lucas Stach
2013-01-08 16:48 ` Sean Paul
[not found] ` <CAOw6vbLYZgAj6Rco1qDQUhqVs1b10fBL9F0Vq0LBUBo14KJLrQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-08 18:01 ` Mitch Bradley
[not found] ` <50EC5EDE.3030208-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
2013-01-08 20:16 ` Sean Paul [this message]
[not found] ` <1357676181-16728-1-git-send-email-seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2013-01-08 22:56 ` [PATCH v2] " Stephen Warren
[not found] ` <50ECA400.50007-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-29 16:10 ` Sean Paul
[not found] ` <CAOw6vbK_wJupFt0CG6Bw5y0=Wq4qAJ0HvMSATgyOt+fK+tqR6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-30 5:40 ` Inki Dae
2013-01-29 20:04 ` Sylwester Nawrocki
[not found] ` <51082B6A.1010406-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-01-31 1:16 ` Inki Dae
[not found] ` <CAAQKjZNR8EJ+UFRO3vgYLH9So_gHn0a8gAf1JKu250shGiJ4qQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-31 3:03 ` Stephen Warren
[not found] ` <5109DF18.6010202-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-31 4:52 ` Inki Dae
2013-01-31 6:22 ` Rahul Sharma
2013-01-31 15:04 ` Sean Paul
[not found] ` <CAOw6vbJtUQdDLNkhg3ZL10KaPK=wQRDxkVUUUqO_=W84sYHgzg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-31 17:36 ` Stephen Warren
[not found] ` <510AAB94.6030406-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-02-01 2:30 ` Stephen Warren
2013-01-31 18:25 ` Olof Johansson
2013-01-07 22:32 ` [PATCH] " Stephen Warren
[not found] ` <50EB4D11.7000407-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-07 23:12 ` Sean Paul
[not found] ` <CAOw6vbKqVnDt7PH1JTtG1cujnfzNOeK-eHhebpX9WSytnhwmBg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-01-08 16:38 ` Stephen Warren
[not found] ` <50EC4B8F.1050802-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-01-08 16:43 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357676181-16728-1-git-send-email-seanpaul@chromium.org \
--to=seanpaul-f7+t8e8rja9g9huczpvpmw@public.gmane.org \
--cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=olofj-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).