From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Su, Xuemin" Subject: [PATCH V3] drm_crtc: check if fb_create return NULL Date: Thu, 24 Jan 2013 08:36:44 +0800 Message-ID: <1358987804.18561.22.camel@suxuemin.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Sender: linux-kernel-owner@vger.kernel.org To: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: bo.he@intel.com, xuemin.su@intel.com, yanmin_zhang@linux.intel.com List-Id: dri-devel@lists.freedesktop.org From: xueminsu Date: Tue, 22 Jan 2013 22:39:39 +0800 Subject: [PATCH] drm_crtc: check if fb_create return NULL Some buggy driver may still return NULL in fb_create, which leads to kernel panic. Signed-off-by: xueminsu --- drivers/gpu/drm/drm_crtc.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index f2d667b..ae613ec 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -2172,6 +2172,8 @@ int drm_mode_addfb(struct drm_device *dev, ret = PTR_ERR(fb); goto out; } + /* some buggy driver may return NULL here, which may cause panic */ + BUG_ON(!fb); or->fb_id = fb->base.id; list_add(&fb->filp_head, &file_priv->fbs); -- 1.7.6