From: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
To: Dave Airlie <airlied-cv59FeDIM0c@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v4 7/9] drm/tegra: Split DC_CMD_STATE_CONTROL register write
Date: Thu, 21 Feb 2013 15:35:59 +0100 [thread overview]
Message-ID: <1361457361-13838-8-git-send-email-thierry.reding@avionic-design.de> (raw)
In-Reply-To: <1361457361-13838-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
The Tegra TRM says that the ACT_REQ and UPDATE fields cannot be
programmed at the same time so they are updated in two consecutive
writes instead.
Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
---
drivers/gpu/drm/tegra/dc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
index c5d825f..2086400 100644
--- a/drivers/gpu/drm/tegra/dc.c
+++ b/drivers/gpu/drm/tegra/dc.c
@@ -689,9 +689,10 @@ static void tegra_crtc_commit(struct drm_crtc *crtc)
struct tegra_dc *dc = to_tegra_dc(crtc);
unsigned long value;
- value = GENERAL_ACT_REQ | WIN_A_ACT_REQ |
- GENERAL_UPDATE | WIN_A_UPDATE;
+ value = GENERAL_UPDATE | WIN_A_UPDATE;
+ tegra_dc_writel(dc, value, DC_CMD_STATE_CONTROL);
+ value = GENERAL_ACT_REQ | WIN_A_ACT_REQ;
tegra_dc_writel(dc, value, DC_CMD_STATE_CONTROL);
drm_vblank_post_modeset(crtc->dev, dc->pipe);
--
1.8.1.2
next prev parent reply other threads:[~2013-02-21 14:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 14:35 [PATCH v4 0/9] drm/tegra: Miscellaneous enhancements Thierry Reding
[not found] ` <1361457361-13838-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2013-02-21 14:35 ` [PATCH v4 1/9] drm: Add consistency check for page-flipping Thierry Reding
2013-02-21 14:35 ` [PATCH v4 2/9] drm/tegra: Remove bogus tegra_framebuffer structure Thierry Reding
2013-02-21 14:35 ` [PATCH v4 3/9] drm/tegra: Add plane support Thierry Reding
2013-02-21 14:35 ` [PATCH v4 4/9] drm/tegra: Implement .mode_set_base() Thierry Reding
2013-02-21 14:35 ` [PATCH v4 5/9] drm/tegra: Implement VBLANK support Thierry Reding
2013-02-21 14:35 ` [PATCH v4 6/9] drm/tegra: Implement page-flipping support Thierry Reding
2013-02-22 16:13 ` Mario Kleiner
2013-02-25 7:06 ` Thierry Reding
2013-02-28 1:09 ` Mario Kleiner
2013-02-21 14:35 ` Thierry Reding [this message]
2013-02-21 14:36 ` [PATCH v4 8/9] drm/tegra: Fix color expansion Thierry Reding
2013-02-21 14:36 ` [PATCH v4 9/9] drm/tegra: Add list of framebuffers to debugfs Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361457361-13838-8-git-send-email-thierry.reding@avionic-design.de \
--to=thierry.reding-rm9k5ik7kjkj5m59nbduvrnah6klmebb@public.gmane.org \
--cc=airlied-cv59FeDIM0c@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox