From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Menzel Subject: Re: [PATCH] drm/mgag200: Cleanup: Remove pointless call to drm_fb_get_bpp_depth Date: Wed, 27 Feb 2013 00:22:02 +0100 Message-ID: <1361920922.6140.28.camel@mattotaupa> References: <20130226155358.GA18614@harvey-pc.matrox.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1604055823==" Return-path: Received: from mail.gw90.de (mail.gw90.de [188.40.100.199]) by gabe.freedesktop.org (Postfix) with ESMTP id B76D1E5F5E for ; Tue, 26 Feb 2013 15:22:15 -0800 (PST) In-Reply-To: <20130226155358.GA18614@harvey-pc.matrox.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Christopher Harvey Cc: Julia Lemire , Mathieu Larouche , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1604055823== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-BWw+iG1xUwJu0rBcYbEF" --=-BWw+iG1xUwJu0rBcYbEF Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear Christopher, thank you for your patches. Not sure if you should CC some maintainer (or if you did already). Am Dienstag, den 26.02.2013, 10:53 -0500 schrieb Christopher Harvey: 1. I guess you can remove Cleanup from the commit summary. 2. Why is it =C2=BBpointless=C2=AB? I guess a compiler warning that bpp is = unused? Please paste it into the commit message then. As otherwise this cannot be judged from just looking at the diff below. > Signed-off-by: Christopher Harvey > --- > drivers/gpu/drm/mgag200/mgag200_fb.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/mgag200/mgag200_fb.c b/drivers/gpu/drm/mgag2= 00/mgag200_fb.c > index 2f48648..d46bd2c 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_fb.c > +++ b/drivers/gpu/drm/mgag200/mgag200_fb.c > @@ -104,12 +104,9 @@ static int mgag200fb_create_object(struct mga_fbdev = *afbdev, > struct drm_gem_object **gobj_p) > { > struct drm_device *dev =3D afbdev->helper.dev; > - u32 bpp, depth; > u32 size; > struct drm_gem_object *gobj; > - > int ret =3D 0; > - drm_fb_get_bpp_depth(mode_cmd->pixel_format, &depth, &bpp); > =20 > size =3D mode_cmd->pitches[0] * mode_cmd->height; > ret =3D mgag200_gem_create(dev, size, true, &gobj); Thanks, Paul --=-BWw+iG1xUwJu0rBcYbEF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlEtQ5oACgkQPX1aK2wOHVgctQCdElCd568CTTQCHQetwh7qFSvv Bf4An0s5oZyIzK+csIEKblqVwHoBcTUC =TBRS -----END PGP SIGNATURE----- --=-BWw+iG1xUwJu0rBcYbEF-- --===============1604055823== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1604055823==--