From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Menzel Subject: Re: [PATCH] drm/mgag200: Cleanup: Remove extra variable assigns Date: Wed, 27 Feb 2013 00:28:57 +0100 Message-ID: <1361921337.6140.31.camel@mattotaupa> References: <20130226155510.GA18647@harvey-pc.matrox.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1352224925==" Return-path: Received: from mail.gw90.de (mail.gw90.de [188.40.100.199]) by gabe.freedesktop.org (Postfix) with ESMTP id 025BFE5D2B for ; Tue, 26 Feb 2013 15:29:00 -0800 (PST) In-Reply-To: <20130226155510.GA18647@harvey-pc.matrox.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Christopher Harvey Cc: Julia Lemire , Mathieu Larouche , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1352224925== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-6ANgAHl1Wk0ZQ13QV0Fl" --=-6ANgAHl1Wk0ZQ13QV0Fl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Am Dienstag, den 26.02.2013, 10:55 -0500 schrieb Christopher Harvey: *assignments > These two variables are set again immediately in 'mgag200_modeset_init' The compiler would optimize this anyway I guess. Though now it can warn us, if the code should ever change and these variable are not set anymore in all cases. > Signed-off-by: Christopher Harvey > --- > drivers/gpu/drm/mgag200/mgag200_main.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mga= g200/mgag200_main.c > index 70dd3c5..aad280a 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_main.c > +++ b/drivers/gpu/drm/mgag200/mgag200_main.c > @@ -240,8 +240,6 @@ int mgag200_driver_load(struct drm_device *dev, unsig= ned long flags) > =20 > drm_mode_config_init(dev); > dev->mode_config.funcs =3D (void *)&mga_mode_funcs; > - dev->mode_config.min_width =3D 0; > - dev->mode_config.min_height =3D 0; > dev->mode_config.preferred_depth =3D 24; > dev->mode_config.prefer_shadow =3D 1; Acked-by: Paul Menzel Thanks, Paul --=-6ANgAHl1Wk0ZQ13QV0Fl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlEtRTkACgkQPX1aK2wOHViihACffIjEJeJBDDTnv9B+dRO8JtOi wJQAnizBSWJ/auvuRTRKVW+VSnGCLlGL =xtS5 -----END PGP SIGNATURE----- --=-6ANgAHl1Wk0ZQ13QV0Fl-- --===============1352224925== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1352224925==--