dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
	David Airlie <airlied@linux.ie>,
	Darren Etheridge <detheridge@ti.com>,
	Rob Clark <robdclark@gmail.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/8] drm/i2c: tda998x: ensure VIP output mux is properly set
Date: Tue,  6 Aug 2013 00:20:12 +0200	[thread overview]
Message-ID: <1375741218-10225-3-git-send-email-sebastian.hesselbarth@gmail.com> (raw)
In-Reply-To: <1375741218-10225-1-git-send-email-sebastian.hesselbarth@gmail.com>

From: Russell King <rmk+kernel@arm.linux.org.uk>

When switching between various drivers for this device, it's possible
that some critical registers are left containing values which affect
the device operation.  One such case encountered is the VIP output
mux register.  This defaults to 0x24 on powerup, but other drivers may
set this to 0x12.  This results in incorrect colours.

Fix this by ensuring that the register is always set to the power on
default setting.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
---
Cc: David Airlie <airlied@linux.ie>
Cc: Darren Etheridge <detheridge@ti.com>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/gpu/drm/i2c/tda998x_drv.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
index d71c408..4b4db95 100644
--- a/drivers/gpu/drm/i2c/tda998x_drv.c
+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
@@ -110,6 +110,7 @@ struct tda998x_priv {
 #define REG_VIP_CNTRL_5           REG(0x00, 0x25)     /* write */
 # define VIP_CNTRL_5_CKCASE       (1 << 0)
 # define VIP_CNTRL_5_SP_CNT(x)    (((x) & 3) << 1)
+#define REG_MUX_VP_VIP_OUT        REG(0x00, 0x27)     /* read/write */
 #define REG_MAT_CONTRL            REG(0x00, 0x80)     /* write */
 # define MAT_CONTRL_MAT_SC(x)     (((x) & 3) << 0)
 # define MAT_CONTRL_MAT_BP        (1 << 2)
@@ -438,6 +439,8 @@ tda998x_encoder_dpms(struct drm_encoder *encoder, int mode)
 
 	switch (mode) {
 	case DRM_MODE_DPMS_ON:
+		/* Write the default value MUX register */
+		reg_write(encoder, REG_MUX_VP_VIP_OUT, 0x24);
 		/* enable audio and video ports */
 		reg_write(encoder, REG_ENA_AP, 0xff);
 		reg_write(encoder, REG_ENA_VP_0, 0xff);
-- 
1.7.10.4

  parent reply	other threads:[~2013-08-05 22:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05 22:20 [PATCH 0/8] Several NXP TDA998x patches Sebastian Hesselbarth
2013-08-05 22:20 ` [PATCH 1/8] drm/i2c: tda998x: fix EDID reading on TDA19988 devices Sebastian Hesselbarth
2013-08-14 12:16   ` Russell King - ARM Linux
2013-08-14 12:32     ` Rob Clark
2013-08-05 22:20 ` Sebastian Hesselbarth [this message]
2013-08-14 12:15   ` [PATCH 2/8] drm/i2c: tda998x: ensure VIP output mux is properly set Russell King - ARM Linux
2013-08-05 22:20 ` [PATCH 3/8] drm/i2c: tda998x: fix npix/nline programming Sebastian Hesselbarth
2013-08-05 22:20 ` [PATCH 4/8] drm/i2c: tda998x: prepare for video input configuration Sebastian Hesselbarth
2013-08-05 22:20 ` [PATCH 5/8] drm/i2c: tda998x: add video and audio " Sebastian Hesselbarth
2013-08-14 12:20   ` Russell King - ARM Linux
2013-08-14 14:12   ` Russell King - ARM Linux
2013-08-14 14:34     ` Sebastian Hesselbarth
2013-08-05 22:20 ` [PATCH 6/8] drm/i2c: tda998x: fix sync generation and calculation Sebastian Hesselbarth
2013-08-14 12:41   ` Russell King - ARM Linux
2013-08-14 14:14     ` Sebastian Hesselbarth
2013-08-14 14:35   ` Russell King - ARM Linux
2013-08-05 22:20 ` [PATCH 7/8] drm/i2c: tda998x: prepare for broken sync workaround Sebastian Hesselbarth
2013-08-05 22:20 ` [PATCH 8/8] drm/tilcdc fixup mode to workaound sync for tda998x Sebastian Hesselbarth
2013-08-06 16:26 ` [PATCH 0/8] Several NXP TDA998x patches Etheridge, Darren
2013-08-08 22:08 ` Darren Etheridge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375741218-10225-3-git-send-email-sebastian.hesselbarth@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@ffwll.ch \
    --cc=detheridge@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).