From: David Herrmann <dh.herrmann@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: [PATCH v4 6/6] drm/radeon: use new drm_kick_out_firmware()
Date: Sun, 1 Sep 2013 15:36:52 +0200 [thread overview]
Message-ID: <1378042612-5354-7-git-send-email-dh.herrmann@gmail.com> (raw)
In-Reply-To: <1378042612-5354-1-git-send-email-dh.herrmann@gmail.com>
Kick out firmware DRM and fbdev drivers via the new
drm_kick_out_firmware() before loading radeon.
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
---
drivers/gpu/drm/radeon/radeon_drv.c | 28 ----------------------------
drivers/gpu/drm/radeon/radeon_kms.c | 30 ++++++++++++++++++++++++++++++
2 files changed, 30 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index 1f93dd5..13f1e15 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -311,37 +311,9 @@ static struct drm_driver driver_old = {
static struct drm_driver kms_driver;
-static int radeon_kick_out_firmware_fb(struct pci_dev *pdev)
-{
- struct apertures_struct *ap;
- bool primary = false;
-
- ap = alloc_apertures(1);
- if (!ap)
- return -ENOMEM;
-
- ap->ranges[0].base = pci_resource_start(pdev, 0);
- ap->ranges[0].size = pci_resource_len(pdev, 0);
-
-#ifdef CONFIG_X86
- primary = pdev->resource[PCI_ROM_RESOURCE].flags & IORESOURCE_ROM_SHADOW;
-#endif
- remove_conflicting_framebuffers(ap, "radeondrmfb", primary);
- kfree(ap);
-
- return 0;
-}
-
static int radeon_pci_probe(struct pci_dev *pdev,
const struct pci_device_id *ent)
{
- int ret;
-
- /* Get rid of things like offb */
- ret = radeon_kick_out_firmware_fb(pdev);
- if (ret)
- return ret;
-
return drm_get_pci_dev(pdev, ent, &kms_driver);
}
diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c
index b46a561..d8f2a38 100644
--- a/drivers/gpu/drm/radeon/radeon_kms.c
+++ b/drivers/gpu/drm/radeon/radeon_kms.c
@@ -62,6 +62,30 @@ done_free:
return 0;
}
+static int radeon_kick_out_firmware(struct drm_device *dev)
+{
+ struct pci_dev *pdev = dev->pdev;
+ struct apertures_struct *ap;
+ bool primary = false;
+
+ ap = alloc_apertures(1);
+ if (!ap)
+ return -ENOMEM;
+
+ ap->ranges[0].base = pci_resource_start(pdev, 0);
+ ap->ranges[0].size = pci_resource_len(pdev, 0);
+
+#ifdef CONFIG_X86
+ primary = pdev->resource[PCI_ROM_RESOURCE].flags & IORESOURCE_ROM_SHADOW;
+#endif
+
+ drm_kick_out_firmware(ap, primary);
+ dev->apertures = ap;
+ dev->apert_boot = primary;
+
+ return 0;
+}
+
/**
* radeon_driver_load_kms - Main load function for KMS.
*
@@ -86,6 +110,12 @@ int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags)
}
dev->dev_private = (void *)rdev;
+ r = radeon_kick_out_firmware(dev);
+ if (r) {
+ kfree(rdev);
+ return r;
+ }
+
/* update BUS flag */
if (drm_pci_device_is_agp(dev)) {
flags |= RADEON_IS_AGP;
--
1.8.4
next prev parent reply other threads:[~2013-09-01 13:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 13:36 [PATCH v4 0/6] SimpleDRM Driver David Herrmann
2013-09-01 13:36 ` [PATCH v4 1/6] drm: add SimpleDRM driver David Herrmann
2013-09-21 14:18 ` Tom Gundersen
2013-10-02 15:09 ` David Herrmann
2013-09-01 13:36 ` [PATCH v4 2/6] drm: simpledrm: add fbdev fallback support David Herrmann
2013-09-01 13:36 ` [PATCH v4 3/6] drm: add helpers to kick out firmware drivers David Herrmann
2013-09-01 13:36 ` [PATCH v4 4/6] drm: nouveau: kick out firmware drivers during probe David Herrmann
2013-09-01 13:36 ` [PATCH v4 5/6] drm/i915: use new drm_kick_out_firmware() David Herrmann
2013-09-02 7:43 ` Daniel Vetter
2013-09-02 12:02 ` David Herrmann
2013-09-02 14:26 ` Daniel Vetter
2013-09-01 13:36 ` David Herrmann [this message]
2013-09-04 17:34 ` [PATCH v4 0/6] SimpleDRM Driver David Herrmann
2013-09-08 11:33 ` Tom Gundersen
2013-09-08 13:13 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378042612-5354-7-git-send-email-dh.herrmann@gmail.com \
--to=dh.herrmann@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).