From: Manjunath Goudar <manjunath.goudar@linaro.org>
To: patches@linaro.org
Cc: linaro-kernel@lists.linaro.org, dsaxena@linaro.org,
Jeyaraman R <jeyaraman.rangasamy@lge.com>,
Manjunath Goudar <manjunath.goudar@linaro.org>,
David Airlie <airlied@linux.ie>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
David Howells <dhowells@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dave Jones <davej@redhat.com>, Dave Airlie <airlied@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] DRM: TTM: Fix memory leak issue in ttm_agp_tt_create().
Date: Wed, 4 Sep 2013 11:58:10 +0530 [thread overview]
Message-ID: <1378276090-10130-1-git-send-email-manjunath.goudar@linaro.org> (raw)
From: Jeyaraman R <jeyaraman.rangasamy@lge.com>
This patch adds kfree() in ttm_agp_tt_create() to avoide the
memory leak, without this there is a chance of memory leak in
ttm_tt_init() fail case.
Signed-off-by: Jeyaraman R <jeyaraman.rangasamy@lge.com>
Signed-off-by: Manjunath Goudar <manjunath.goudar@linaro.org>
Cc: David Airlie <airlied@linux.ie>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Dave Jones <davej@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
---
drivers/gpu/drm/ttm/ttm_agp_backend.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/ttm/ttm_agp_backend.c b/drivers/gpu/drm/ttm/ttm_agp_backend.c
index 3302f99..764be36 100644
--- a/drivers/gpu/drm/ttm/ttm_agp_backend.c
+++ b/drivers/gpu/drm/ttm/ttm_agp_backend.c
@@ -126,6 +126,7 @@ struct ttm_tt *ttm_agp_tt_create(struct ttm_bo_device *bdev,
agp_be->ttm.func = &ttm_agp_func;
if (ttm_tt_init(&agp_be->ttm, bdev, size, page_flags, dummy_read_page)) {
+ kfree(agp_be);
return NULL;
}
--
1.8.1.2
next reply other threads:[~2013-09-04 6:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 6:28 Manjunath Goudar [this message]
2013-09-06 13:23 ` [PATCH] DRM: TTM: Fix memory leak issue in ttm_agp_tt_create() Konrad Rzeszutek Wilk
-- strict thread matches above, loose matches on Subject: below --
2013-10-08 10:36 Majunath Goudar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378276090-10130-1-git-send-email-manjunath.goudar@linaro.org \
--to=manjunath.goudar@linaro.org \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=davej@redhat.com \
--cc=dhowells@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsaxena@linaro.org \
--cc=jeyaraman.rangasamy@lge.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).