From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Velikov Subject: [PATCH] configure: add AC_LANG_SOURCE call within AC_COMPILE_IFELSE Date: Thu, 19 Sep 2013 17:21:01 +0100 Message-ID: <1379607661-20494-1-git-send-email-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com [209.85.215.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 86DB2E7555 for ; Thu, 19 Sep 2013 09:21:55 -0700 (PDT) Received: by mail-ea0-f175.google.com with SMTP id m14so4252202eaj.20 for ; Thu, 19 Sep 2013 09:21:54 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org Cc: emil.l.velikov@gmail.com List-Id: dri-devel@lists.freedesktop.org Documentation states that AC_*_IFELSE has to use AC_LANG_SOURCE or friends in order to generate the source code to compile. AC_LINK_IFELSE already handles this, thus convert AC_COMPILE_IFELSE to silence the final autoconf warnings. Signed-off-by: Emil Velikov --- While this patch is not strictly speaking necessary for the full/correct build of libdrm, it cuts down the configure'n'compile warnings to five. With the remaining being caused due to type conversion within exynos(4) and freedreno/kgsl(1). I planning to leave those to someone more aware of the respective codebase :) Cheers, Emil P.S. Keep me CC'd as I'm not subscribed to the list --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index d2e232b..43e6954 100644 --- a/configure.ac +++ b/configure.ac @@ -111,7 +111,7 @@ AC_DEFUN([LIBDRM_CC_TRY_FLAG], [ libdrm_save_CFLAGS="$CFLAGS" CFLAGS="$CFLAGS $1" - AC_COMPILE_IFELSE([ ], [libdrm_cc_flag=yes], [libdrm_cc_flag=no]) + AC_COMPILE_IFELSE([AC_LANG_SOURCE([ ])], [libdrm_cc_flag=yes], [libdrm_cc_flag=no]) CFLAGS="$libdrm_save_CFLAGS" if test "x$libdrm_cc_flag" = "xyes"; then -- 1.8.4