From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Herrmann Subject: [PATCH 0/5] DRM device-alloc cleanup Date: Wed, 2 Oct 2013 11:23:33 +0200 Message-ID: <1380705818-4065-1-git-send-email-dh.herrmann@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 3983EE6FE5 for ; Wed, 2 Oct 2013 02:23:41 -0700 (PDT) Received: by mail-ee0-f51.google.com with SMTP id c1so249928eek.10 for ; Wed, 02 Oct 2013 02:23:40 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hi This cleans up the bus drivers in DRM. Instead of copying the device alloc/free semantics into each bus driver (drm_{pci,platform,usb}.c) we now have a central place in drm_stub.c. This introduces drm_dev_{alloc,free,register,unregister}(). They have the same semantics as most other kernel subsystems. *_alloc() allocates a new device and populates the static fields and sub-objects. *_free() frees an unregistered object allocated via *_alloc(). *_register() registers a DRM device and *_unregister() obviously unregisters a DRM device. A *_free() is still needed after calling *_unregister() (same as for "struct device"). No ref-counting is added as it is not required by any driver. Note that the bus drivers are modified to use the new helpers directly. However, I didn't modify the drivers to use *_unregister() and *_free() directly. Instead, the drm_put_dev() helper was modified to use these. Reason for that is that I have pending patches to make device hotplugging safer regarding mmaps. But these aren't ready, yet. Hopefully I can get them ready for rc5 or rc6. Tested on nouveau. David David Herrmann (5): drm: add drm_dev_alloc() helper drm: merge device setup into drm_dev_register() drm: move drm_lastclose() to drm_fops.c drm: introduce drm_dev_free() to fix error paths drm: move device unregistration into drm_dev_unregister() drivers/gpu/drm/drm_drv.c | 70 ---------- drivers/gpu/drm/drm_fops.c | 70 ++++++++++ drivers/gpu/drm/drm_pci.c | 62 ++------- drivers/gpu/drm/drm_platform.c | 59 +------- drivers/gpu/drm/drm_stub.c | 310 ++++++++++++++++++++++++++++------------- drivers/gpu/drm/drm_usb.c | 57 +------- include/drm/drmP.h | 8 +- 7 files changed, 308 insertions(+), 328 deletions(-) -- 1.8.4