From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Herrmann Subject: [PATCH 2/2] simplefb: use write-combined remapping Date: Wed, 2 Oct 2013 16:58:39 +0200 Message-ID: <1380725919-1961-2-git-send-email-dh.herrmann@gmail.com> References: <1380725919-1961-1-git-send-email-dh.herrmann@gmail.com> Return-path: In-Reply-To: <1380725919-1961-1-git-send-email-dh.herrmann@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-fbdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Tom Gundersen , Alexandre Courbot , Stephen Warren , dri-devel@lists.freedesktop.org, Jean-Christophe Plagniol-Villard , Tomi Valkeinen , David Herrmann List-Id: dri-devel@lists.freedesktop.org Framebuffers shouldn't be cached and it is usually very uncommon to read them. Therefore, use ioremap_wc() to get significant speed improvements on systems which provide it. On all other systems it's aliased to ioremap_nocache() which is also fine. Reported-by: Tom Gundersen Signed-off-by: David Herrmann Tested-by: Tom Gundersen Tested-by: Alexandre Courbot Tested-by: Stephen Warren --- drivers/video/simplefb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c index 74b016c..64db54a 100644 --- a/drivers/video/simplefb.c +++ b/drivers/video/simplefb.c @@ -219,8 +219,8 @@ static int simplefb_probe(struct platform_device *pdev) info->fbops = &simplefb_ops; info->flags = FBINFO_DEFAULT | FBINFO_MISC_FIRMWARE; - info->screen_base = ioremap(info->fix.smem_start, - info->fix.smem_len); + info->screen_base = ioremap_wc(info->fix.smem_start, + info->fix.smem_len); if (!info->screen_base) { framebuffer_release(info); return -ENODEV; -- 1.8.4