From: Rob Clark <robdclark@gmail.com>
To: dri-devel@lists.freedesktop.org
Subject: [RFCv1 07/12] drm: Allow drm_mode_object_find() to look up an object of any type
Date: Sat, 5 Oct 2013 20:45:45 -0400 [thread overview]
Message-ID: <1381020350-1125-8-git-send-email-robdclark@gmail.com> (raw)
In-Reply-To: <1381020350-1125-1-git-send-email-robdclark@gmail.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
To avoid having to pass object types from userspace for atomic mode
setting ioctl, allow drm_mode_object_find() to look up an object of any
type. This will only work as long as the all object types share the ID
space.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/drm_crtc.c | 3 ++-
include/drm/drm_crtc.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 0b6e196..c0546e8 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -360,7 +360,8 @@ struct drm_mode_object *drm_mode_object_find(struct drm_device *dev,
mutex_lock(&dev->mode_config.idr_mutex);
obj = idr_find(&dev->mode_config.crtc_idr, id);
- if (!obj || (obj->type != type) || (obj->id != id))
+ if (!obj || (type != DRM_MODE_OBJECT_ANY && obj->type != type) ||
+ (obj->id != id))
obj = NULL;
mutex_unlock(&dev->mode_config.idr_mutex);
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 372b159..8831562 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -51,6 +51,7 @@ struct drm_object_property_values;
#define DRM_MODE_OBJECT_BLOB 0xbbbbbbbb
#define DRM_MODE_OBJECT_PLANE 0xeeeeeeee
#define DRM_MODE_OBJECT_BRIDGE 0xbdbdbdbd
+#define DRM_MODE_OBJECT_ANY 0
struct drm_mode_object {
uint32_t id;
--
1.8.3.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-10-06 0:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 0:45 [RFCv1 00/12] Atomic/nuclear modeset/pageflip Rob Clark
2013-10-06 0:45 ` [RFCv1 01/12] drm: add atomic fxns Rob Clark
2013-10-06 0:45 ` [RFCv1 02/12] drm: add object property type Rob Clark
2013-10-07 13:43 ` Ville Syrjälä
2013-10-07 14:44 ` Rob Clark
2013-10-06 0:45 ` [RFCv1 03/12] drm: add DRM_MODE_PROP_DYNAMIC property flag Rob Clark
2013-10-07 13:46 ` Ville Syrjälä
2013-10-07 14:46 ` Rob Clark
2013-10-06 0:45 ` [RFCv1 04/12] drm: add DRM_MODE_PROP_SIGNED " Rob Clark
2013-10-07 14:46 ` Matt Plumtree
2013-10-06 0:45 ` [RFCv1 05/12] drm: helpers to find mode objects (BEFORE drm: split property values out) Rob Clark
2013-10-06 0:48 ` Rob Clark
2013-10-06 0:45 ` [RFCv1 06/12] drm: split propvals out and blob property support Rob Clark
2013-10-06 0:45 ` Rob Clark [this message]
2013-10-06 0:45 ` [RFCv1 08/12] drm: Refactor object property check code Rob Clark
2013-10-07 13:47 ` Ville Syrjälä
2013-10-06 0:45 ` [RFCv1 09/12] drm: convert plane to properties/state Rob Clark
2013-10-06 0:45 ` [RFCv1 10/12] drm: convert crtc " Rob Clark
2013-10-07 13:39 ` Ville Syrjälä
2013-10-07 14:03 ` Rob Clark
2013-10-07 14:19 ` Ville Syrjälä
2013-10-07 14:29 ` Rob Clark
2013-10-07 17:51 ` Daniel Vetter
2013-10-06 0:45 ` [RFCv1 11/12] drm: Atomic modeset ioctl Rob Clark
2013-10-07 13:28 ` Ville Syrjälä
2013-10-07 13:55 ` Rob Clark
2013-10-07 14:18 ` Ville Syrjälä
2013-10-07 14:39 ` Rob Clark
2013-10-07 15:05 ` Ville Syrjälä
2013-10-07 15:20 ` Rob Clark
2013-10-07 17:56 ` Daniel Vetter
2013-10-07 18:49 ` Rob Clark
2013-10-08 18:35 ` Matt Roper
2013-10-08 18:46 ` Rob Clark
2013-10-06 0:45 ` [RFCv1 12/12] ARM: add get_user() support for 8 byte types Rob Clark
2013-10-06 8:53 ` Russell King - ARM Linux
2013-10-06 14:09 ` Rob Clark
2013-10-06 15:56 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381020350-1125-8-git-send-email-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).