From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Herrmann Subject: [PATCH 1/6] drm: call drm_unplug_minor() from drm_put_minor() Date: Sun, 20 Oct 2013 18:55:40 +0200 Message-ID: <1382288145-1776-1-git-send-email-dh.herrmann@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f180.google.com (mail-ea0-f180.google.com [209.85.215.180]) by gabe.freedesktop.org (Postfix) with ESMTP id DC439E715C for ; Sun, 20 Oct 2013 09:55:57 -0700 (PDT) Received: by mail-ea0-f180.google.com with SMTP id h10so2947030eaj.25 for ; Sun, 20 Oct 2013 09:55:56 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This protects drm_unplug_minor() against repeated calls so we can use it in drm_put_minor(). This allows us to further simplify it in follow-ups as we no longer do minor-destruction in both functions but only in drm_unplug_minor(). Also add kernel-doc comments about what these calls do. Signed-off-by: David Herrmann --- drivers/gpu/drm/drm_stub.c | 33 ++++++++++++++++++++++++--------- 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index c181b71..abc9d49 100644 --- a/drivers/gpu/drm/drm_stub.c +++ b/drivers/gpu/drm/drm_stub.c @@ -324,10 +324,30 @@ err_idr: EXPORT_SYMBOL(drm_get_minor); /** - * Put a secondary minor number. + * drm_unplug_minor - Unplug DRM minor + * @minor: Minor to unplug * - * \param sec_minor - structure to be released - * \return always zero + * Unplugs the given DRM minor but keeps the object. So after this returns, + * minor->dev is still valid so existing open-files can still access it to get + * device information from their drm_file ojects. + * If the minor is already unplugged or if @minor is NULL, nothing is done. + * The global DRM mutex must be held by the caller. + */ +static void drm_unplug_minor(struct drm_minor *minor) +{ + if (!minor || !device_is_registered(&minor->kdev)) + return; + + drm_sysfs_device_remove(minor); +} + +/** + * drm_put_minor - Destroy DRM minor + * @minor_p: Double pointer to DRM minor + * + * This calls drm_unplug_minor() on the given minor and then frees it. The minor + * pointer is reset to NULL before this returns. + * The global DRM mutex must be held by the caller. */ int drm_put_minor(struct drm_minor **minor_p) { @@ -339,7 +359,7 @@ int drm_put_minor(struct drm_minor **minor_p) drm_debugfs_cleanup(minor); #endif - drm_sysfs_device_remove(minor); + drm_unplug_minor(minor); idr_remove(&drm_minors_idr, minor->index); @@ -349,11 +369,6 @@ int drm_put_minor(struct drm_minor **minor_p) } EXPORT_SYMBOL(drm_put_minor); -static void drm_unplug_minor(struct drm_minor *minor) -{ - drm_sysfs_device_remove(minor); -} - /** * Called via drm_exit() at module unload time or when pci device is * unplugged. -- 1.8.4.1