dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Mario Kleiner <mario.kleiner.de@gmail.com>
To: dri-devel@lists.freedesktop.org, airlied@gmail.com
Cc: alexdeucher@gmail.com, intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/4] drm: Remove preempt_disable() from vblank timestamping code.
Date: Sat, 26 Oct 2013 10:27:39 +0200	[thread overview]
Message-ID: <1382776062-3770-2-git-send-email-mario.kleiner.de@gmail.com> (raw)
In-Reply-To: <1382776062-3770-1-git-send-email-mario.kleiner.de@gmail.com>

Preemption handling will get pushed into the kms
drivers in followup patches, to make timestamping
more robust and PREEMPT_RT friendly.

Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
---
 drivers/gpu/drm/drm_irq.c |    7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
index f9af048..33ee515 100644
--- a/drivers/gpu/drm/drm_irq.c
+++ b/drivers/gpu/drm/drm_irq.c
@@ -586,11 +586,6 @@ int drm_calc_vbltimestamp_from_scanoutpos(struct drm_device *dev, int crtc,
 	 * code gets preempted or delayed for some reason.
 	 */
 	for (i = 0; i < DRM_TIMESTAMP_MAXRETRIES; i++) {
-		/* Disable preemption to make it very likely to
-		 * succeed in the first iteration even on PREEMPT_RT kernel.
-		 */
-		preempt_disable();
-
 		/* Get system timestamp before query. */
 		stime = ktime_get();
 
@@ -602,8 +597,6 @@ int drm_calc_vbltimestamp_from_scanoutpos(struct drm_device *dev, int crtc,
 		if (!drm_timestamp_monotonic)
 			mono_time_offset = ktime_get_monotonic_offset();
 
-		preempt_enable();
-
 		/* Return as no-op if scanout query unsupported or failed. */
 		if (!(vbl_status & DRM_SCANOUTPOS_VALID)) {
 			DRM_DEBUG("crtc %d : scanoutpos query failed [%d].\n",
-- 
1.7.10.4

  reply	other threads:[~2013-10-26  8:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-26  8:27 Vblank timestamping improvements/fixes for Linux drm Mario Kleiner
2013-10-26  8:27 ` Mario Kleiner [this message]
2013-10-26  8:27 ` [PATCH 2/4] drm: Push latency sensitive bits of vblank scanoutpos timestamping into kms drivers Mario Kleiner
2013-10-26  8:27 ` [PATCH 3/4] drm/radeon: Push get_scanout_position() timestamping into kms driver Mario Kleiner
2013-10-26  8:27 ` [PATCH 4/4] drm/intel: " Mario Kleiner
2013-10-28 11:08 ` Vblank timestamping improvements/fixes for Linux drm Ville Syrjälä
2013-10-28 15:54 ` Alex Deucher
  -- strict thread matches above, loose matches on Subject: below --
2013-10-30  4:13 Vblank timestamping improvements/fixes for Linux drm. [v2] Mario Kleiner
2013-10-30  4:13 ` [PATCH 1/4] drm: Remove preempt_disable() from vblank timestamping code Mario Kleiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382776062-3770-2-git-send-email-mario.kleiner.de@gmail.com \
    --to=mario.kleiner.de@gmail.com \
    --cc=airlied@gmail.com \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).