From: Keith Packard <keithp@keithp.com>
To: mesa-dev@lists.freedesktop.org, Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org
Subject: [PATCH 4/4] dri3: Enable GLX_INTEL_swap_event
Date: Mon, 25 Nov 2013 21:35:55 -0800 [thread overview]
Message-ID: <1385444155-15506-5-git-send-email-keithp@keithp.com> (raw)
In-Reply-To: <1385444155-15506-1-git-send-email-keithp@keithp.com>
Now that we're tracking SBC values correctly, and the X server has the ability
to send the GLX swap events from a PresentPixmap request, enable this extension.
Signed-off-by: Keith Packard <keithp@keithp.com>
---
src/glx/dri3_glx.c | 18 +-----------------
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c
index da3f08b..aa5dd21 100644
--- a/src/glx/dri3_glx.c
+++ b/src/glx/dri3_glx.c
@@ -1525,23 +1525,7 @@ dri3_bind_extensions(struct dri3_screen *psc, struct glx_display * priv,
__glXEnableDirectExtension(&psc->base, "GLX_SGI_swap_control");
__glXEnableDirectExtension(&psc->base, "GLX_MESA_swap_control");
__glXEnableDirectExtension(&psc->base, "GLX_SGI_make_current_read");
-
- /*
- * GLX_INTEL_swap_event is broken on the server side, where it's
- * currently unconditionally enabled. This completely breaks
- * systems running on drivers which don't support that extension.
- * There's no way to test for its presence on this side, so instead
- * of disabling it unconditionally, just disable it for drivers
- * which are known to not support it, or for DDX drivers supporting
- * only an older (pre-ScheduleSwap) version of DRI2.
- *
- * This is a hack which is required until:
- * http://lists.x.org/archives/xorg-devel/2013-February/035449.html
- * is merged and updated xserver makes it's way into distros:
- */
-// if (pdp->swapAvailable && strcmp(driverName, "vmwgfx") != 0) {
-// __glXEnableDirectExtension(&psc->base, "GLX_INTEL_swap_event");
-// }
+ __glXEnableDirectExtension(&psc->base, "GLX_INTEL_swap_event");
mask = psc->image_driver->getAPIMask(psc->driScreen);
--
1.8.4.4
prev parent reply other threads:[~2013-11-26 5:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 6:54 [PATCH] present: Send GLX_BufferSwapComplete events from present extension Keith Packard
[not found] ` <1385103256-24620-1-git-send-email-keithp-aN4HjG94KOLQT0dZR+AlfA@public.gmane.org>
2013-11-25 22:46 ` Eric Anholt
2013-11-26 2:39 ` Keith Packard
2013-11-26 5:35 ` [PATCH 0/4] Clean up dri3 SBC handling, enable GLX_INTEL_swap_event Keith Packard
2013-11-26 5:35 ` [PATCH 1/4] dri3: Clean up struct dri3_drawable Keith Packard
2013-12-13 23:01 ` Kenneth Graunke
2013-11-26 5:35 ` [PATCH 2/4] dri3: Track full 64-bit SBC numbers, instead of just 32-bits Keith Packard
2013-11-26 5:35 ` [PATCH 3/4] dri3: Fix dri3_wait_for_sbc to wait for completion of requested SBC Keith Packard
2013-11-26 5:35 ` Keith Packard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385444155-15506-5-git-send-email-keithp@keithp.com \
--to=keithp@keithp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=mesa-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox