* [PATCH v2] staging: imx-drm: imx-tve: Fix a sparse warning
@ 2013-12-24 2:17 Liu Ying
2014-01-02 12:23 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Liu Ying @ 2013-12-24 2:17 UTC (permalink / raw)
To: dri-devel; +Cc: devel, fabio.estevam, gregkh
This patch declares the function of_get_tve_mode
as a static one to fix this sparse warning:
drivers/staging/imx-drm/imx-tve.c:563:11: warning: \
symbol 'of_get_tve_mode' was not declared. \
Should it be static?
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
---
Changes from v2:
-Just added Shawn Guo's ack.
drivers/staging/imx-drm/imx-tve.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/imx-drm/imx-tve.c b/drivers/staging/imx-drm/imx-tve.c
index 2c44fef..9abc7ca 100644
--- a/drivers/staging/imx-drm/imx-tve.c
+++ b/drivers/staging/imx-drm/imx-tve.c
@@ -560,7 +560,7 @@ static const char *imx_tve_modes[] = {
[TVE_MODE_VGA] = "vga",
};
-const int of_get_tve_mode(struct device_node *np)
+static const int of_get_tve_mode(struct device_node *np)
{
const char *bm;
int ret, i;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] staging: imx-drm: imx-tve: Fix a sparse warning
2013-12-24 2:17 [PATCH v2] staging: imx-drm: imx-tve: Fix a sparse warning Liu Ying
@ 2014-01-02 12:23 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-01-02 12:23 UTC (permalink / raw)
To: Liu Ying; +Cc: devel, fabio.estevam, gregkh, dri-devel
On Tue, Dec 24, 2013 at 10:17:44AM +0800, Liu Ying wrote:
> This patch declares the function of_get_tve_mode
> as a static one to fix this sparse warning:
> drivers/staging/imx-drm/imx-tve.c:563:11: warning: \
> symbol 'of_get_tve_mode' was not declared. \
> Should it be static?
>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
> ---
> Changes from v2:
> -Just added Shawn Guo's ack.
No need to do that.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-02 12:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-24 2:17 [PATCH v2] staging: imx-drm: imx-tve: Fix a sparse warning Liu Ying
2014-01-02 12:23 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).